From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 52D1A42981 for ; Tue, 18 Apr 2023 20:15:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 43ABA410EF; Tue, 18 Apr 2023 20:15:30 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id C00AE4014F; Tue, 18 Apr 2023 20:15:27 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 0744221C1E6E; Tue, 18 Apr 2023 11:15:27 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 0744221C1E6E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1681841727; bh=+6rKgHSjqtCDctMtlphGETkOqSeZPFwE//IJ5dsnOvY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QD35dri4nHHUJ+q/sVcYKnkCIrf+RguZX1aWx6K14K5Tpxjl+vegCe4Yjb0guHUvt lgZQmiZBZU+XedAm8LUyu+qQpS0pZF4SFKz9kXNoRODh4+RfpH+vc7oJLlHgWq0FUG VVKldPtqgWEBDc8/+Z8+NQIMUioN2sPFKo35gKYc= Date: Tue, 18 Apr 2023 11:15:27 -0700 From: Tyler Retzlaff To: David Marchand Cc: dev@dpdk.org, stable@dpdk.org, Maxime Coquelin , Chenbo Xia , Yuanhan Liu , Wenfeng Liu , Jianfeng Tan Subject: Re: [PATCH] net/virtio-user: fix leak when initialisation fails Message-ID: <20230418181526.GB29145@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20230413101041.1638478-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230413101041.1638478-1-david.marchand@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Thu, Apr 13, 2023 at 12:10:41PM +0200, David Marchand wrote: > Caught with ASan. > If initialising a virtio_user port fails, we may leak the ifname passed > via a devargs. > > Fixes: 4214a1b493f2 ("net/virtio-user: support changing tap interface name") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > --- Acked-by: Tyler Retzlaff