From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D45342B2C for ; Wed, 17 May 2023 17:19:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 894CC406B7; Wed, 17 May 2023 17:19:29 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 3CCD140041; Wed, 17 May 2023 17:19:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684336768; x=1715872768; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=j6+gUEt0WjBRvNSogUyYHRqznbJqtdtS5kybjy4qjX0=; b=ZwMZE6kED/VG2FHlbnlGiMv3ubA2zf9gal3kapfOFveFs+6j3L2sdzIu WXAkidNaQ1e0nufFG9Av2dueGKZgpQKUuZxQXmGEY4rcyMJy1eTnu3GLb Y7lDfNB9kZeczxHIjkLKEmTwc1dAp/ovzz5/uaMPy25E9oaHD6rb9jFtV GnftSuZ/83pb3ANI/ltFBHaEYVIaAFyi8thKhG5LD1RkfVRK9hQJDgGqL p/G85qcrARIZp7Jt96RpO7jxg3s27833ak2XYthOhCCtsa7BQibF/siw8 o5imPvSdvnhmNWz+It8kaCJM6qVRiGAstymI7H0ZCSYA8kBSCK4p4sFCY A==; X-IronPort-AV: E=McAfee;i="6600,9927,10713"; a="350620377" X-IronPort-AV: E=Sophos;i="5.99,282,1677571200"; d="scan'208";a="350620377" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2023 08:19:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10713"; a="825993553" X-IronPort-AV: E=Sophos;i="5.99,282,1677571200"; d="scan'208";a="825993553" Received: from silpixa00400355.ir.intel.com (HELO silpixa00400355.ger.corp.intel.com) ([10.237.222.80]) by orsmga004.jf.intel.com with ESMTP; 17 May 2023 08:19:19 -0700 From: Ciara Power To: Kai Ji , Pablo de Lara Cc: dev@dpdk.org, Ciara Power , stable@dpdk.org Subject: [PATCH v2] crypto/ipsec_mb: fix allocating mb_mgr in session Date: Wed, 17 May 2023 15:19:16 +0000 Message-Id: <20230517151916.1048475-1-ciara.power@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230517151339.1047237-1-ciara.power@intel.com> References: <20230517151339.1047237-1-ciara.power@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org When configuring the session, use the queue pair mb_mgr that was already allocated if possible. If this doesn't exist, then allocate a new mb_mgr. This reduces unnecessary cycles creating an mb_mgr for every session configured. Fixes: c75542ae4200 ("crypto/ipsec_mb: introduce IPsec_mb framework") Cc: stable@dpdk.org Signed-off-by: Pablo de Lara Signed-off-by: Ciara Power --- v2: fixed indents --- drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c index 3e52f95674..30f919cd40 100644 --- a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c +++ b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c @@ -434,15 +434,22 @@ ipsec_mb_sym_session_configure( struct ipsec_mb_dev_private *internals = dev->data->dev_private; struct ipsec_mb_internals *pmd_data = &ipsec_mb_pmds[internals->pmd_type]; - IMB_MGR *mb_mgr = alloc_init_mb_mgr(); + struct ipsec_mb_qp *qp = dev->data->queue_pairs[0]; + IMB_MGR *mb_mgr; int ret = 0; + if (qp != NULL) + mb_mgr = qp->mb_mgr; + else + mb_mgr = alloc_init_mb_mgr(); + if (!mb_mgr) return -ENOMEM; if (unlikely(sess == NULL)) { IPSEC_MB_LOG(ERR, "invalid session struct"); - free_mb_mgr(mb_mgr); + if (qp == NULL) + free_mb_mgr(mb_mgr); return -EINVAL; } @@ -452,11 +459,13 @@ ipsec_mb_sym_session_configure( IPSEC_MB_LOG(ERR, "failed configure session parameters"); /* Return session to mempool */ - free_mb_mgr(mb_mgr); + if (qp == NULL) + free_mb_mgr(mb_mgr); return ret; } - free_mb_mgr(mb_mgr); + if (qp == NULL) + free_mb_mgr(mb_mgr); return 0; } -- 2.25.1