From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2634942B70 for ; Mon, 22 May 2023 11:55:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1E5D942D31; Mon, 22 May 2023 11:55:42 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 1A8B4410D1; Mon, 22 May 2023 11:55:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684749339; x=1716285339; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=asnWDOeIvi7hL438cou4OU+UaNQpWcst9Dvsmf/oORg=; b=E/dA6ixHjqPzfVBqfPlEja4n1f8QkHsmB1/cnlQ6D9pEwXNt7h9G1z57 f2ydSyKcUhAn3a3LKhQ5eTJXiAT58b6WU7cAFKIbpf5ghj2/HOplIHVL5 bcUsey4+BWiiJWoU4Cxweeqx0Kj3JLFIQv9XIbrJCyepC1u1DrAnQF7o/ UfhM5d8V+CADDr8YDH0vsYkkMakR4cF/ubJCo5547WbeNSQGFvtk2w74u Rt8OY3m/mxGojtqYvMVcq+8dszKWQvM5WpdYaBmJ2210UCjUV3FaLzl4G MliYHR0ds+LruwFOUHN+zlW8z6l6Lo//ekiVsWCjAhkjApZnR+TXhuqxh g==; X-IronPort-AV: E=McAfee;i="6600,9927,10717"; a="333242237" X-IronPort-AV: E=Sophos;i="6.00,184,1681196400"; d="scan'208";a="333242237" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2023 02:55:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10717"; a="703443661" X-IronPort-AV: E=Sophos;i="6.00,184,1681196400"; d="scan'208";a="703443661" Received: from dpdk-qzhan15-test02.sh.intel.com ([10.67.115.37]) by orsmga002.jf.intel.com with ESMTP; 22 May 2023 02:55:36 -0700 From: Qi Zhang To: qiming.yang@intel.com Cc: dev@dpdk.org, Qi Zhang , stable@dpdk.org Subject: [PATCH] net/ice: fix data length check Date: Mon, 22 May 2023 14:14:47 -0400 Message-Id: <20230522181447.2747713-1-qi.z.zhang@intel.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org In TSO, It is possible mbuf->data_len exceed mtu. Fixed the incorrect data length check in ice_prep_pkts. Fixes: ccf33dccf7aa ("net/ice: check illegal packet sizes") Cc: stable@dpdk.org Signed-off-by: Qi Zhang --- drivers/net/ice/ice_rxtx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c index 560c1a4af7..f4a4f43636 100644 --- a/drivers/net/ice/ice_rxtx.c +++ b/drivers/net/ice/ice_rxtx.c @@ -3671,7 +3671,6 @@ ice_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, struct rte_mbuf *m; struct ice_tx_queue *txq = tx_queue; struct rte_eth_dev *dev = &rte_eth_devices[txq->port_id]; - uint16_t max_frame_size = dev->data->mtu + ICE_ETH_OVERHEAD; for (i = 0; i < nb_pkts; i++) { m = tx_pkts[i]; @@ -3690,7 +3689,7 @@ ice_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, /* check the data_len in mbuf */ if (m->data_len < ICE_TX_MIN_PKT_LEN || - m->data_len > max_frame_size) { + m->data_len > ICE_FRAME_SIZE_MAX) { rte_errno = EINVAL; PMD_DRV_LOG(ERR, "INVALID mbuf: bad data_len=[%hu]", m->data_len); return i; -- 2.31.1