From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79D4B42CBC for ; Thu, 15 Jun 2023 03:33:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6F9FB40E0F; Thu, 15 Jun 2023 03:33:57 +0200 (CEST) Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by mails.dpdk.org (Postfix) with ESMTP id E4D9440DDA for ; Thu, 15 Jun 2023 03:33:55 +0200 (CEST) Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-311153ec442so78526f8f.1 for ; Wed, 14 Jun 2023 18:33:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686792835; x=1689384835; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UCJBYUPy+OrrF9yAKEmcTFjOBwxJpzorjZ1KymBbeOk=; b=KqxVDxkm0e/6U9v/1T2KXHXrtAKg7TmlPEQyhtXxIhjHiGWoYKCi5fB0A5ppx++maq 1t0BDgzEyaIteLBIdxnlP8tQVFNfbUPOJAgAGDMzLo4TfrgAfvvQhDv7GmkYXDgtL4oj KKFKwv69AaULO2YrF8XCWUdRPBjXZ03SDJmQ78LFMLfykAwdRxs//I8wNS3C5HmHH1iq XD5cbM9jVQv9AMT+E8XuTWocp8NU235hHnu1u3rwyNGcc4Aa32A0M9zg4oiHhsHZYE5b Ek+dI+ZerpQ1slYI4JsOGr76gXNKXpLdiPQyh4hE6YOmnBT48U+cyee5FC94Xw2NM1S3 OCbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686792835; x=1689384835; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UCJBYUPy+OrrF9yAKEmcTFjOBwxJpzorjZ1KymBbeOk=; b=YXoLcb+mCRLKhn+AjNidnSXZsiDhsGUzPRDd1KAy6mewps7GwmkheKMsQxF0JCqbvZ My52+QD0KSrYSCPKfRYqShaUEvJo/OHzbX3tTUAM9slSKqJkr21kwLxW4TQe45b95DaT YIFT12IpTuJ/xnonXzy+5i+WTSfedHBajPDhEpweje/28gPNtv4HrkcWlLib0VcZoIvy oFGw78ZGMrvuznoJj2X0DIK+KpdARi9tP3bTwNoAohkFyHwsi6VAE/6LoPIPHhW1bbYZ 7qyDIwH/uWXIsMG2vgVYPLVDE251lSpYaJe2cRV2fKcdnOHkzwCmfjc6HlLuuirG8sea v55g== X-Gm-Message-State: AC+VfDwARkzpJvWaHxzoKB95gCKu0dUbY2lzaVfD+cltwZuE9Ct1V7o6 0TRFUyUEvG4k01OAX05SKyDgkXHAImmTG3l8 X-Google-Smtp-Source: ACHHUZ7EBdxDUQ/czW/U6gOBMDy/EYE6qtgH8w+nffg5M0Ra9RrUKbLQwTb60v+oCAZOhxH/cuyXZg== X-Received: by 2002:a5d:4687:0:b0:30f:ba3a:85c5 with SMTP id u7-20020a5d4687000000b0030fba3a85c5mr2756478wrq.25.1686792835584; Wed, 14 Jun 2023 18:33:55 -0700 (PDT) Received: from localhost ([137.220.119.58]) by smtp.gmail.com with ESMTPSA id h14-20020a5d6e0e000000b003078354f774sm19479999wrz.36.2023.06.14.18.33.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jun 2023 18:33:55 -0700 (PDT) From: luca.boccassi@gmail.com To: Jerin Jacob Cc: Dongdong Liu , dpdk stable Subject: patch 'net/hns3: fix build warning' has been queued to stable release 20.11.9 Date: Thu, 15 Jun 2023 02:32:15 +0100 Message-Id: <20230615013258.1439718-20-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230615013258.1439718-1-luca.boccassi@gmail.com> References: <20230615013258.1439718-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/17/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/4397ebd4c901c44a2111bd86ccc76227dc2eb952 Thanks. Luca Boccassi --- >From 4397ebd4c901c44a2111bd86ccc76227dc2eb952 Mon Sep 17 00:00:00 2001 From: Jerin Jacob Date: Tue, 4 Apr 2023 12:25:25 +0530 Subject: [PATCH] net/hns3: fix build warning MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 60fe5c3cfc3c28952448d2163c4eb1d22d86ccac ] aarch64 gcc 12.2.0 build complain with below warning[1]. Move the new_link initialization upwards to fix the warning. [1] drivers/net/hns3/hns3_ethdev.c: In function ‘hns3_dev_link_update’: drivers/net/hns3/hns3_ethdev.c:2249:1: warning: ‘new_link’ may be used uninitialized [-Wmaybe-uninitialized] Fixes: 64308555d5bf ("net/hns3: fix link status when port is stopped") Signed-off-by: Jerin Jacob Acked-by: Dongdong Liu --- drivers/net/hns3/hns3_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c index 8d5e1f4beb..1ffa67f9e7 100644 --- a/drivers/net/hns3/hns3_ethdev.c +++ b/drivers/net/hns3/hns3_ethdev.c @@ -2701,6 +2701,7 @@ hns3_dev_link_update(struct rte_eth_dev *eth_dev, struct rte_eth_link new_link; int ret; + memset(&new_link, 0, sizeof(new_link)); /* When port is stopped, report link down. */ if (eth_dev->data->dev_started == 0) { new_link.link_autoneg = mac->link_autoneg; @@ -2716,7 +2717,6 @@ hns3_dev_link_update(struct rte_eth_dev *eth_dev, hns3_err(hw, "failed to get port link info, ret = %d.", ret); } - memset(&new_link, 0, sizeof(new_link)); hns3_setup_linkstatus(eth_dev, &new_link); out: -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-06-15 01:56:35.819944531 +0100 +++ 0020-net-hns3-fix-build-warning.patch 2023-06-15 01:56:34.547540867 +0100 @@ -1 +1 @@ -From 60fe5c3cfc3c28952448d2163c4eb1d22d86ccac Mon Sep 17 00:00:00 2001 +From 4397ebd4c901c44a2111bd86ccc76227dc2eb952 Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit 60fe5c3cfc3c28952448d2163c4eb1d22d86ccac ] + @@ -18 +19,0 @@ -Cc: stable@dpdk.org @@ -27 +28 @@ -index 36896f8989..a872cb8dd7 100644 +index 8d5e1f4beb..1ffa67f9e7 100644 @@ -30 +31 @@ -@@ -2257,6 +2257,7 @@ hns3_dev_link_update(struct rte_eth_dev *eth_dev, int wait_to_complete) +@@ -2701,6 +2701,7 @@ hns3_dev_link_update(struct rte_eth_dev *eth_dev, @@ -38,3 +39,3 @@ -@@ -2280,7 +2281,6 @@ hns3_dev_link_update(struct rte_eth_dev *eth_dev, int wait_to_complete) - rte_delay_ms(HNS3_LINK_CHECK_INTERVAL); - } while (retry_cnt--); +@@ -2716,7 +2717,6 @@ hns3_dev_link_update(struct rte_eth_dev *eth_dev, + hns3_err(hw, "failed to get port link info, ret = %d.", ret); + }