From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA29A42CBC for ; Thu, 15 Jun 2023 03:34:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C561742D30; Thu, 15 Jun 2023 03:34:10 +0200 (CEST) Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by mails.dpdk.org (Postfix) with ESMTP id BFF9042D30 for ; Thu, 15 Jun 2023 03:34:08 +0200 (CEST) Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-4f76a223ca5so1613240e87.3 for ; Wed, 14 Jun 2023 18:34:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686792848; x=1689384848; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DLDEGDcxqdh1ivrRuBAobd5lrob38PMe9RWa6UkQF3s=; b=f82Ejwx5lJKz8Wz7sX56/eGom+zmLTFHg69Pb57O9VD1cTb30pEmV1YeV41zzW57qD TdBRuxdQ9wV+lmVoJG9owfEpqGobvr8+XQ0oPWBBPy9dpc9lo5gPNOsFCLA0a0Axfcrx UmofRm9w3miug0imyGr0coV9qKRQRFaP6psLUF4LxaKx8yXucKPxQHneerjwakp+UpAl KQk1cyrC5pkzx7SjoEqwszVjgYFDQHy3HmMlzbn0C4VIEnWmed+8PdspRMmi6Ry8R0L0 iNMhPs+4UQucmeQD167QNJfYxIEXMKsrJ5zArAFOQmmGzwRHJVruc/+P0qJIIJw3HluS OzpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686792848; x=1689384848; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DLDEGDcxqdh1ivrRuBAobd5lrob38PMe9RWa6UkQF3s=; b=JWn9/3FR9PgW920zN7LzsM+U0hGcrST6dYTDBCG1KgCxRB5R6wdQk8YwZR7mspGgc0 TAxrbh3Uy5rxg73i+mdIBiYdsP/vYoW2WFJx7TxiCt2FhlSjCcspwk4AAcVsQIgytri9 VDNBVZfIdlMHFqiacAJLxjhllS6HdUQK5pEdFpwd6a45REWsKmqJM4RkFO3EN4qNRcvd xK8FR4rGPu/sZFOwUiNw5ESrX0GZKKXF6fqcXvc9vvwGLTJpXB0ok3Wp9WdoaYWHErws +P8TVs1c5FQ4mcF6vtfgrUxhLSyUl9GO/3dC7uDYCuNZYzY/fqFZxlJira/AsDA7i/fP 8BtQ== X-Gm-Message-State: AC+VfDw3xTv9VOn3QzgURN2z48KiMMZJVH6TeJPDoLanvW8g9tOvJRH/ XX816pksazKQ0XUzA48hsdg= X-Google-Smtp-Source: ACHHUZ6ZKsJ+7L6TiSRP+PhfwVTRZLze5xvExXiotc3OjVzVcaiiOtq9ONpdm8Hbsmj1ag031K7wiQ== X-Received: by 2002:a19:7b04:0:b0:4f3:b61a:a941 with SMTP id w4-20020a197b04000000b004f3b61aa941mr8402537lfc.51.1686792847990; Wed, 14 Jun 2023 18:34:07 -0700 (PDT) Received: from localhost ([2a01:4b00:d307:1000:f1d3:eb5e:11f4:a7d9]) by smtp.gmail.com with ESMTPSA id i1-20020adfefc1000000b0030647449730sm19794387wrp.74.2023.06.14.18.34.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jun 2023 18:34:07 -0700 (PDT) From: luca.boccassi@gmail.com To: Tianli Lai Cc: Sachin Saxena , dpdk stable Subject: patch 'net/dpaa2: fix checksum good flags' has been queued to stable release 20.11.9 Date: Thu, 15 Jun 2023 02:32:17 +0100 Message-Id: <20230615013258.1439718-22-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230615013258.1439718-1-luca.boccassi@gmail.com> References: <20230615013258.1439718-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/17/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/076bdbf8164f628e3ecf6315e8c0c46abe3347f7 Thanks. Luca Boccassi --- >From 076bdbf8164f628e3ecf6315e8c0c46abe3347f7 Mon Sep 17 00:00:00 2001 From: Tianli Lai Date: Mon, 8 May 2023 18:57:25 +0800 Subject: [PATCH] net/dpaa2: fix checksum good flags [ upstream commit 7d83632b28db9f0b9bd36d974798aa14627f822b ] Set check sum good flags when dpaa2 hardware set check result. Fixes: d2ef05d5c13e ("net/dpaa2: optimize Rx/Tx path") Fixes: 94d31549c380 ("net/dpaa2: support Rx checksum offload in slow parsing") Signed-off-by: Tianli Lai Acked-by: Sachin Saxena --- drivers/net/dpaa2/dpaa2_rxtx.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_rxtx.c b/drivers/net/dpaa2/dpaa2_rxtx.c index 23e193f86c..1ad42747c4 100644 --- a/drivers/net/dpaa2/dpaa2_rxtx.c +++ b/drivers/net/dpaa2/dpaa2_rxtx.c @@ -187,8 +187,12 @@ dpaa2_dev_rx_parse_slow(struct rte_mbuf *mbuf, if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L3CE)) mbuf->ol_flags |= PKT_RX_IP_CKSUM_BAD; - else if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L4CE)) + else + mbuf->ol_flags |= PKT_RX_IP_CKSUM_GOOD; + if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L4CE)) mbuf->ol_flags |= PKT_RX_L4_CKSUM_BAD; + else + mbuf->ol_flags |= PKT_RX_L4_CKSUM_GOOD; if (BIT_ISSET_AT_POS(annotation->word4, L3_IP_1_FIRST_FRAGMENT | L3_IP_1_MORE_FRAGMENT | @@ -230,8 +234,12 @@ dpaa2_dev_rx_parse(struct rte_mbuf *mbuf, void *hw_annot_addr) if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L3CE)) mbuf->ol_flags |= PKT_RX_IP_CKSUM_BAD; - else if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L4CE)) + else + mbuf->ol_flags |= PKT_RX_IP_CKSUM_GOOD; + if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L4CE)) mbuf->ol_flags |= PKT_RX_L4_CKSUM_BAD; + else + mbuf->ol_flags |= PKT_RX_L4_CKSUM_GOOD; if (dpaa2_enable_ts[mbuf->port]) { *dpaa2_timestamp_dynfield(mbuf) = annotation->word2; -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-06-15 01:56:35.935701704 +0100 +++ 0022-net-dpaa2-fix-checksum-good-flags.patch 2023-06-15 01:56:34.555541041 +0100 @@ -1 +1 @@ -From 7d83632b28db9f0b9bd36d974798aa14627f822b Mon Sep 17 00:00:00 2001 +From 076bdbf8164f628e3ecf6315e8c0c46abe3347f7 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 7d83632b28db9f0b9bd36d974798aa14627f822b ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index f60e78e1fd..85910bbd8f 100644 +index 23e193f86c..1ad42747c4 100644 @@ -22 +23 @@ -@@ -198,8 +198,12 @@ dpaa2_dev_rx_parse_slow(struct rte_mbuf *mbuf, +@@ -187,8 +187,12 @@ dpaa2_dev_rx_parse_slow(struct rte_mbuf *mbuf, @@ -25 +26 @@ - mbuf->ol_flags |= RTE_MBUF_F_RX_IP_CKSUM_BAD; + mbuf->ol_flags |= PKT_RX_IP_CKSUM_BAD; @@ -28 +29 @@ -+ mbuf->ol_flags |= RTE_MBUF_F_RX_IP_CKSUM_GOOD; ++ mbuf->ol_flags |= PKT_RX_IP_CKSUM_GOOD; @@ -30 +31 @@ - mbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_BAD; + mbuf->ol_flags |= PKT_RX_L4_CKSUM_BAD; @@ -32 +33 @@ -+ mbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD; ++ mbuf->ol_flags |= PKT_RX_L4_CKSUM_GOOD; @@ -36 +37 @@ -@@ -241,8 +245,12 @@ dpaa2_dev_rx_parse(struct rte_mbuf *mbuf, void *hw_annot_addr) +@@ -230,8 +234,12 @@ dpaa2_dev_rx_parse(struct rte_mbuf *mbuf, void *hw_annot_addr) @@ -39 +40 @@ - mbuf->ol_flags |= RTE_MBUF_F_RX_IP_CKSUM_BAD; + mbuf->ol_flags |= PKT_RX_IP_CKSUM_BAD; @@ -42 +43 @@ -+ mbuf->ol_flags |= RTE_MBUF_F_RX_IP_CKSUM_GOOD; ++ mbuf->ol_flags |= PKT_RX_IP_CKSUM_GOOD; @@ -44 +45 @@ - mbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_BAD; + mbuf->ol_flags |= PKT_RX_L4_CKSUM_BAD; @@ -46 +47 @@ -+ mbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD; ++ mbuf->ol_flags |= PKT_RX_L4_CKSUM_GOOD;