From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9B1D42CBC for ; Thu, 15 Jun 2023 03:34:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E26E142D3A; Thu, 15 Jun 2023 03:34:10 +0200 (CEST) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mails.dpdk.org (Postfix) with ESMTP id 8326440DDA for ; Thu, 15 Jun 2023 03:34:09 +0200 (CEST) Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-3f736e0c9b1so13104445e9.3 for ; Wed, 14 Jun 2023 18:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686792849; x=1689384849; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BPy/bggavRuY1WNRLMBPhmiFp5UJz3rVJNrCsPEmBCA=; b=Nqw1XqrLeljVZLC2b6n7whyT3171V9vNVUSEyiEV0KluCOw6dM9jFCXm+FYyKpNMjH iCj+fwOzr+rt6kZNSin0bdYqQSa/9S9yEjf5DToqHmvvpR6foycjqBtIWQIh1Ps5aUGV eqDUyMjmVUlT/uoegE1gaXr+pshVIs+Y+3io0L5X6LCL/BUd7YwIu5vMG6VU12E/AWcR s7m/foKZSHTdSHWMkOsPM8s8l9ee+8cAzFFcyBwwTlOa8k4chD6ZLGoWAIsykYTXfQq1 Bcg9ph4H+T2ocT10B5cBdmN5VXtIXslfiebasqfbDYoprSKD+Ts0nikTb5iwn5qQ6OAg JVkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686792849; x=1689384849; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BPy/bggavRuY1WNRLMBPhmiFp5UJz3rVJNrCsPEmBCA=; b=lgS4LXGotxmGvB4i9PCEK3jC9PVaKozr45e/xJdeBMLBBhsJwPdtbczRjs6OVoROl/ BfF4QENA4GXd3JIfxnj/sCAadXZgwXrqNtg5Glm4kWcxl/fAXOSJHCm9GcTqXTUM0FMC NLh1v0R7AABP1b+qEByjCanSWh/RF51pmDR18X1ab1hziLV4IE6e/0Zcxw5frrfBIvbC nBxSWb/aGztWn45KetYbXZWRDTuY1DuG6PTOMXTVJDqMrXzFYwIAN1qszuFUO/J/jl5m eSRaATAmThlVbim7zJ9lWyXhuMmEZ0Bhy47HxWudmHWb+VoqBJ0GSL2Q29PhbMsv4MVt V2dg== X-Gm-Message-State: AC+VfDyS3N+VqazrYNaVRcD+0IHFMY7OJOimeeVsKSq+Ho4shVqpioRB BFBauL4TDnAXtlxiL8z9EYACOz8EYtKB79GX X-Google-Smtp-Source: ACHHUZ7gCn+ykgFm3UVz425yziEqq3VYO5PzlA4bnEG5YHl+o2X8tDJiYwMJkbjiIy6fcsN5UIF29w== X-Received: by 2002:a05:600c:2198:b0:3f8:1d6c:4587 with SMTP id e24-20020a05600c219800b003f81d6c4587mr7426005wme.19.1686792849157; Wed, 14 Jun 2023 18:34:09 -0700 (PDT) Received: from localhost ([2a01:4b00:d307:1000:f1d3:eb5e:11f4:a7d9]) by smtp.gmail.com with ESMTPSA id m23-20020a7bcb97000000b003f8e4b22bc2sm497828wmi.44.2023.06.14.18.34.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jun 2023 18:34:08 -0700 (PDT) From: luca.boccassi@gmail.com To: Raslan Darawsheh Cc: Aman Singh , dpdk stable Subject: patch 'app/testpmd: fix GTP L2 length in checksum engine' has been queued to stable release 20.11.9 Date: Thu, 15 Jun 2023 02:32:18 +0100 Message-Id: <20230615013258.1439718-23-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230615013258.1439718-1-luca.boccassi@gmail.com> References: <20230615013258.1439718-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/17/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/75a452410f544c5fd459c5d0f68023ae108cdc34 Thanks. Luca Boccassi --- >From 75a452410f544c5fd459c5d0f68023ae108cdc34 Mon Sep 17 00:00:00 2001 From: Raslan Darawsheh Date: Sun, 2 Apr 2023 15:26:19 +0300 Subject: [PATCH] app/testpmd: fix GTP L2 length in checksum engine [ upstream commit dd827fa42a30a9b0aa87a1d5614af83ea32b19e0 ] GTP header can be followed by an optional 32 bits extension. But, l2_len value statically set to RTE_ETHER_GTP_HLEN which is defined to be (sizeof(struct rte_udp_hdr) + sizeof(struct rte_gtp_hdr)) This fixes the l2_len to take into consideration the extension size. Fixes: d8e5e69f3a9b ("app/testpmd: add GTP parsing and Tx checksum offload") Signed-off-by: Raslan Darawsheh Acked-by: Aman Singh --- app/test-pmd/csumonly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index 7a91fcb63f..9b12b91ead 100644 --- a/app/test-pmd/csumonly.c +++ b/app/test-pmd/csumonly.c @@ -246,7 +246,7 @@ parse_gtp(struct rte_udp_hdr *udp_hdr, info->l4_proto = 0; } - info->l2_len += RTE_ETHER_GTP_HLEN; + info->l2_len += gtp_len + sizeof(udp_hdr); } /* Parse a vxlan header */ -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-06-15 01:56:35.990855341 +0100 +++ 0023-app-testpmd-fix-GTP-L2-length-in-checksum-engine.patch 2023-06-15 01:56:34.555541041 +0100 @@ -1 +1 @@ -From dd827fa42a30a9b0aa87a1d5614af83ea32b19e0 Mon Sep 17 00:00:00 2001 +From 75a452410f544c5fd459c5d0f68023ae108cdc34 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit dd827fa42a30a9b0aa87a1d5614af83ea32b19e0 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index fc85c22a77..b50b89367a 100644 +index 7a91fcb63f..9b12b91ead 100644 @@ -27 +28 @@ -@@ -250,7 +250,7 @@ parse_gtp(struct rte_udp_hdr *udp_hdr, +@@ -246,7 +246,7 @@ parse_gtp(struct rte_udp_hdr *udp_hdr,