From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E94C142CBC for ; Thu, 15 Jun 2023 03:35:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DD65B40E0F; Thu, 15 Jun 2023 03:35:14 +0200 (CEST) Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by mails.dpdk.org (Postfix) with ESMTP id C5CC140DDA for ; Thu, 15 Jun 2023 03:35:13 +0200 (CEST) Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-3094910b150so7279730f8f.0 for ; Wed, 14 Jun 2023 18:35:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686792913; x=1689384913; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jCXbLF0ddfxiVAcRkmrC7DmzCCWGR9/5ftxdn9insf8=; b=eQQJXU9jXq1+rh7Dy50CBun8PPnh0CR7VXzV1uiZRlaXaQNykzXZQrdREPWMU5VU/U ncvmK/zduCGgx1e/+JENSxQwQgzChBQVOyvmfAVPVm3RbkeLDYTVBCRWsyRaOFiKY6Sr EmczmtLM7IWDwez9DVuVuhHGfJDw9gr7g1UcLzmPuOR8II8/noUur+xG2Mhx8Bpf/ZNi gDfZzrbPDS957hdZquxu2MXkqH6y0D9m7WJSmOAMCgyuRmXDuAT5IPLsGYz1ph/sHXn0 jM4AMzN+5jAoq5zm9vYyOS5nGMk0qOQAMJA0XQ0JLMJkCEMQrXWpNSVF+nEFHdTV0skh VOmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686792913; x=1689384913; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jCXbLF0ddfxiVAcRkmrC7DmzCCWGR9/5ftxdn9insf8=; b=Z7w0NFzx2bZ85QOVxTBZ7JRGQFSQcppNHKYGhw2KB2zbeHUGUgcDlSV7tt54wZpzOE 5pYYjrarJYtHcsRQRfdRNF0har5kdF7JR1KHW0hVnY5KJqdDGM3VBBEzd+YhMXiGaJrs MvGKmlPbj8YKmsMN7Oi5Xj3FOd9iqkaAnnH388LS3RUddbDWtOZW5r2exi9VxWAUSEsF bnfFseD5XBs2iv4UJWS4ru7mlXTovBi2TNE/nLVutkwHRxuPz4VJfMQaR1Bnt6U0GZpp 7vdzN9P+NtNJdDakFutIrtYPP+enoRBTL6OJMt9THV7v4u5S1YDQJ8fGfTpXAPUbt/A8 ADMQ== X-Gm-Message-State: AC+VfDyAF/iaI70RtUMlhMOAPMkrOzUol+z4QAOqnufsmEBCCTmx4qBK so2qQBlN68JNvKdI7enuaKIfaZFZ2Q0nUU5r X-Google-Smtp-Source: ACHHUZ5xqn7ajcYYb6C5+Ylghsnm7D3SMopq886kRQLDAtDGmfLXX43gSs+6QvX+E5kbPDxoZYg9nw== X-Received: by 2002:adf:f50e:0:b0:30e:4714:bc93 with SMTP id q14-20020adff50e000000b0030e4714bc93mr10107972wro.5.1686792912622; Wed, 14 Jun 2023 18:35:12 -0700 (PDT) Received: from localhost ([2a01:4b00:d307:1000:f1d3:eb5e:11f4:a7d9]) by smtp.gmail.com with ESMTPSA id w18-20020a05600018d200b0030af54c5f33sm19536830wrq.113.2023.06.14.18.35.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jun 2023 18:35:12 -0700 (PDT) From: luca.boccassi@gmail.com To: Ciara Power Cc: Kai Ji , dpdk stable Subject: patch 'crypto/scheduler: fix last element for valid args' has been queued to stable release 20.11.9 Date: Thu, 15 Jun 2023 02:32:37 +0100 Message-Id: <20230615013258.1439718-42-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230615013258.1439718-1-luca.boccassi@gmail.com> References: <20230615013258.1439718-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/17/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/186f0fe587ab45b8bcad15e2bd92d61a120d5ce5 Thanks. Luca Boccassi --- >From 186f0fe587ab45b8bcad15e2bd92d61a120d5ce5 Mon Sep 17 00:00:00 2001 From: Ciara Power Date: Fri, 14 Apr 2023 12:33:06 +0000 Subject: [PATCH] crypto/scheduler: fix last element for valid args [ upstream commit 34019b7b65d4d936649fab29fdee45ec3ada1a8d ] The list of valid arguments for Scheduler PMD should be terminated with a NULL entry, as expected by rte_kvargs_parse. Without this, if an invalid key name was used, a global buffer overflow occurred resulting in a segmentation fault. Fixes: 503e9c5afb38 ("crypto/scheduler: register as vdev driver") Signed-off-by: Ciara Power Acked-by: Kai Ji --- drivers/crypto/scheduler/scheduler_pmd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/scheduler/scheduler_pmd.c b/drivers/crypto/scheduler/scheduler_pmd.c index 632197833c..49eda059ca 100644 --- a/drivers/crypto/scheduler/scheduler_pmd.c +++ b/drivers/crypto/scheduler/scheduler_pmd.c @@ -47,7 +47,8 @@ static const char * const scheduler_valid_params[] = { RTE_CRYPTODEV_VDEV_MAX_NB_QP_ARG, RTE_CRYPTODEV_VDEV_SOCKET_ID, RTE_CRYPTODEV_VDEV_COREMASK, - RTE_CRYPTODEV_VDEV_CORELIST + RTE_CRYPTODEV_VDEV_CORELIST, + NULL }; struct scheduler_parse_map { -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-06-15 01:56:36.852801839 +0100 +++ 0042-crypto-scheduler-fix-last-element-for-valid-args.patch 2023-06-15 01:56:34.643542964 +0100 @@ -1 +1 @@ -From 34019b7b65d4d936649fab29fdee45ec3ada1a8d Mon Sep 17 00:00:00 2001 +From 186f0fe587ab45b8bcad15e2bd92d61a120d5ce5 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 34019b7b65d4d936649fab29fdee45ec3ada1a8d ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index 9d1ce46622..4e8bbf0e09 100644 +index 632197833c..49eda059ca 100644 @@ -25 +26 @@ -@@ -50,7 +50,8 @@ static const char * const scheduler_valid_params[] = { +@@ -47,7 +47,8 @@ static const char * const scheduler_valid_params[] = {