From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E47C742CBC for ; Thu, 15 Jun 2023 03:35:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D6B2C42D52; Thu, 15 Jun 2023 03:35:29 +0200 (CEST) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by mails.dpdk.org (Postfix) with ESMTP id D892342D5F for ; Thu, 15 Jun 2023 03:35:28 +0200 (CEST) Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-30fb7be435dso3617907f8f.1 for ; Wed, 14 Jun 2023 18:35:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686792928; x=1689384928; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kWCBzou76FSngiDsPivBBEGDACsrZsw7LxX0fvmAVLc=; b=kYKpKKl35BB7ghbAXjtwiPQ1FPQGDMFyj9YqljYzs5AlllzS0LBKS17EoNmrW5/fiu ou2IQeJ0mg+IY7gWtRFqLqsKCn3wycsVcVZfvJx8gLlgDa9fNHluJHUIlVfAveoNOiHX 4lXtTBAGmRRus8wdRy9J0ia8H0aXpNNNJRlq8gFSzxs0YPoEDTJyznv10ng4h2yEpDJ1 XCwKQqzvC8oe7zg8uhWz/y1E61uC6hn0Q6Ie8Y/KDiP7oaTueayIHLkx9wrD0RChNKnZ C6s6CGXT51+fRAz+DUVjvwB0AcFcCXPHNnFVF7tcdmVvTosobHhBgTjk9pYhiHm5MFXp OGtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686792928; x=1689384928; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kWCBzou76FSngiDsPivBBEGDACsrZsw7LxX0fvmAVLc=; b=Xn9hSL4OeXal09+y0CSf1+PLLrtEBkKIDRQ5h4mqpCL3lg6pz9w/HrIgSrxsSicBxL VGl+vakGJ4ZX6srbfQjTSAoFS81e6Vfxph2a0Q88IBxFke2wzmDrBBgpRxazfQfbr03C toZmAZaMpdbu9ddccJoLPpUCR/b3sV2QKGcN+bGFtTQVLuquctsfMaqt/XDS3cmTBD76 W/VmZQrFaUGVreZf739/ogMKtspahYi0KfZR+ZtE5NEObBqbRBnEd0EkHI21Td8K38Ib yGsTeO4DbIh50ShYlwbHZhfGtGe9qFDvoVCEYa/ObabZNIcc6F6/x3zAMc+1jJDBJABk y6LQ== X-Gm-Message-State: AC+VfDw+F9AEuX99mY5yfSQ7WHOeMAuocHvvTplznShxuDgaEsZJk3W/ tkBWtcpmRpZxk/XpsI50MkI= X-Google-Smtp-Source: ACHHUZ4yJLPtyPEv/A33ULqH0n6NXCo2WgTsv2hjo+YJetshDDn9IzMmlm54nAR/ced8ZBDfZfD2vw== X-Received: by 2002:adf:fc49:0:b0:30f:bd4f:8f0a with SMTP id e9-20020adffc49000000b0030fbd4f8f0amr6912831wrs.34.1686792928520; Wed, 14 Jun 2023 18:35:28 -0700 (PDT) Received: from localhost ([2a01:4b00:d307:1000:f1d3:eb5e:11f4:a7d9]) by smtp.gmail.com with ESMTPSA id r17-20020a5d52d1000000b002c71b4d476asm19515624wrv.106.2023.06.14.18.35.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jun 2023 18:35:28 -0700 (PDT) From: luca.boccassi@gmail.com To: David Marchand Cc: Gregory Etelson , Raslan Darawsheh , dpdk stable Subject: patch 'net/mlx5: enhance error log for tunnel offloading' has been queued to stable release 20.11.9 Date: Thu, 15 Jun 2023 02:32:42 +0100 Message-Id: <20230615013258.1439718-47-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230615013258.1439718-1-luca.boccassi@gmail.com> References: <20230615013258.1439718-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/17/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/f56bb621ae8449b7ad15216dfaddc8f60065d439 Thanks. Luca Boccassi --- >From f56bb621ae8449b7ad15216dfaddc8f60065d439 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Thu, 27 Apr 2023 13:55:34 +0200 Subject: [PATCH] net/mlx5: enhance error log for tunnel offloading [ upstream commit c9fecc1cc2886bcd626a656a5493841363dec6dd ] Tunnel offloading is linked to running a port with the non-obvious dv_xmeta_en=3 devargs. Hint at it for "normal" users. Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload") Signed-off-by: David Marchand Reviewed-by: Gregory Etelson Acked-by: Raslan Darawsheh --- drivers/net/mlx5/mlx5_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index ad11611027..aad3c5b920 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -7918,7 +7918,7 @@ mlx5_flow_tunnel_validate(struct rte_eth_dev *dev, if (!is_tunnel_offload_active(dev)) return rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION_CONF, NULL, - "tunnel offload was not activated"); + "tunnel offload was not activated, consider setting dv_xmeta_en=3"); if (!tunnel) return rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION_CONF, NULL, -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-06-15 01:56:37.081351938 +0100 +++ 0047-net-mlx5-enhance-error-log-for-tunnel-offloading.patch 2023-06-15 01:56:34.671543576 +0100 @@ -1 +1 @@ -From c9fecc1cc2886bcd626a656a5493841363dec6dd Mon Sep 17 00:00:00 2001 +From f56bb621ae8449b7ad15216dfaddc8f60065d439 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c9fecc1cc2886bcd626a656a5493841363dec6dd ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 156f826b8a..c32783efb2 100644 +index ad11611027..aad3c5b920 100644 @@ -23 +24 @@ -@@ -11329,7 +11329,7 @@ mlx5_flow_tunnel_validate(struct rte_eth_dev *dev, +@@ -7918,7 +7918,7 @@ mlx5_flow_tunnel_validate(struct rte_eth_dev *dev,