From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A31542D83 for ; Wed, 28 Jun 2023 16:11:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4574742D1D; Wed, 28 Jun 2023 16:11:38 +0200 (CEST) Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by mails.dpdk.org (Postfix) with ESMTP id 40DCA42D17 for ; Wed, 28 Jun 2023 16:11:37 +0200 (CEST) Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-4fb5bcb9a28so5703557e87.3 for ; Wed, 28 Jun 2023 07:11:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687961497; x=1690553497; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zex0/wjIsLlEs4vrgPf6auzUPfUZ7m+4zpHCMzJ26RM=; b=Rqxvsk2LtH7vUeYC+yuHpW13zP4wDpjCKK2+znFiNYAafmRzYQxUbs4t1GYi26buie Y7BC4TjeupZqMzTHSl+psxiWUCQaNtY0lp7F+vhgHDnygNlRgGRRrnAek065NPg07BtH EgQq6pDVQ92ZTH3bnrs1kgdDM+L/X01QZtYKMMM4jziexXYCy2bjo6XDkvVaX56jjb6K uQc16gStttBhdgr6KTUwWW8+x65FVnFp7z1xDC3tgTTWWBJKaoQ3lVEt5IumEPcemavi gpEqBsdFyeVi3ocQWJTk8KHQADqybYFHatKK1UGC39uZN0lCJlyPTrYdtbjPEucQKUvY rVew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687961497; x=1690553497; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zex0/wjIsLlEs4vrgPf6auzUPfUZ7m+4zpHCMzJ26RM=; b=Q4+PUmUjdna3+U0BHNh8Wh1iE7boFa8giE7jT3St/hE+xHE6JqVzITOO8utMaKY021 7eWChsJ4oha36Bu8T/097kU9RWOyN2TDrwxnRlSqpvqWxOZw6vgngMhF80PBRIePgXgS DPxsiktPUGRf1upmFif5K0A41yaqm7378J+jwN0gBnrVzgz6743vRQU8xou9N3waAXJO sYMpgIDhHCdUJsRMwDUKIxOrzgw/zzURKkAuO3ck4GZ4Wod9MD8uCf5u2m9vXfgGSqfb Qv+V4FtYAUzq3H33EPGli6ElJ4LuebcyZtR97aB8d/K0C37gkryHQbQaD9UQz7EryacU KwCA== X-Gm-Message-State: AC+VfDyGCP+sukkuaiJ3K3AQ829wrQEEN7pmRyJGLdzOMTtBlFpaqikH VhJChPmd4UTRfWVwPMcmmHU= X-Google-Smtp-Source: ACHHUZ6yh5OnKdTp4CBcdM8sGtWHXL5HH4rZP46ePWu+4FjOPfcteMlV3CmAeBpROKkzR/syg8yudQ== X-Received: by 2002:ac2:4bd0:0:b0:4fb:b11:c99e with SMTP id o16-20020ac24bd0000000b004fb0b11c99emr8048581lfq.56.1687961496373; Wed, 28 Jun 2023 07:11:36 -0700 (PDT) Received: from localhost ([2a01:4b00:d307:1000:f1d3:eb5e:11f4:a7d9]) by smtp.gmail.com with ESMTPSA id c25-20020a05600c4a1900b003fa9a00d74csm5634952wmp.3.2023.06.28.07.11.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jun 2023 07:11:35 -0700 (PDT) From: luca.boccassi@gmail.com To: Artemii Morozov Cc: Andy Moreton , Andrew Rybchenko , dpdk stable Subject: patch 'common/sfc_efx/base: fix Rx queue without RSS hash prefix' has been queued to stable release 20.11.9 Date: Wed, 28 Jun 2023 15:10:38 +0100 Message-Id: <20230628141046.2145871-14-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230628141046.2145871-1-luca.boccassi@gmail.com> References: <20230615013258.1439718-63-luca.boccassi@gmail.com> <20230628141046.2145871-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/30/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/f0f0c2fb68dc6f47d5ae2f885e632badf411015a Thanks. Luca Boccassi --- >From f0f0c2fb68dc6f47d5ae2f885e632badf411015a Mon Sep 17 00:00:00 2001 From: Artemii Morozov Date: Thu, 22 Jun 2023 16:31:36 +0400 Subject: [PATCH] common/sfc_efx/base: fix Rx queue without RSS hash prefix [ upstream commit 80d18a958e4f06e121327073439c391dbc870d80 ] If the prefix for the RSS hash was not chosen the ENOTSUP error should be returned. Before this patch success was returned for this case causing Rx queue creation to fail. Fixing return value to indicate failure. Fixes: f784cdc5cbb1 ("common/sfc_efx/base: provide control to deliver RSS hash") Signed-off-by: Artemii Morozov Reviewed-by: Andy Moreton Acked-by: Andrew Rybchenko --- drivers/common/sfc_efx/base/efx_rx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/common/sfc_efx/base/efx_rx.c b/drivers/common/sfc_efx/base/efx_rx.c index 93a73703ed..1b1b42eedf 100644 --- a/drivers/common/sfc_efx/base/efx_rx.c +++ b/drivers/common/sfc_efx/base/efx_rx.c @@ -896,8 +896,10 @@ efx_rx_qcreate_internal( rss_hash_field = &erplp->erpl_fields[EFX_RX_PREFIX_FIELD_RSS_HASH]; - if (rss_hash_field->erpfi_width_bits == 0) + if (rss_hash_field->erpfi_width_bits == 0) { + rc = ENOTSUP; goto fail5; + } } enp->en_rx_qcount++; -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-06-28 11:40:08.668037959 +0100 +++ 0014-common-sfc_efx-base-fix-Rx-queue-without-RSS-hash-pr.patch 2023-06-28 11:40:08.068027752 +0100 @@ -1 +1 @@ -From 80d18a958e4f06e121327073439c391dbc870d80 Mon Sep 17 00:00:00 2001 +From f0f0c2fb68dc6f47d5ae2f885e632badf411015a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 80d18a958e4f06e121327073439c391dbc870d80 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index 68f42f5cac..61726a9f0b 100644 +index 93a73703ed..1b1b42eedf 100644 @@ -28 +29 @@ -@@ -937,8 +937,10 @@ efx_rx_qcreate_internal( +@@ -896,8 +896,10 @@ efx_rx_qcreate_internal(