From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF05A42DA6 for ; Sat, 15 Jul 2023 00:35:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C8D5D42BAC; Sat, 15 Jul 2023 00:35:01 +0200 (CEST) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mails.dpdk.org (Postfix) with ESMTP id A998942BAC for ; Sat, 15 Jul 2023 00:35:00 +0200 (CEST) Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-3fbc54cab6fso22611495e9.0 for ; Fri, 14 Jul 2023 15:35:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689374100; x=1691966100; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gCipXhpcCbun4VL/mahf6UkTM+q+sK2ugZ5A/gCp5t8=; b=fWFlbD3WvnTq44L3slqnYUDErn8hstTrEE/f88NISoxOdnfQKFwJKnHk8OhfTpkGnp F7KJPGrXqeTfOZ1051GXWiWiKn4SmFanqxbMYX59aCUDseMKYUMEfUNtxss/FTy6RMBd xRiWyHh9jHzn7/qerOd/T9vU6wTtdU+qvvTsfCiW4PVLyCGh2m83+nMcWhN4t7fM1Dos Rd6P9t3qUo46w4k9z5z/R8DCn3+NLjYFRmZb80LHtHzQdF+rnd3r14J+8Jm4iRz/3tEj Cwga7d9F4xc63QWLe0osHvuWcJGeEH7A1isWON/Yxl9WuQlSn1jLFzUEx2Ta/lek3s/u JUBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689374100; x=1691966100; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gCipXhpcCbun4VL/mahf6UkTM+q+sK2ugZ5A/gCp5t8=; b=WucNrsd/OoDqzfNuEilMztaMo4rKfYt21WKVM7KetDJnRWdO2HbqhLWqvGHp4GzTLG 7gDEQLJjCfJ5aHigfqzvgFz1x7uo5MonouM7sHnB5ayS2oqt73/j92DlRYR0mhRgJzx+ fRDVAyRS7kSYioax2FMqLjTlx6QJ6Diq037xgZbjWFzrkZ1qiUwaV2iiaK7WoRWwWT3Y MZmRkirQTilRYQCRBzmCPzaq/VHD/T2+aJloudfjBqnlYdo0B4qx/ELR+R4zPAcmxPL3 wTed6cvQmG2DPapkwO57R0uoohC4f4dGXG4VjcHo65tUZIE247ils102oBOaV90xUJeF UeJw== X-Gm-Message-State: ABy/qLYA8L//AkZ4obMRHdfQuhfW32MZFqNwn6XWFwp/MUhavSMJQz6U vmFNRjKs7grnv4H3qDmIjlnCn8cgR/aTUjMB X-Google-Smtp-Source: APBJJlHSbBEyTDxGzhHPUbxkled5UkiMIKRPes9KPJjjY8mkZP4LQu75cYlpG0U81QzHzMl8PgPuJA== X-Received: by 2002:a05:600c:2993:b0:3fb:fef9:cdcd with SMTP id r19-20020a05600c299300b003fbfef9cdcdmr4951692wmd.22.1689374100225; Fri, 14 Jul 2023 15:35:00 -0700 (PDT) Received: from localhost ([2a01:4b00:d307:1000:f1d3:eb5e:11f4:a7d9]) by smtp.gmail.com with ESMTPSA id i16-20020adffdd0000000b0030fb4b55c13sm12063689wrs.96.2023.07.14.15.34.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jul 2023 15:34:59 -0700 (PDT) From: luca.boccassi@gmail.com To: Stephen Hemminger Cc: Long Li , dpdk stable Subject: patch 'net/netvsc: fix sizeof calculation' has been queued to stable release 20.11.9 Date: Fri, 14 Jul 2023 23:34:33 +0100 Message-Id: <20230714223447.1092828-4-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230714223447.1092828-1-luca.boccassi@gmail.com> References: <20230628141046.2145871-22-luca.boccassi@gmail.com> <20230714223447.1092828-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/16/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/d94676623d26bd8370ad70ee39beac2f110dfa3f Thanks. Luca Boccassi --- >From d94676623d26bd8370ad70ee39beac2f110dfa3f Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Wed, 28 Jun 2023 17:29:57 -0700 Subject: [PATCH] net/netvsc: fix sizeof calculation [ upstream commit 86fb73f5bf401afc9d52144f27e6d1cf4f64348b ] Found by cppcheck. drivers/net/netvsc/hn_rndis.c:332:21: warning: Found calculation inside sizeof(). [sizeofCalculation] if (len < sizeof(3 * sizeof(uint32_t))) { Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device") Signed-off-by: Stephen Hemminger Signed-off-by: Long Li --- drivers/net/netvsc/hn_rndis.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/netvsc/hn_rndis.c b/drivers/net/netvsc/hn_rndis.c index 1ce260c89b..26ae7d544b 100644 --- a/drivers/net/netvsc/hn_rndis.c +++ b/drivers/net/netvsc/hn_rndis.c @@ -329,7 +329,8 @@ void hn_rndis_receive_response(struct hn_data *hv, hn_rndis_dump(data); - if (len < sizeof(3 * sizeof(uint32_t))) { + /* Check we can read first three data fields from RNDIS header */ + if (len < 3 * sizeof(uint32_t)) { PMD_DRV_LOG(ERR, "missing RNDIS header %u", len); return; -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-07-14 23:33:08.668504338 +0100 +++ 0004-net-netvsc-fix-sizeof-calculation.patch 2023-07-14 23:33:08.483305040 +0100 @@ -1 +1 @@ -From 86fb73f5bf401afc9d52144f27e6d1cf4f64348b Mon Sep 17 00:00:00 2001 +From d94676623d26bd8370ad70ee39beac2f110dfa3f Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 86fb73f5bf401afc9d52144f27e6d1cf4f64348b ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index e6f1f28768..29c6009b2c 100644 +index 1ce260c89b..26ae7d544b 100644