From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF2DE42DA6 for ; Sat, 15 Jul 2023 00:35:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E80D140EDC; Sat, 15 Jul 2023 00:35:03 +0200 (CEST) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by mails.dpdk.org (Postfix) with ESMTP id AFD1140DFB for ; Sat, 15 Jul 2023 00:35:01 +0200 (CEST) Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-3fc04692e20so23046575e9.0 for ; Fri, 14 Jul 2023 15:35:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689374101; x=1691966101; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kXft45rUKlytqPu3SMS/zOXTZO6pRj4BHg6EC+RxNiM=; b=VGkWcRuwo5luhI4/amqRdsFBLNHYXLEv+j3cTFCMYIEpRqtzko3RXDrIq+znWW/Cr2 j0OrBwnbLDHdmzuERFvan3m/yMraqaHk+jdWcINFoiKxGOqjYwMXkk196XcIh1JTRAQr 1wO4rMIL3O1RPaFa/zDklNfIjF8k3jOjn7qlIXT9uN34njyJY/ZV7BF2ymCv7iOGUIkj +OzKrqMZFX2QCjdS1OWy8e/i3UH5o8BW9ilBtOq/WTLH8AOeqF8CmJ4Z3cLhubBsJ6Eo zkZoV8W1eKicXXmDWITkaY1tpSviKsC+Kde7Q/257u6xJIzA0AHxW1X13J8LDSAbOeqZ dPqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689374101; x=1691966101; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kXft45rUKlytqPu3SMS/zOXTZO6pRj4BHg6EC+RxNiM=; b=aX574l/fv41hrjkWG7Y8PNm/P/b45yzVAW71DIgcBPZXgMDuZvipxeXlEYWJfle0Pj UF2BuDNKwaDvP5KMWGfTZ5UEGbN/mnKbWj3IRnEOBjkEBIoR7u2fD/CiZY7MXTn/XKhx rAQh+mrOWd210/KZv6aJlsFR9lxP1MYuchw1MtXJcy1Xpl2sdjgPcEbXvIEz1VBRT1tF MRqwJszXS30lA8KpWlsOqlaMRkx61W7Bpmq+JAIMSE+dfP8ARGZTzkJmL116xCpI1UL+ H/wUyBtusGvIMMgQ61DCuR+tLF4nyt2Z7IShwxzneJXfUCLPwfR4uNd8Qv8dx0DnJar+ bNdA== X-Gm-Message-State: ABy/qLbH1h/SwshAYQagcHJP08QX+xoQrNxh8LAS6Znc7KIXY4n8gIW5 axMn/8hU1ZbSfT2gtQKE7zc= X-Google-Smtp-Source: APBJJlFuII9eoGB93ONRCuypNUrTsvjZ+ORO/KpUBnOnNT7O6asLkv3W6ufnGZR/Z/Ke/+iuVbHZHA== X-Received: by 2002:a7b:cbda:0:b0:3fa:8c68:4aba with SMTP id n26-20020a7bcbda000000b003fa8c684abamr4755033wmi.25.1689374101334; Fri, 14 Jul 2023 15:35:01 -0700 (PDT) Received: from localhost ([2a01:4b00:d307:1000:f1d3:eb5e:11f4:a7d9]) by smtp.gmail.com with ESMTPSA id x11-20020a1c7c0b000000b003fbcf032c55sm2299176wmc.7.2023.07.14.15.35.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jul 2023 15:35:00 -0700 (PDT) From: luca.boccassi@gmail.com To: Shiyang He Cc: Ferruh Yigit , dpdk stable Subject: patch 'app/testpmd: fix checksum engine with GTP on 32-bit' has been queued to stable release 20.11.9 Date: Fri, 14 Jul 2023 23:34:34 +0100 Message-Id: <20230714223447.1092828-5-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230714223447.1092828-1-luca.boccassi@gmail.com> References: <20230628141046.2145871-22-luca.boccassi@gmail.com> <20230714223447.1092828-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 20.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/16/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/b92c1c45a30cef0aabc2f6e100f7d91e53223a2e Thanks. Luca Boccassi --- >From b92c1c45a30cef0aabc2f6e100f7d91e53223a2e Mon Sep 17 00:00:00 2001 From: Shiyang He Date: Thu, 29 Jun 2023 10:09:55 +0000 Subject: [PATCH] app/testpmd: fix checksum engine with GTP on 32-bit [ upstream commit f7bfa1285fe943b5189a63bb1d427e823b7fcc20 ] l2_len is not calculated correctly on 32-bit systems, resulting in packet forwarding failure. This patch fixes this issue by changing the l2_len calculation. Fixes: dd827fa42a30 ("app/testpmd: fix GTP L2 length in checksum engine") Signed-off-by: Shiyang He Acked-by: Ferruh Yigit --- app/test-pmd/csumonly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index 9b12b91ead..299a676147 100644 --- a/app/test-pmd/csumonly.c +++ b/app/test-pmd/csumonly.c @@ -246,7 +246,7 @@ parse_gtp(struct rte_udp_hdr *udp_hdr, info->l4_proto = 0; } - info->l2_len += gtp_len + sizeof(udp_hdr); + info->l2_len += gtp_len + sizeof(*udp_hdr); } /* Parse a vxlan header */ -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-07-14 23:33:08.708504076 +0100 +++ 0005-app-testpmd-fix-checksum-engine-with-GTP-on-32-bit.patch 2023-07-14 23:33:08.483305040 +0100 @@ -1 +1 @@ -From f7bfa1285fe943b5189a63bb1d427e823b7fcc20 Mon Sep 17 00:00:00 2001 +From b92c1c45a30cef0aabc2f6e100f7d91e53223a2e Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit f7bfa1285fe943b5189a63bb1d427e823b7fcc20 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 7af635e3f7..c103e54111 100644 +index 9b12b91ead..299a676147 100644 @@ -24 +25 @@ -@@ -250,7 +250,7 @@ parse_gtp(struct rte_udp_hdr *udp_hdr, +@@ -246,7 +246,7 @@ parse_gtp(struct rte_udp_hdr *udp_hdr,