From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id EC6DD42E8E
for <public@inbox.dpdk.org>; Sun, 16 Jul 2023 19:19:34 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id BA7844114A;
Sun, 16 Jul 2023 19:19:34 +0200 (CEST)
Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com
[209.85.210.179])
by mails.dpdk.org (Postfix) with ESMTP id E25694113F
for <stable@dpdk.org>; Sun, 16 Jul 2023 19:19:32 +0200 (CEST)
Received: by mail-pf1-f179.google.com with SMTP id
d2e1a72fcca58-666ed230c81so3839771b3a.0
for <stable@dpdk.org>; Sun, 16 Jul 2023 10:19:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1689527972;
x=1692119972;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:cc:to:from:date:from:to:cc:subject:date
:message-id:reply-to;
bh=mkqZdfBvxo6lQPwhLThdETQ3OyXIkZw6S/1grBeh2CU=;
b=I+kLGHxH18VMIoywjzz5L3STaE9FdeQBxzyt8mCdj8qhu4uLUj4/QdUXPNb5rZd4ZO
RrmLdoeBTkNIyfrQVJP+zpXL6fCYFhGx7eGGk2EaKih/jRVGkEu664gU1ddkpEEXX47M
5lKEtFVueYovkJHJITiQCaLx0ST34emd6FiFSeu9NnT6Dy70vLS8cs9JosqpE9iNN4pG
QR0x3n4JySjN9oh+zjcsLbJipfRjLzvMQsRkzafMvjT5eHWL4Z/BVQaWppWV50KyzsI8
5Qs1RkZY8p43uQ8TRWV8xymNrDmkc+MojfefoH/HE3s83YgV2d431eeqt42hnS7d3skL
QwAw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20221208; t=1689527972; x=1692119972;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=mkqZdfBvxo6lQPwhLThdETQ3OyXIkZw6S/1grBeh2CU=;
b=IGZUZYsIvhVMKtCBn8jodE7WbLYO/0vKgIPwdqnAxUCsysfuhC+uMqGwiL1BRT10q/
o4xRqte5ZhI0Ms4C0chERdyacFGb4c6UTocoF5WCeVi9vmZYzQrBcfsc2gHux3ZpJSAk
2GAkZLWn3pe73dzw5fOLbCPfVum9Yf3GZA2Nn5uGu33o2FTVRNZQvR7h/jneLEHCAWYE
75C70hiuWAmqRoAUibnvWCt8i4FmXF0TlK2rM9jo0F3t1TN6SVp3Yp9FyYn3+T8QjjIM
cQkt6jn5gJ5/FEqMXZA82VEGYxYC9NLJsmTB/SHSmd8GuYqBepJyRPvYyg8pOd3m+OAX
GBOw==
X-Gm-Message-State: ABy/qLYQMNjOqtWzgd1n1E0M0HCvfn9+FGG2ZcA8NSBrhmCoNa88Dp0x
gkE8GzUQ2NazlllH+LLhXu3b2A==
X-Google-Smtp-Source: APBJJlGGO9B4R+gHykYD5JPi36gUt7sthA9BzGGtafG070lZterZGhQ97GiYpbyUF8XnFfqfynIeKg==
X-Received: by 2002:a17:902:c409:b0:1b8:a65f:b49d with SMTP id
k9-20020a170902c40900b001b8a65fb49dmr13229922plk.12.1689527971728;
Sun, 16 Jul 2023 10:19:31 -0700 (PDT)
Received: from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207])
by smtp.gmail.com with ESMTPSA id
s13-20020a17090aba0d00b00263d15f0e87sm3796930pjr.42.2023.07.16.10.19.31
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 16 Jul 2023 10:19:31 -0700 (PDT)
Date: Sun, 16 Jul 2023 10:19:29 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, dev@dpdk.org,
bruce.richardson@intel.com, bluca@debian.org, olivier.matz@6wind.com,
thierry.herbelot@6wind.com, Gabriel Ganne <gabriel.ganne@6wind.com>,
stable@dpdk.org, Harry van Haaren <harry.van.haaren@intel.com>, Luca
Boccassi <luca.boccassi@gmail.com>, Keith Wiles <keith.wiles@intel.com>,
david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH v5] build: remove redundant libpcap link
Message-ID: <20230716101929.2b6a0f53@hermes.local>
In-Reply-To: <6947263.kiK9OB8DAI@thomas>
References: <20210409083927.8345-1-gabriel.ganne@6wind.com>
<3119483.LeJDoi8FaI@thomas> <20210415000245.0b1d45c1@sovereign>
<6947263.kiK9OB8DAI@thomas>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
On Wed, 14 Apr 2021 23:10:46 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:
> 14/04/2021 23:02, Dmitry Kozlyuk:
> > 2021-04-14 11:41 (UTC+0200), Thomas Monjalon:
> > > 09/04/2021 14:25, Thomas Monjalon:
> > > > From: Gabriel Ganne <gabriel.ganne@6wind.com>
> > > >
> > > > The pcap PMD and the librte_port both declare their dependency to libpcap
> > > > with a line "ext_deps += pcap_dep".
> > > > Then meson automatically adds this dependency to the pkg-config file
> > > > in the "Requires.private" section for static builds.
> > > >
> > > > The additional update of dpdk_extra_ldflags was adding the dependency
> > > > in the "Libs.private" section of the pkg-config, that is unnecessary.
> > > >
> > > > Fixes: efd5d1a8d8dd ("drivers/net: build some vdev PMDs with meson")
> > > > Fixes: 268fa581b1ff ("port: fix pcap support with meson")
> > > > Cc: stable@dpdk.org
> > > >
> > > > Signed-off-by: Gabriel Ganne <gabriel.ganne@6wind.com>
> > > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > > > ---
> > > > I have a doubt whether this option is really always useless.
> > > > In the case of an old pcap (<1.9) without pkg-config support,
> > > > and with the minimum meson supported (0.47.1),
> > > > are we sure the generated pkg-config file will include -lpcap?
> > >
> > > Any volunteer to test please?
> >
> > Ubuntu 16.04, Meson 0.47.1, libpcap 1.7.4-2ubuntu0.1, after the patch
> > libdpdk.pc contains:
> >
> > Libs.private: -lpcap -lpcap -lpcap -lpcap -lpcap -lpcap -lpcap -lpcap
> > -lpcap -lpcap [...DPDK libraries...]
> >
> > Note that -lpcap comes _before_ DPDK libraries that require it.
> > As a consequence, this doesn't link with unresolved libpcap symbols:
> >
> > gcc test.c `pkg-config --static --cflags --libs libdpdk`
> >
> > Before the patch -lpcap was _after_ DPDK libraries,
> > link succeeded (there was also _one_ -lpcap before DPDK libraries).
> >
> > Meson 0.55.1 places -lpcap _after_ DPDK libraries,
> > link succeeds both before and after the patch.
> >
> > Conclusion: this patch really breaks .pc file for older meson.
>
> Thanks for the test.
> I propose to defer this patch.
> It could be merged when we upgrade meson requirement.
Current documented meson requirement is:
Version 0.53.2 or later of meson is required
So this patch should be considered.