From: luca.boccassi@gmail.com
To: Jieqiang Wang <jieqiang.wang@arm.com>
Cc: Ruifeng Wang <ruifeng.wang@arm.com>, dpdk stable <stable@dpdk.org>
Subject: patch 'net/i40e: fix comments' has been queued to stable release 20.11.9
Date: Thu, 20 Jul 2023 11:58:51 +0100 [thread overview]
Message-ID: <20230720105859.2537307-2-luca.boccassi@gmail.com> (raw)
In-Reply-To: <20230720105859.2537307-1-luca.boccassi@gmail.com>
Hi,
FYI, your patch has been queued to stable release 20.11.9
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/22/23. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/64157a7dac4f3d628e5c1554b9ae049d81216367
Thanks.
Luca Boccassi
---
From 64157a7dac4f3d628e5c1554b9ae049d81216367 Mon Sep 17 00:00:00 2001
From: Jieqiang Wang <jieqiang.wang@arm.com>
Date: Wed, 12 Jul 2023 18:07:32 +0800
Subject: [PATCH] net/i40e: fix comments
[ upstream commit 5267a2ae78e873d3a7e175944dcedffdadab6483 ]
The limitation of burst size in i40e vector rx has been removed, but the
comment lines have not been updated to reflect the code changes. Remove
those lines to avoid confusion. Additionally, fix a typo in
i40e_tx_queue.
Fixes: 9e27f00f3a61 ("net/i40e: fix vector Rx")
Signed-off-by: Jieqiang Wang <jieqiang.wang@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
drivers/net/i40e/i40e_rxtx.h | 2 +-
drivers/net/i40e/i40e_rxtx_vec_altivec.c | 2 --
drivers/net/i40e/i40e_rxtx_vec_neon.c | 2 --
drivers/net/i40e/i40e_rxtx_vec_sse.c | 2 --
4 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/net/i40e/i40e_rxtx.h b/drivers/net/i40e/i40e_rxtx.h
index 2786bdcff9..01ba91cdec 100644
--- a/drivers/net/i40e/i40e_rxtx.h
+++ b/drivers/net/i40e/i40e_rxtx.h
@@ -165,7 +165,7 @@ struct i40e_tx_queue {
bool q_set; /**< indicate if tx queue has been configured */
bool tx_deferred_start; /**< don't start this queue in dev start */
uint8_t dcb_tc; /**< Traffic class of tx queue */
- uint64_t offloads; /**< Tx offload flags of DEV_RX_OFFLOAD_* */
+ uint64_t offloads; /**< Tx offload flags of DEV_TX_OFFLOAD_* */
const struct rte_memzone *mz;
};
diff --git a/drivers/net/i40e/i40e_rxtx_vec_altivec.c b/drivers/net/i40e/i40e_rxtx_vec_altivec.c
index b24f3963f4..4816959178 100644
--- a/drivers/net/i40e/i40e_rxtx_vec_altivec.c
+++ b/drivers/net/i40e/i40e_rxtx_vec_altivec.c
@@ -448,8 +448,6 @@ _recv_raw_pkts_vec(struct i40e_rx_queue *rxq, struct rte_mbuf **rx_pkts,
/* Notice:
* - nb_pkts < RTE_I40E_DESCS_PER_LOOP, just return no packet
- * - nb_pkts > RTE_I40E_VPMD_RX_BURST, only scan RTE_I40E_VPMD_RX_BURST
- * numbers of DD bits
*/
uint16_t
i40e_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,
diff --git a/drivers/net/i40e/i40e_rxtx_vec_neon.c b/drivers/net/i40e/i40e_rxtx_vec_neon.c
index 28bf046e88..f828937e00 100644
--- a/drivers/net/i40e/i40e_rxtx_vec_neon.c
+++ b/drivers/net/i40e/i40e_rxtx_vec_neon.c
@@ -447,8 +447,6 @@ _recv_raw_pkts_vec(struct i40e_rx_queue *__rte_restrict rxq,
/*
* Notice:
* - nb_pkts < RTE_I40E_DESCS_PER_LOOP, just return no packet
- * - nb_pkts > RTE_I40E_VPMD_RX_BURST, only scan RTE_I40E_VPMD_RX_BURST
- * numbers of DD bits
*/
uint16_t
i40e_recv_pkts_vec(void *__rte_restrict rx_queue,
diff --git a/drivers/net/i40e/i40e_rxtx_vec_sse.c b/drivers/net/i40e/i40e_rxtx_vec_sse.c
index a8aa5bc0cc..1478f994c9 100644
--- a/drivers/net/i40e/i40e_rxtx_vec_sse.c
+++ b/drivers/net/i40e/i40e_rxtx_vec_sse.c
@@ -595,8 +595,6 @@ _recv_raw_pkts_vec(struct i40e_rx_queue *rxq, struct rte_mbuf **rx_pkts,
/*
* Notice:
* - nb_pkts < RTE_I40E_DESCS_PER_LOOP, just return no packet
- * - nb_pkts > RTE_I40E_VPMD_RX_BURST, only scan RTE_I40E_VPMD_RX_BURST
- * numbers of DD bits
*/
uint16_t
i40e_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,
--
2.39.2
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2023-07-20 11:54:24.326440927 +0100
+++ 0002-net-i40e-fix-comments.patch 2023-07-20 11:54:24.225504368 +0100
@@ -1 +1 @@
-From 5267a2ae78e873d3a7e175944dcedffdadab6483 Mon Sep 17 00:00:00 2001
+From 64157a7dac4f3d628e5c1554b9ae049d81216367 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 5267a2ae78e873d3a7e175944dcedffdadab6483 ]
+
@@ -12 +13,0 @@
-Cc: stable@dpdk.org
@@ -17 +17,0 @@
- .mailmap | 1 +
@@ -22 +22 @@
- 5 files changed, 2 insertions(+), 7 deletions(-)
+ 4 files changed, 1 insertion(+), 7 deletions(-)
@@ -24,12 +23,0 @@
-diff --git a/.mailmap b/.mailmap
-index 6eccf0c555..670d312f84 100644
---- a/.mailmap
-+++ b/.mailmap
-@@ -628,6 +628,7 @@ Jie Liu <jie2.liu@hxt-semitech.com>
- Jie Pan <panjie5@jd.com>
- Jie Wang <jie1x.wang@intel.com>
- Jie Zhou <jizh@linux.microsoft.com> <jizh@microsoft.com>
-+Jieqiang Wang <jieqiang.wang@arm.com>
- Jijiang Liu <jijiang.liu@intel.com>
- Jilei Chen <chenjilei@cmss.chinamobile.com>
- Jim Harris <james.r.harris@intel.com>
@@ -37 +25 @@
-index 0376c219be..a8686224e5 100644
+index 2786bdcff9..01ba91cdec 100644
@@ -40 +28 @@
-@@ -169,7 +169,7 @@ struct i40e_tx_queue {
+@@ -165,7 +165,7 @@ struct i40e_tx_queue {
@@ -44,2 +32,2 @@
-- uint64_t offloads; /**< Tx offload flags of RTE_ETH_RX_OFFLOAD_* */
-+ uint64_t offloads; /**< Tx offload flags of RTE_ETH_TX_OFFLOAD_* */
+- uint64_t offloads; /**< Tx offload flags of DEV_RX_OFFLOAD_* */
++ uint64_t offloads; /**< Tx offload flags of DEV_TX_OFFLOAD_* */
@@ -50 +38 @@
-index 8672ad1c41..4cd78f4e58 100644
+index b24f3963f4..4816959178 100644
@@ -53 +41 @@
-@@ -449,8 +449,6 @@ _recv_raw_pkts_vec(struct i40e_rx_queue *rxq, struct rte_mbuf **rx_pkts,
+@@ -448,8 +448,6 @@ _recv_raw_pkts_vec(struct i40e_rx_queue *rxq, struct rte_mbuf **rx_pkts,
@@ -63 +51 @@
-index 49391fe4c7..d873e30972 100644
+index 28bf046e88..f828937e00 100644
@@ -66 +54 @@
-@@ -574,8 +574,6 @@ _recv_raw_pkts_vec(struct i40e_rx_queue *__rte_restrict rxq,
+@@ -447,8 +447,6 @@ _recv_raw_pkts_vec(struct i40e_rx_queue *__rte_restrict rxq,
@@ -76 +64 @@
-index baf83cb3df..b94c37cbb8 100644
+index a8aa5bc0cc..1478f994c9 100644
@@ -79 +67 @@
-@@ -596,8 +596,6 @@ _recv_raw_pkts_vec(struct i40e_rx_queue *rxq, struct rte_mbuf **rx_pkts,
+@@ -595,8 +595,6 @@ _recv_raw_pkts_vec(struct i40e_rx_queue *rxq, struct rte_mbuf **rx_pkts,
next prev parent reply other threads:[~2023-07-20 10:59 UTC|newest]
Thread overview: 113+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 1:31 patch 'kni: fix build with Linux 6.3' " luca.boccassi
2023-06-15 1:31 ` patch 'examples/ip_pipeline: fix build with GCC 13' " luca.boccassi
2023-06-15 1:31 ` patch 'examples/ntb: " luca.boccassi
2023-06-15 1:31 ` patch 'ring: fix use after free' " luca.boccassi
2023-06-15 1:32 ` patch 'vfio: fix include with musl runtime' " luca.boccassi
2023-06-15 1:32 ` patch 'kernel/freebsd: fix function parameter list' " luca.boccassi
2023-06-15 1:32 ` patch 'build: fix case of project language name' " luca.boccassi
2023-06-15 1:32 ` patch 'telemetry: fix autotest on Alpine' " luca.boccassi
2023-06-15 1:32 ` patch 'test/malloc: fix missing free' " luca.boccassi
2023-06-15 1:32 ` patch 'test/malloc: fix statistics checks' " luca.boccassi
2023-06-15 1:32 ` patch 'eal: avoid calling cleanup twice' " luca.boccassi
2023-06-15 1:32 ` patch 'pci: fix comment referencing renamed function' " luca.boccassi
2023-06-15 1:32 ` patch 'eal/x86: improve multiple of 64 bytes memcpy performance' " luca.boccassi
2023-06-15 1:32 ` patch 'eventdev/timer: fix timeout event wait behavior' " luca.boccassi
2023-06-15 1:32 ` patch 'doc: fix event timer adapter guide' " luca.boccassi
2023-06-15 1:32 ` patch 'event/dsw: free rings on close' " luca.boccassi
2023-06-15 1:32 ` patch 'eventdev/timer: fix buffer flush' " luca.boccassi
2023-06-15 1:32 ` patch 'eal/linux: fix secondary process crash for mp hotplug' " luca.boccassi
2023-06-15 1:32 ` patch 'eal/linux: fix legacy mem init with many segments' " luca.boccassi
2023-06-15 1:32 ` patch 'net/hns3: fix build warning' " luca.boccassi
2023-06-15 1:32 ` patch 'net/tap: set locally administered bit for fixed MAC address' " luca.boccassi
2023-06-15 1:32 ` patch 'net/dpaa2: fix checksum good flags' " luca.boccassi
2023-06-15 1:32 ` patch 'app/testpmd: fix GTP L2 length in checksum engine' " luca.boccassi
2023-06-15 1:32 ` patch 'net/vmxnet3: fix drop of empty segments in Tx' " luca.boccassi
2023-06-15 1:32 ` patch 'net/txgbe: fix use-after-free on remove' " luca.boccassi
2023-06-15 1:32 ` patch 'ethdev: fix MAC address occupies two entries' " luca.boccassi
2023-06-15 1:32 ` patch 'net/hns3: fix variable type mismatch' " luca.boccassi
2023-06-15 1:32 ` patch 'net/hns3: fix Rx multiple firmware reset interrupts' " luca.boccassi
2023-06-15 1:32 ` patch 'net/hns3: fix FEC mode for 200G ports' " luca.boccassi
2023-06-15 1:32 ` patch 'net/hns3: fix FEC mode check' " luca.boccassi
2023-06-15 1:32 ` patch 'doc: fix format in flow API guide' " luca.boccassi
2023-06-15 1:32 ` patch 'net/hns3: fix mbuf leakage when RxQ started during reset' " luca.boccassi
2023-06-15 1:32 ` patch 'net/hns3: fix mbuf leakage when RxQ started after " luca.boccassi
2023-06-15 1:32 ` patch 'net/hns3: fix device start return value' " luca.boccassi
2023-06-15 1:32 ` patch 'net/hns3: fix uninitialized variable' " luca.boccassi
2023-06-15 1:32 ` patch 'net/hns3: fix inaccurate log' " luca.boccassi
2023-06-15 1:32 ` patch 'net/hns3: fix redundant line break in " luca.boccassi
2023-06-15 1:32 ` patch 'net/hns3: fix IMP reset trigger' " luca.boccassi
2023-06-15 1:32 ` patch 'net/nfp: fix offloading flows' " luca.boccassi
2023-06-15 1:32 ` patch 'net/vmxnet3: fix return code in initializing' " luca.boccassi
2023-06-15 1:32 ` patch 'doc: fix auth algos in cryptoperf app' " luca.boccassi
2023-06-15 1:32 ` patch 'crypto/scheduler: fix last element for valid args' " luca.boccassi
2023-06-15 1:32 ` patch 'test/crypto: fix session creation check' " luca.boccassi
2023-06-15 1:32 ` patch 'vhost: fix invalid call FD handling' " luca.boccassi
2023-06-15 1:32 ` patch 'net/virtio: fix initialization to return negative errno' " luca.boccassi
2023-06-15 1:32 ` patch 'net/virtio-user: fix leak when initialisation fails' " luca.boccassi
2023-06-15 1:32 ` patch 'net/mlx5: enhance error log for tunnel offloading' " luca.boccassi
2023-06-15 1:32 ` patch 'net/mlx5: fix duplicated tag index matching in SWS' " luca.boccassi
2023-06-15 1:32 ` patch 'net/qede: fix RSS indirection table initialization' " luca.boccassi
2023-06-15 1:32 ` patch 'doc: fix typo in cnxk platform guide' " luca.boccassi
2023-06-15 1:32 ` patch 'net/i40e: fix Rx data buffer size' " luca.boccassi
2023-06-15 1:32 ` patch 'net/ice: " luca.boccassi
2023-06-15 1:32 ` patch 'net/iavf: " luca.boccassi
2023-06-15 1:32 ` patch 'net/ice: fix statistics' " luca.boccassi
2023-06-15 1:32 ` patch 'net/ice: fix DCF RSS initialization' " luca.boccassi
2023-06-15 1:32 ` patch 'net/iavf: release large VF when closing device' " luca.boccassi
2023-06-15 1:32 ` patch 'net/ice: fix DCF control thread crash' " luca.boccassi
2023-06-15 1:32 ` patch 'net/ice/base: remove unreachable code' " luca.boccassi
2023-06-15 1:32 ` patch 'net/ice: fix outer UDP checksum offload' " luca.boccassi
2023-06-15 1:32 ` patch 'net/iavf: fix virtchnl command called in interrupt' " luca.boccassi
2023-06-15 1:32 ` patch 'test/mbuf: fix crash in a forked process' " luca.boccassi
2023-06-15 1:32 ` patch 'doc: fix typo in graph guide' " luca.boccassi
2023-06-15 1:32 ` patch 'doc: remove warning with Doxygen 1.9.7' " luca.boccassi
2023-06-28 14:10 ` patch 'examples/l2fwd-cat: fix external build' " luca.boccassi
2023-06-28 14:10 ` patch 'test: add graph tests' " luca.boccassi
2023-06-28 14:55 ` David Marchand
2023-06-28 14:10 ` patch 'mbuf: fix Doxygen comment of distributor metadata' " luca.boccassi
2023-06-28 14:10 ` patch 'crypto/openssl: skip workaround at compilation time' " luca.boccassi
2023-06-28 14:10 ` patch 'ethdev: update documentation for API to set FEC' " luca.boccassi
2023-06-28 14:10 ` patch 'ethdev: check that at least one FEC mode is specified' " luca.boccassi
2023-06-28 14:10 ` patch 'ethdev: update documentation for API to get FEC' " luca.boccassi
2023-06-28 14:10 ` patch 'net/bonding: fix startup when NUMA is not supported' " luca.boccassi
2023-06-28 14:10 ` patch 'net/bonding: fix destroy dedicated queues flow' " luca.boccassi
2023-06-28 14:10 ` patch 'net/txgbe/base: fix Tx with fiber hotplug' " luca.boccassi
2023-06-28 14:10 ` patch 'net/txgbe: fix to set autoneg for 1G speed' " luca.boccassi
2023-06-28 14:10 ` patch 'net/txgbe: fix extended statistics' " luca.boccassi
2023-06-28 14:10 ` patch 'net/nfp: fix address always related with PF ID 0' " luca.boccassi
2023-06-28 14:10 ` patch 'common/sfc_efx/base: fix Rx queue without RSS hash prefix' " luca.boccassi
2023-06-28 14:10 ` patch 'net/ice: fix tunnel packet Tx descriptor' " luca.boccassi
2023-06-28 14:10 ` patch 'net/ixgbe: add proper memory barriers in Rx' " luca.boccassi
2023-06-28 14:10 ` patch 'net/iavf: fix abnormal disable HW interrupt' " luca.boccassi
2023-06-28 14:10 ` patch 'net/i40e: fix tunnel packet Tx descriptor' " luca.boccassi
2023-06-28 14:10 ` patch 'net/e1000: fix queue number initialization' " luca.boccassi
2023-06-28 14:10 ` patch 'net/mlx5: fix risk in NEON Rx descriptor read' " luca.boccassi
2023-06-28 14:10 ` patch 'net/mlx5: fix device removal event handling' " luca.boccassi
2023-06-28 14:10 ` patch 'common/mlx5: adjust fork call with new kernel API' " luca.boccassi
2023-07-14 22:34 ` patch 'ipc: fix file descriptor leakage with unhandled messages' " luca.boccassi
2023-07-14 22:34 ` patch 'fib: fix adding default route' " luca.boccassi
2023-07-14 22:34 ` patch 'mem: fix memsegs exhausted message' " luca.boccassi
2023-07-14 22:34 ` patch 'net/netvsc: fix sizeof calculation' " luca.boccassi
2023-07-14 22:34 ` patch 'app/testpmd: fix checksum engine with GTP on 32-bit' " luca.boccassi
2023-07-14 22:34 ` patch 'net/hns3: fix non-zero weight for disabled TC' " luca.boccassi
2023-07-14 22:34 ` patch 'net/hns3: fix index to look up table in NEON Rx' " luca.boccassi
2023-07-14 22:34 ` patch 'ethdev: fix potential leak in PCI probing helper' " luca.boccassi
2023-07-14 22:34 ` patch 'net/mlx5: forbid MPRQ restart' " luca.boccassi
2023-07-14 22:34 ` patch 'net/ice: fix 32-bit build' " luca.boccassi
2023-07-14 22:34 ` patch 'net/ice: fix RSS hash key generation' " luca.boccassi
2023-07-14 22:34 ` patch 'baseband/fpga_5gnr_fec: fix possible division by zero' " luca.boccassi
2023-07-14 22:34 ` patch 'baseband/fpga_5gnr_fec: fix starting unconfigured queue' " luca.boccassi
2023-07-14 22:34 ` patch 'test/crypto: fix PDCP-SDAP test vectors' " luca.boccassi
2023-07-14 22:34 ` patch 'examples/fips_validation: fix digest length in AES-GCM' " luca.boccassi
2023-07-14 22:34 ` patch 'app/crypto-perf: fix socket ID default value' " luca.boccassi
2023-07-14 22:34 ` patch 'examples/ipsec-secgw: fix TAP default MAC address' " luca.boccassi
2023-07-14 22:34 ` patch 'kni: fix build with Linux 6.5' " luca.boccassi
2023-07-20 10:58 ` patch 'doc: fix typos and wording in flow API guide' " luca.boccassi
2023-07-20 10:58 ` luca.boccassi [this message]
2023-07-20 10:58 ` patch 'net/iavf: fix stop ordering' " luca.boccassi
2023-07-20 10:58 ` patch 'common/iavf: fix MAC type for 710 NIC' " luca.boccassi
2023-07-20 10:58 ` patch 'net/ixgbe: fix Rx and Tx queue status' " luca.boccassi
2023-07-20 10:58 ` patch 'net/igc: " luca.boccassi
2023-07-20 10:58 ` patch 'net/e1000: " luca.boccassi
2023-07-20 10:58 ` patch 'net/mlx5: fix LRO TCP checksum' " luca.boccassi
2023-07-20 10:58 ` patch 'doc: update BIOS settings and supported HW for NTB' " luca.boccassi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230720105859.2537307-2-luca.boccassi@gmail.com \
--to=luca.boccassi@gmail.com \
--cc=jieqiang.wang@arm.com \
--cc=ruifeng.wang@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).