From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C9B0342ECF for ; Thu, 20 Jul 2023 17:30:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C5F59427EE; Thu, 20 Jul 2023 17:30:50 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 9ECD3400D6 for ; Thu, 20 Jul 2023 17:30:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689867049; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k7ppcV4Cgv5i3beEbqYNeIdHwUQdNt9nj9WaRtYHmA4=; b=IEkLdaDTkU9CEfhesWoXODqij7Wo6bEoHnnWqKVAWUOIsUWR7v094UqJ9Ph76/3TNIrZwJ nA7Rq5NPaIU8kbehq0eVfCUw2cPCzDrZde7WMecoTKFyUgiSOxZtaLu65rpoyJYhs3SadY wOpX2f0P8w0Bz7v8YEmbKTg1j1h7v20= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-352-v-KmSGOZOf6XIfWipzhbow-1; Thu, 20 Jul 2023 11:23:05 -0400 X-MC-Unique: v-KmSGOZOf6XIfWipzhbow-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 744B9936D4D; Thu, 20 Jul 2023 15:22:42 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id AA25D492C13; Thu, 20 Jul 2023 15:22:41 +0000 (UTC) From: Kevin Traynor To: Erez Ferber Cc: Viacheslav Ovsiienko , dpdk stable Subject: patch 'common/mlx5: adjust fork call with new kernel API' has been queued to stable release 21.11.5 Date: Thu, 20 Jul 2023 16:18:58 +0100 Message-ID: <20230720151942.262154-107-ktraynor@redhat.com> In-Reply-To: <20230720151942.262154-1-ktraynor@redhat.com> References: <20230720151942.262154-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/25/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/36b2f4918f8a6bf02efbc33737604591d97e8a0e Thanks. Kevin --- >From 36b2f4918f8a6bf02efbc33737604591d97e8a0e Mon Sep 17 00:00:00 2001 From: Erez Ferber Date: Wed, 24 May 2023 15:01:40 +0300 Subject: [PATCH] common/mlx5: adjust fork call with new kernel API [ upstream commit 42f113c53cbbbc4585ad68b4d2a8aa9bddad23da ] While doing process fork() the operating system remaps all the parent process's memory to the address space of the child process and activates the Copy-on-Write mechanics - it duplicates physical pages once memory writing happens in the child process. Sometimes memory duplication is not allowed - for example, if the page contains hardware queue descriptors. To handle similar issues the rdma-core library should be prepared for forking. The ibv_fork_init() prepares the library to track all the related memory and prevent it from forking using madvise() system API. This approach allows fork, but not all the memory is forked to the child process and, application should care not to touch pages where the parent application allocated the rdma-core objects. The newer kernels propose an option of copy-on-fork for DMA pages and tracking all the memory and disabling it for the forking is no longer needed. The new API routine ibv_is_fork_initialized() should be involved to decide if library initialization for forking is required. Fixes: 0e83b8e536c1 ("net/mlx5: move rdma-core calls to separate file") Signed-off-by: Erez Ferber Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/linux/meson.build | 2 ++ drivers/common/mlx5/linux/mlx5_glue.c | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/drivers/common/mlx5/linux/meson.build b/drivers/common/mlx5/linux/meson.build index 4c7b53b9bd..8be82850ba 100644 --- a/drivers/common/mlx5/linux/meson.build +++ b/drivers/common/mlx5/linux/meson.build @@ -203,4 +203,6 @@ has_sym_args = [ [ 'HAVE_MLX5_IBV_REG_MR_IOVA', 'infiniband/verbs.h', 'ibv_reg_mr_iova' ], + [ 'HAVE_IBV_FORK_UNNEEDED', 'infiniband/verbs.h', + 'ibv_is_fork_initialized'], ] config = configuration_data() diff --git a/drivers/common/mlx5/linux/mlx5_glue.c b/drivers/common/mlx5/linux/mlx5_glue.c index bc6622053f..e29b3b8eae 100644 --- a/drivers/common/mlx5/linux/mlx5_glue.c +++ b/drivers/common/mlx5/linux/mlx5_glue.c @@ -20,4 +20,8 @@ static int mlx5_glue_fork_init(void) { +#ifdef HAVE_IBV_FORK_UNNEEDED + if (ibv_is_fork_initialized() == IBV_FORK_UNNEEDED) + return 0; /* ibv_fork_init() not needed */ +#endif return ibv_fork_init(); } -- 2.41.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-07-20 16:18:08.070225191 +0100 +++ 0107-common-mlx5-adjust-fork-call-with-new-kernel-API.patch 2023-07-20 16:17:55.083752231 +0100 @@ -1 +1 @@ -From 42f113c53cbbbc4585ad68b4d2a8aa9bddad23da Mon Sep 17 00:00:00 2001 +From 36b2f4918f8a6bf02efbc33737604591d97e8a0e Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 42f113c53cbbbc4585ad68b4d2a8aa9bddad23da ] + @@ -26 +27,0 @@ -Cc: stable@dpdk.org @@ -36 +37 @@ -index 718da020f7..15edc13041 100644 +index 4c7b53b9bd..8be82850ba 100644 @@ -39,3 +40,3 @@ -@@ -222,4 +222,6 @@ has_sym_args = [ - [ 'HAVE_MLX5DV_CREATE_STEERING_ANCHOR', 'infiniband/mlx5dv.h', - 'mlx5dv_create_steering_anchor'], +@@ -203,4 +203,6 @@ has_sym_args = [ + [ 'HAVE_MLX5_IBV_REG_MR_IOVA', 'infiniband/verbs.h', + 'ibv_reg_mr_iova' ], @@ -45 +46 @@ - if libmtcr_ul_found + config = configuration_data() @@ -47 +48 @@ -index 3497aa940d..6f858db8fc 100644 +index bc6622053f..e29b3b8eae 100644