From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3986B42ECF for ; Thu, 20 Jul 2023 17:30:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 35E2540685; Thu, 20 Jul 2023 17:30:11 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D7057400D6 for ; Thu, 20 Jul 2023 17:30:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689867009; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3FNTcDMIbgcjkTju/0LPbKzfN7nfprR3PiN2D2ydS3s=; b=SAEu6fhvSTdlgVyPC90vcAZHMexlQkufMwl5dk56yJmFSfw8ddyas3oiut1pJTUqs5AFhb R2EcVtNl8/ZERv1fX4Zih++CTq7KGeHFkK2lshjt6Mgf0S3YXUysjlzfdcso9YgkLyMQfl o9I2OIDzwjQlPS0a3DLGXvVUj2d8rrc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-631-8MNQByhsM-a7kC82GOLHpA-1; Thu, 20 Jul 2023 11:23:26 -0400 X-MC-Unique: 8MNQByhsM-a7kC82GOLHpA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1BF01104D520; Thu, 20 Jul 2023 15:23:03 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id 143614CD0E1; Thu, 20 Jul 2023 15:23:01 +0000 (UTC) From: Kevin Traynor To: Huisong Li Cc: Dongdong Liu , dpdk stable Subject: patch 'net/hns3: fix non-zero weight for disabled TC' has been queued to stable release 21.11.5 Date: Thu, 20 Jul 2023 16:19:13 +0100 Message-ID: <20230720151942.262154-122-ktraynor@redhat.com> In-Reply-To: <20230720151942.262154-1-ktraynor@redhat.com> References: <20230720151942.262154-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/25/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/befee9ffcf7900c17828c71673ee65115f3087b9 Thanks. Kevin --- >From befee9ffcf7900c17828c71673ee65115f3087b9 Mon Sep 17 00:00:00 2001 From: Huisong Li Date: Fri, 7 Jul 2023 18:40:53 +0800 Subject: [PATCH] net/hns3: fix non-zero weight for disabled TC [ upstream commit 1abcdb3f247393a04703071452b560a77ab23c04 ] hns3 PF driver enables one TC, allocates to 100% weight for this TC and 0% for other disabled TC by default. But driver modifies the weight to 1% for disabled TC and then set to hardware to make all TC work in DWRR mode. As a result, the total percent of all TC is more than 100%. Actually, this operation is also redundant, because these disabled TC will never be used. So this patch sets the weight of all TC based on user's configuration. Fixes: 62e3ccc2b94c ("net/hns3: support flow control") Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_dcb.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/net/hns3/hns3_dcb.c b/drivers/net/hns3/hns3_dcb.c index e4417e87fd..0360dc3862 100644 --- a/drivers/net/hns3/hns3_dcb.c +++ b/drivers/net/hns3/hns3_dcb.c @@ -238,7 +238,7 @@ static int hns3_dcb_ets_tc_dwrr_cfg(struct hns3_hw *hw) { -#define DEFAULT_TC_WEIGHT 1 #define DEFAULT_TC_OFFSET 14 struct hns3_ets_tc_weight_cmd *ets_weight; + struct hns3_pg_info *pg_info; struct hns3_cmd_desc desc; uint8_t i; @@ -248,11 +248,4 @@ hns3_dcb_ets_tc_dwrr_cfg(struct hns3_hw *hw) for (i = 0; i < HNS3_MAX_TC_NUM; i++) { - struct hns3_pg_info *pg_info; - - ets_weight->tc_weight[i] = DEFAULT_TC_WEIGHT; - - if (!(hw->hw_tc_map & BIT(i))) - continue; - pg_info = &hw->dcb_info.pg_info[hw->dcb_info.tc_info[i].pgid]; ets_weight->tc_weight[i] = pg_info->tc_dwrr[i]; -- 2.41.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-07-20 16:18:09.676130318 +0100 +++ 0122-net-hns3-fix-non-zero-weight-for-disabled-TC.patch 2023-07-20 16:17:55.127752411 +0100 @@ -1 +1 @@ -From 1abcdb3f247393a04703071452b560a77ab23c04 Mon Sep 17 00:00:00 2001 +From befee9ffcf7900c17828c71673ee65115f3087b9 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 1abcdb3f247393a04703071452b560a77ab23c04 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index af045b22f7..07b8c46a81 100644 +index e4417e87fd..0360dc3862 100644