From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE29842ECF for ; Thu, 20 Jul 2023 17:29:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DDACB40685; Thu, 20 Jul 2023 17:29:59 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 1E3B242C4D for ; Thu, 20 Jul 2023 17:29:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689866997; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q4qJHV5o3mZp2+yfTAwaf5XDJOS0kHIIbCgEBucseic=; b=LEXeeWAkARK7fkBPtNuifdPznSzwWreQc4pPTPCIA6hXSF+C6wj4RZe7eiGNK4wqV2BWYm VnVsaZR7786AujaLutf7leZgqMou4gvvSwD0lkF0sJzZyELG14z8STSKfp8KaM7jYFNX6W eNEbwVSIW66YvOtyFDDKsCnPmP4RDSA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-79-0NE7DXM5PJSRPCeFBS9n1Q-1; Thu, 20 Jul 2023 11:20:51 -0400 X-MC-Unique: 0NE7DXM5PJSRPCeFBS9n1Q-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B2AB584818F; Thu, 20 Jul 2023 15:20:20 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id EF1F3492C13; Thu, 20 Jul 2023 15:20:19 +0000 (UTC) From: Kevin Traynor To: Erik Gabriel Carrillo Cc: dpdk stable Subject: patch 'eventdev/timer: fix buffer flush' has been queued to stable release 21.11.5 Date: Thu, 20 Jul 2023 16:17:29 +0100 Message-ID: <20230720151942.262154-18-ktraynor@redhat.com> In-Reply-To: <20230720151942.262154-1-ktraynor@redhat.com> References: <20230720151942.262154-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/25/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/44a0ae78404d1d1130a2b4cab1a8cdf667b1ce0e Thanks. Kevin --- >From 44a0ae78404d1d1130a2b4cab1a8cdf667b1ce0e Mon Sep 17 00:00:00 2001 From: Erik Gabriel Carrillo Date: Wed, 12 Apr 2023 14:56:37 -0500 Subject: [PATCH] eventdev/timer: fix buffer flush [ upstream commit 53b97347cc84e8df53426c7917a4b65296264c02 ] The SW event timer adapter attempts to flush its event buffer on every adapter tick. If events remain in the buffer after the attempt, another attempt to flush won't occur until the next adapter tick, which delays the enqueue of those events to the event device unnecessarily. Move the buffer flush call so that it happens with every invocation of the service function, rather than on every adapter tick, to avoid the delay. Fixes: cc7b73ea9e3b ("eventdev: add new software timer adapter") Signed-off-by: Erik Gabriel Carrillo --- lib/eventdev/rte_event_timer_adapter.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/lib/eventdev/rte_event_timer_adapter.c b/lib/eventdev/rte_event_timer_adapter.c index 5fad079be2..5e7d101470 100644 --- a/lib/eventdev/rte_event_timer_adapter.c +++ b/lib/eventdev/rte_event_timer_adapter.c @@ -798,15 +798,16 @@ swtim_service_func(void *arg) sw->n_expired_timers = 0; - event_buffer_flush(&sw->buffer, - adapter->data->event_dev_id, - adapter->data->event_port_id, - &nb_evs_flushed, - &nb_evs_invalid); - - sw->stats.ev_enq_count += nb_evs_flushed; - sw->stats.ev_inv_count += nb_evs_invalid; sw->stats.adapter_tick_count++; } + event_buffer_flush(&sw->buffer, + adapter->data->event_dev_id, + adapter->data->event_port_id, + &nb_evs_flushed, + &nb_evs_invalid); + + sw->stats.ev_enq_count += nb_evs_flushed; + sw->stats.ev_inv_count += nb_evs_invalid; + rte_event_maintain(adapter->data->event_dev_id, adapter->data->event_port_id, 0); -- 2.41.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-07-20 16:17:57.376889952 +0100 +++ 0018-eventdev-timer-fix-buffer-flush.patch 2023-07-20 16:17:54.465749707 +0100 @@ -1 +1 @@ -From 53b97347cc84e8df53426c7917a4b65296264c02 Mon Sep 17 00:00:00 2001 +From 44a0ae78404d1d1130a2b4cab1a8cdf667b1ce0e Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 53b97347cc84e8df53426c7917a4b65296264c02 ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index 23eb1d4a7d..427c4c6287 100644 +index 5fad079be2..5e7d101470 100644 @@ -27 +28 @@ -@@ -856,15 +856,16 @@ swtim_service_func(void *arg) +@@ -798,15 +798,16 @@ swtim_service_func(void *arg)