From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C968542ECF for ; Thu, 20 Jul 2023 17:34:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C59C540685; Thu, 20 Jul 2023 17:34:11 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 891D5400D6 for ; Thu, 20 Jul 2023 17:34:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689867250; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hCmjlmM8lIvQkVSOXrs2VvbUlvTvsfoxmhO5ryek6Bk=; b=RViL+QbThAgvgNzOTWdSgoaC2FkdWfcdowMJY19NdLvxpQTa27tMAzg98ntNh6yLdRs3GH AagZNDhJpjpTUDSfvK7XDNnJdDzf+FyldJvJABW0aPZENfip5x9xqhU8aQ9HZcRQKDIm8+ GoBJ3z8wBpkFyifKNjTmSw9aLUR+UQU= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-30-eq1FlfqAPhClIg2Xdw0nhA-1; Thu, 20 Jul 2023 11:22:04 -0400 X-MC-Unique: eq1FlfqAPhClIg2Xdw0nhA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CB5581C09A4C; Thu, 20 Jul 2023 15:21:12 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id A84AB492C13; Thu, 20 Jul 2023 15:21:11 +0000 (UTC) From: Kevin Traynor To: Ciara Power Cc: Kai Ji , dpdk stable Subject: patch 'crypto/scheduler: fix last element for valid args' has been queued to stable release 21.11.5 Date: Thu, 20 Jul 2023 16:18:02 +0100 Message-ID: <20230720151942.262154-51-ktraynor@redhat.com> In-Reply-To: <20230720151942.262154-1-ktraynor@redhat.com> References: <20230720151942.262154-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/25/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/792da5fcf7ef24b40eec717a1bbb5d771a1546a4 Thanks. Kevin --- >From 792da5fcf7ef24b40eec717a1bbb5d771a1546a4 Mon Sep 17 00:00:00 2001 From: Ciara Power Date: Fri, 14 Apr 2023 12:33:06 +0000 Subject: [PATCH] crypto/scheduler: fix last element for valid args [ upstream commit 34019b7b65d4d936649fab29fdee45ec3ada1a8d ] The list of valid arguments for Scheduler PMD should be terminated with a NULL entry, as expected by rte_kvargs_parse. Without this, if an invalid key name was used, a global buffer overflow occurred resulting in a segmentation fault. Fixes: 503e9c5afb38 ("crypto/scheduler: register as vdev driver") Signed-off-by: Ciara Power Acked-by: Kai Ji --- drivers/crypto/scheduler/scheduler_pmd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/scheduler/scheduler_pmd.c b/drivers/crypto/scheduler/scheduler_pmd.c index dd198080bf..f1cc2b8344 100644 --- a/drivers/crypto/scheduler/scheduler_pmd.c +++ b/drivers/crypto/scheduler/scheduler_pmd.c @@ -48,5 +48,6 @@ static const char * const scheduler_valid_params[] = { RTE_CRYPTODEV_VDEV_SOCKET_ID, RTE_CRYPTODEV_VDEV_COREMASK, - RTE_CRYPTODEV_VDEV_CORELIST + RTE_CRYPTODEV_VDEV_CORELIST, + NULL }; -- 2.41.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-07-20 16:18:01.211035463 +0100 +++ 0051-crypto-scheduler-fix-last-element-for-valid-args.patch 2023-07-20 16:17:54.721750753 +0100 @@ -1 +1 @@ -From 34019b7b65d4d936649fab29fdee45ec3ada1a8d Mon Sep 17 00:00:00 2001 +From 792da5fcf7ef24b40eec717a1bbb5d771a1546a4 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 34019b7b65d4d936649fab29fdee45ec3ada1a8d ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index 9d1ce46622..4e8bbf0e09 100644 +index dd198080bf..f1cc2b8344 100644 @@ -25 +26 @@ -@@ -51,5 +51,6 @@ static const char * const scheduler_valid_params[] = { +@@ -48,5 +48,6 @@ static const char * const scheduler_valid_params[] = {