From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B1DE142ECF for ; Thu, 20 Jul 2023 17:36:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ADAAF40685; Thu, 20 Jul 2023 17:36:40 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id ECF78400D6 for ; Thu, 20 Jul 2023 17:36:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689867398; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1LUB+0VX64hEZ7MpCGELG8iWnkkLFibI4DS9sC5GBL0=; b=Sw2Q8i/rWpu/6zIbyuThzkfbrXHJj8hVWql/iR0CkfdWW+uKNgnKPd9zBm9xTchrS1O0zE GjbCQxCHj384pFm6VLgZaN+XKHyv4NXh50rhRJdxodV3UJEUM5v8R5KPj6shAYAi4A1JtS YdWLKta2XnYOX9HeD9KqxnuPZ7yCDLQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-246-9uC6BQT_M2GZ9oTDgxSw2w-1; Thu, 20 Jul 2023 11:21:58 -0400 X-MC-Unique: 9uC6BQT_M2GZ9oTDgxSw2w-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5A166106525F; Thu, 20 Jul 2023 15:21:14 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id 38353492C13; Thu, 20 Jul 2023 15:21:13 +0000 (UTC) From: Kevin Traynor To: Saoirse O'Donovan Cc: Ciara Power , dpdk stable Subject: patch 'test/crypto: fix return value for SNOW3G' has been queued to stable release 21.11.5 Date: Thu, 20 Jul 2023 16:18:03 +0100 Message-ID: <20230720151942.262154-52-ktraynor@redhat.com> In-Reply-To: <20230720151942.262154-1-ktraynor@redhat.com> References: <20230720151942.262154-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/25/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/c4583cd33a28c1ca02e7b7e17936d8ef07fe2d2b Thanks. Kevin --- >From c4583cd33a28c1ca02e7b7e17936d8ef07fe2d2b Mon Sep 17 00:00:00 2001 From: Saoirse O'Donovan Date: Fri, 14 Apr 2023 13:55:26 +0000 Subject: [PATCH] test/crypto: fix return value for SNOW3G [ upstream commit 7ae50175c7e785ff258c3dc0e44dc80e89af79ac ] Unit tests were failing due to the return value of the decryption and authentication functions not being handled correctly. This has now been modified to return the expected test status. Fixes: e23eccfd281e ("test/crypto: fix bitwise operator in a SNOW3G case") Signed-off-by: Saoirse O'Donovan Acked-by: Ciara Power --- app/test/test_cryptodev.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index f3509bcb22..46764b045f 100644 --- a/app/test/test_cryptodev.c +++ b/app/test/test_cryptodev.c @@ -6880,4 +6880,5 @@ static int test_snow3g_decryption_with_digest_test_case_1(void) { + int ret; struct snow3g_hash_test_data snow3g_hash_data; struct rte_cryptodev_info dev_info; @@ -6898,6 +6899,7 @@ test_snow3g_decryption_with_digest_test_case_1(void) snow3g_hash_test_vector_setup(&snow3g_test_case_7, &snow3g_hash_data); - if (test_snow3g_decryption(&snow3g_test_case_7)) - return TEST_FAILED; + ret = test_snow3g_decryption(&snow3g_test_case_7); + if (ret != 0) + return ret; return test_snow3g_authentication_verify(&snow3g_hash_data); -- 2.41.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-07-20 16:18:01.320257860 +0100 +++ 0052-test-crypto-fix-return-value-for-SNOW3G.patch 2023-07-20 16:17:54.745750851 +0100 @@ -1 +1 @@ -From 7ae50175c7e785ff258c3dc0e44dc80e89af79ac Mon Sep 17 00:00:00 2001 +From c4583cd33a28c1ca02e7b7e17936d8ef07fe2d2b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 7ae50175c7e785ff258c3dc0e44dc80e89af79ac ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 3376ed91a3..0b2ce5ea65 100644 +index f3509bcb22..46764b045f 100644 @@ -23 +24 @@ -@@ -6945,4 +6945,5 @@ static int +@@ -6880,4 +6880,5 @@ static int @@ -29 +30 @@ -@@ -6963,6 +6964,7 @@ test_snow3g_decryption_with_digest_test_case_1(void) +@@ -6898,6 +6899,7 @@ test_snow3g_decryption_with_digest_test_case_1(void)