From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59C9742ECF for ; Thu, 20 Jul 2023 17:34:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 55D7140685; Thu, 20 Jul 2023 17:34:03 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 6A3CA400D6 for ; Thu, 20 Jul 2023 17:34:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689867240; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CQcJYCnlRc0vyugaLiqvLu/WEr6IrLOrpIH6rS92TFA=; b=LvFqK7eFxFh/vufpzk/JmFDDLEv8yuDVlLJ7/eoxSOziRPN2ET9C4FCxxdk6TPPRVM7rqT pN4KyTHLMzr4wX2vlvCMGXXG4mVpn50x/C5X9cZNamrnr+/0RX7PFKfxRqu22N0M7fxQpP HxRYL+2y9IcUMSXicj2vAcqgUk18pHw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-615-UMLJSBtBPVSKE6M3WAoMRA-1; Thu, 20 Jul 2023 11:21:57 -0400 X-MC-Unique: UMLJSBtBPVSKE6M3WAoMRA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 278A910504D4; Thu, 20 Jul 2023 15:21:44 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id 20580492C13; Thu, 20 Jul 2023 15:21:42 +0000 (UTC) From: Kevin Traynor To: Mingjin Ye Cc: Qi Zhang , dpdk stable Subject: patch 'net/ice: fix statistics' has been queued to stable release 21.11.5 Date: Thu, 20 Jul 2023 16:18:19 +0100 Message-ID: <20230720151942.262154-68-ktraynor@redhat.com> In-Reply-To: <20230720151942.262154-1-ktraynor@redhat.com> References: <20230720151942.262154-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/25/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/4408ee17167a109f0e9cca073d959b0f8a6cb04b Thanks. Kevin --- >From 4408ee17167a109f0e9cca073d959b0f8a6cb04b Mon Sep 17 00:00:00 2001 From: Mingjin Ye Date: Thu, 11 May 2023 02:10:55 +0000 Subject: [PATCH] net/ice: fix statistics [ upstream commit a47ef8640a677a3973de48b8075f1fcd6a0ee68e ] When the stats_get api is called for the first time in pmd, the offset of the stats register is not recorded. That results in all the obtained count values being 0. This patch adds reset statistics before dev_init returning. That avoids some noise being counted. Fixes: 12443386a0b0 ("net/ice: support flex Rx descriptor RxDID22") Signed-off-by: Mingjin Ye Acked-by: Qi Zhang --- drivers/net/ice/ice_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 08edca79ce..b0efacfd0f 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -2317,4 +2317,7 @@ ice_dev_init(struct rte_eth_dev *dev) pf->supported_rxdid = ice_get_supported_rxdid(hw); + /* reset all stats of the device, including pf and main vsi */ + ice_stats_reset(dev); + return 0; -- 2.41.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-07-20 16:18:03.181207424 +0100 +++ 0068-net-ice-fix-statistics.patch 2023-07-20 16:17:54.871751365 +0100 @@ -1 +1 @@ -From a47ef8640a677a3973de48b8075f1fcd6a0ee68e Mon Sep 17 00:00:00 2001 +From 4408ee17167a109f0e9cca073d959b0f8a6cb04b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit a47ef8640a677a3973de48b8075f1fcd6a0ee68e ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index e03bbd81a1..2345f9f29c 100644 +index 08edca79ce..b0efacfd0f 100644 @@ -26 +27 @@ -@@ -2441,4 +2441,7 @@ ice_dev_init(struct rte_eth_dev *dev) +@@ -2317,4 +2317,7 @@ ice_dev_init(struct rte_eth_dev *dev)