From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E10E842ECF for ; Thu, 20 Jul 2023 17:25:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DCA9042D2F; Thu, 20 Jul 2023 17:25:41 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id BF55F42D2F for ; Thu, 20 Jul 2023 17:25:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689866737; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uPBoYO7iDzNaIYqAUYhP5HIn0MW1Ujf4hV0/BJuva10=; b=Rt+atz91ZqIhMfLG0WpA7haUKRslY0gMO0NR7PMC5ZIelQL1mbWtl12eMxudU1DT82cXDP HLFSy863EeAhL7vGj2VN8qupFFCAOuVH8Z21NauaXe5JJszxzk0EXur2tzq74N25JxoiLz pRyR5hKj++cD5PbrSR2J3iykDB0V5zg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-475-ytGqgDnXOvacWc7vfZZPzg-1; Thu, 20 Jul 2023 11:22:58 -0400 X-MC-Unique: ytGqgDnXOvacWc7vfZZPzg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2028B810BB4; Thu, 20 Jul 2023 15:21:47 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2FE20492C13; Thu, 20 Jul 2023 15:21:45 +0000 (UTC) From: Kevin Traynor To: Shiyang He Cc: Qi Zhang , dpdk stable Subject: patch 'net/iavf: release large VF when closing device' has been queued to stable release 21.11.5 Date: Thu, 20 Jul 2023 16:18:21 +0100 Message-ID: <20230720151942.262154-70-ktraynor@redhat.com> In-Reply-To: <20230720151942.262154-1-ktraynor@redhat.com> References: <20230720151942.262154-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/25/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/45daf222f80c7499c5938f912ff627c6304b161a Thanks. Kevin --- >From 45daf222f80c7499c5938f912ff627c6304b161a Mon Sep 17 00:00:00 2001 From: Shiyang He Date: Mon, 8 May 2023 16:58:23 +0000 Subject: [PATCH] net/iavf: release large VF when closing device [ upstream commit cdd8d6dfd156709b05ce363d7c5f491cc927330a ] Multiple vfs created based on one PF. If one of the vf requests a large number of queues, the queue resources are not released when exiting the program, resulting in these queues cannot be available to other vfs. This commit fixes the issue by resetting the number of queues to default when closing the dev (refer to the kernel driver) . Fixes: e436cd43835b ("net/iavf: negotiate large VF and request more queues") Signed-off-by: Shiyang He Acked-by: Qi Zhang --- drivers/net/iavf/iavf_ethdev.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index a115a9f641..0a5847ee53 100644 --- a/drivers/net/iavf/iavf_ethdev.c +++ b/drivers/net/iavf/iavf_ethdev.c @@ -2661,4 +2661,16 @@ iavf_dev_close(struct rte_eth_dev *dev) iavf_config_promisc(adapter, false, false); + /* + * Release redundant queue resource when close the dev + * so that other vfs can re-use the queues. + */ + if (vf->lv_enabled) { + ret = iavf_request_queues(dev, IAVF_MAX_NUM_QUEUES_DFLT); + if (ret) + PMD_DRV_LOG(ERR, "Reset the num of queues failed"); + + vf->max_rss_qregion = IAVF_MAX_NUM_QUEUES_DFLT; + } + iavf_shutdown_adminq(hw); if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_WB_ON_ITR) { -- 2.41.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-07-20 16:18:03.420987935 +0100 +++ 0070-net-iavf-release-large-VF-when-closing-device.patch 2023-07-20 16:17:54.877751390 +0100 @@ -1 +1 @@ -From cdd8d6dfd156709b05ce363d7c5f491cc927330a Mon Sep 17 00:00:00 2001 +From 45daf222f80c7499c5938f912ff627c6304b161a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit cdd8d6dfd156709b05ce363d7c5f491cc927330a ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index f6d68403ce..9c55eaa66e 100644 +index a115a9f641..0a5847ee53 100644 @@ -26 +27 @@ -@@ -2736,4 +2736,16 @@ iavf_dev_close(struct rte_eth_dev *dev) +@@ -2661,4 +2661,16 @@ iavf_dev_close(struct rte_eth_dev *dev)