From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1BA6B42ECF for ; Thu, 20 Jul 2023 17:26:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1759D40685; Thu, 20 Jul 2023 17:26:02 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id EDBFA400D6 for ; Thu, 20 Jul 2023 17:25:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689866758; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ItYxzwoCyIvghTFfEpS9ja1L7XQvCFLgeZlkbddd0io=; b=c4Qi2xqB4X2Z29grsH/p4f3pJDT17Rhz0oQmKV1he0+6bxd8OvgZU3o8wUkQ5g+Hvjsr0J ur0/Q2HI9qQdPFnmU4w+MFb02xUYklVsiUYurcWafWRzorpWN02saQ8bAm577nZ6mGIT9k 4EUM+ILk4yQF5mLl3/uOjCLtIUxI/lk= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-591-mYWAPz_RM_aQ8XWVjvsJrg-1; Thu, 20 Jul 2023 11:22:49 -0400 X-MC-Unique: mYWAPz_RM_aQ8XWVjvsJrg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 62CD03C13538; Thu, 20 Jul 2023 15:22:28 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id 283F2492C13; Thu, 20 Jul 2023 15:22:26 +0000 (UTC) From: Kevin Traynor To: Artemii Morozov Cc: Andy Moreton , Andrew Rybchenko , dpdk stable Subject: patch 'common/sfc_efx/base: fix Rx queue without RSS hash prefix' has been queued to stable release 21.11.5 Date: Thu, 20 Jul 2023 16:18:48 +0100 Message-ID: <20230720151942.262154-97-ktraynor@redhat.com> In-Reply-To: <20230720151942.262154-1-ktraynor@redhat.com> References: <20230720151942.262154-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/25/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/21e4c85c18e6c1bff0547767c125bd21a310f475 Thanks. Kevin --- >From 21e4c85c18e6c1bff0547767c125bd21a310f475 Mon Sep 17 00:00:00 2001 From: Artemii Morozov Date: Thu, 22 Jun 2023 16:31:36 +0400 Subject: [PATCH] common/sfc_efx/base: fix Rx queue without RSS hash prefix [ upstream commit 80d18a958e4f06e121327073439c391dbc870d80 ] If the prefix for the RSS hash was not chosen the ENOTSUP error should be returned. Before this patch success was returned for this case causing Rx queue creation to fail. Fixing return value to indicate failure. Fixes: f784cdc5cbb1 ("common/sfc_efx/base: provide control to deliver RSS hash") Signed-off-by: Artemii Morozov Reviewed-by: Andy Moreton Acked-by: Andrew Rybchenko --- drivers/common/sfc_efx/base/efx_rx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/common/sfc_efx/base/efx_rx.c b/drivers/common/sfc_efx/base/efx_rx.c index 7e63363be7..631c2fd063 100644 --- a/drivers/common/sfc_efx/base/efx_rx.c +++ b/drivers/common/sfc_efx/base/efx_rx.c @@ -897,6 +897,8 @@ efx_rx_qcreate_internal( rss_hash_field = &erplp->erpl_fields[EFX_RX_PREFIX_FIELD_RSS_HASH]; - if (rss_hash_field->erpfi_width_bits == 0) + if (rss_hash_field->erpfi_width_bits == 0) { + rc = ENOTSUP; goto fail5; + } } -- 2.41.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-07-20 16:18:06.838931099 +0100 +++ 0097-common-sfc_efx-base-fix-Rx-queue-without-RSS-hash-pr.patch 2023-07-20 16:17:55.027752003 +0100 @@ -1 +1 @@ -From 80d18a958e4f06e121327073439c391dbc870d80 Mon Sep 17 00:00:00 2001 +From 21e4c85c18e6c1bff0547767c125bd21a310f475 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 80d18a958e4f06e121327073439c391dbc870d80 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index 68f42f5cac..61726a9f0b 100644 +index 7e63363be7..631c2fd063 100644 @@ -28 +29 @@ -@@ -938,6 +938,8 @@ efx_rx_qcreate_internal( +@@ -897,6 +897,8 @@ efx_rx_qcreate_internal(