From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 532374301F for ; Thu, 10 Aug 2023 02:01:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4CCFC4324E; Thu, 10 Aug 2023 02:01:15 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2054.outbound.protection.outlook.com [40.107.94.54]) by mails.dpdk.org (Postfix) with ESMTP id 1CE9E4325A for ; Thu, 10 Aug 2023 02:01:14 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JoaJf2wJptn46k/6qrlAc6+Evhny5UJDa9slDjIR9DLKrietyUUrWicPu35DF3+dgnAh4wHcdCRUgv46N3Apfh3KnwaNNjENoO6H1YHecREBG0m5SqGffsLm+asqfpWlitmdxvCOhak6Q+AUP+gJ23BaDAI1252qUOXOMbvADkKYdprKPnjbHCDXGcmiozFnscSf0DFIHwJgOuTALhBbjDmW3sOBpD5pgT6C/4tI3dRIEkKa+n/X8jxjJtwxz57SksCuRJzpheXxXw3tLgRCk8jffK2te4hQjzRrjaXRCzU4TRi58hrIouFBJMSUWmkim2nq5/KfHXGBigajZEIMlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MpfTQpQ7w5L0RkJZB8tJn6G4+ccfNpMknNuVdZYzymQ=; b=bKMoso2Ww+7Y+ZfFRgxSImsAbKub0zlh9bfNrxTbcM3kHSE52kUsTdCKW7UKnszS2xlLCFLaC0cBVHNCrHYJPgHRQ55C85A8c1kpaXBMr/0SGkB8TJIeatnXnpX2H/US9yta8FAKiMXSMZS4Sedbi3fGndYV8Qg4/cpR9id42On/mnUMYC+Si+7mVyT2jj3B/Cj2VEdAXjbdtAp4ZZ6uKIDsqlhmBvd3HSU+M335gcBLNFETU/6R3MhAyFDBFwHw7THnaXeUYQoBz8VWlgTBeGkJoUugkae2DMn4Nj8qPKDgKJ4LbYI1H0kkgVGY9EYa6DXcaRvXHynIOIbYAPHG1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=amd.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MpfTQpQ7w5L0RkJZB8tJn6G4+ccfNpMknNuVdZYzymQ=; b=B8GehycZg7uZ++prZMGl+pNZNdoCUfNeRK+wD06MwLr/4HUK/ovUmQrVIDTofO5apaB1ie2Ea+PelTPfofDwVbur7lZ6R9a1DkwtTUTGFYWl063RKWhZFOAkCd1kIaSAQO+ZU7X8lnWR04D2dCHbiYncqXYnVa0cVbq0IO5vSqFdSFjPw9X1ZJWh8XYjZO4i5UbZg5UqMufkAcl+O0ep/VaDOnEB7zW9t/CMcABo9U7eSBsINmaUbZk0Yo6fRwY5Sq7oWpTevP6S7yGDI0FQykUJAhOMrxCuUNqExzHUCIrdq7je1F88q8TSxs6DcoRVmnond+A4sp+QiFelCoaswA== Received: from CY5PR22CA0014.namprd22.prod.outlook.com (2603:10b6:930:16::34) by DM4PR12MB6133.namprd12.prod.outlook.com (2603:10b6:8:ae::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28; Thu, 10 Aug 2023 00:01:12 +0000 Received: from CY4PEPF0000E9CE.namprd03.prod.outlook.com (2603:10b6:930:16:cafe::66) by CY5PR22CA0014.outlook.office365.com (2603:10b6:930:16::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28 via Frontend Transport; Thu, 10 Aug 2023 00:01:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000E9CE.mail.protection.outlook.com (10.167.241.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.19 via Frontend Transport; Thu, 10 Aug 2023 00:01:11 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Wed, 9 Aug 2023 17:01:01 -0700 Received: from nvidia.com (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Wed, 9 Aug 2023 17:00:59 -0700 From: Xueming Li To: Ferruh Yigit CC: Song Jiale , Ali Alnubani , dpdk stable Subject: patch 'app/testpmd: revert primary process polling all queues fix' has been queued to stable release 22.11.3 Date: Thu, 10 Aug 2023 07:58:45 +0800 Message-ID: <20230809235947.1187-13-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230809235947.1187-1-xuemingl@nvidia.com> References: <20230625063544.11183-1-xuemingl@nvidia.com> <20230809235947.1187-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9CE:EE_|DM4PR12MB6133:EE_ X-MS-Office365-Filtering-Correlation-Id: 0e02acd8-3c48-4020-7363-08db9934e876 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oVz9wU5CGB5mqJ8PilzaVQBr5an1IbbrIsxj7Wgdw05BX5PzybuK+8IGPnynR6TjmxDXMbCL1GD6GceEdrtMg3Ssrj5ehOXb515+rZDsqOO62680J9IrkzJwUR0xpJnHyrsj8H8rivMSxjd4KF0xGd7L0JiQXMi3iFqK/Rj1ahf7xCQJTMatWksdu/+sVBgdrpZeRSePQhlKhaSKDMRwGV7zrT87vKwSV01Tfll5CWY+4mXStX12C4crtg7ZPar0O7+qub+LSyVn3C1HEGaTA9zRvBdPu1D/+y1pXDUEhMICLZLeShKvytf8Le844OFYNVek+w8PBtnfojHSxrpWj1uNXirdNZ0z54MYknROWi1Zbeu3OT1zX523DkEUAvhHY6k9y0RUPTC06XfWKEcoS+OsbzenV50jFX6CZL8kEtmM/aftuvVF52XMUkJyN7kz7Nhzv1Y5+WS5UzBaczXXGrGqUUrwfDSWAqnazyWsG1eFcuJkI/GzQoXOa9kVMT3mmAV5491w/b1y9wpUAqz4zCmbGnKtf9DIUfEZzA0pmMzoroiKD2HLpVFlkDOyCFdYkihwkdaRZ5vqci4k1QvfP0lWcWeq40fVpLI7QiQc//tt3Bp8QufBV3dHBG54wsdQqgK8DuGAJV5OAvpAg8pfde7I1VNVZRj7XztF4rwPN7o9Wn3/mz1w2HVXzY+cRnmfgFFC+xwgOy72JmAY+SUPjqw4Bc1GjtYRvsaU9wFKUMqmGQORMoYdNza4ywxmCexUoe+vpx73mautlQquyY+elQ== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(346002)(136003)(396003)(376002)(39860400002)(1800799006)(186006)(82310400008)(451199021)(40470700004)(36840700001)(46966006)(8676002)(8936002)(5660300002)(70206006)(70586007)(6916009)(4326008)(41300700001)(40460700003)(316002)(86362001)(36756003)(2906002)(55016003)(40480700001)(336012)(16526019)(6666004)(6286002)(7636003)(356005)(2616005)(82740400003)(7696005)(966005)(1076003)(26005)(36860700001)(53546011)(54906003)(83380400001)(426003)(47076005)(478600001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 00:01:11.8920 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0e02acd8-3c48-4020-7363-08db9934e876 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9CE.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6133 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/11/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=56b89656df888c122f485125b0c259f9758cf690 Thanks. Xueming Li --- >From 56b89656df888c122f485125b0c259f9758cf690 Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Wed, 5 Jul 2023 15:32:06 +0100 Subject: [PATCH] app/testpmd: revert primary process polling all queues fix Cc: Xueming Li [ upstream commit d7d802daf80f4a03c77a815da6d47a7b3657ef2c ] For some drivers [1], testpmd forwarding is broken with commit [2]. This is because with [2] testpmd gets queue state from ethdev and forwarding is done only on queues in started state, but some drivers don't update queue status properly, and this breaks forwarding for those drivers. Drivers should be fixed but more time is required to verify drivers again, instead reverting [2] for now to not break drivers. Target is to merge [2] back at the beginning of next release cycle and fix drivers accordingly. [1] Bugzilla ID: 1259 [2] Fixes: 141a520b35f7 ("app/testpmd: fix primary process not polling all queues") Signed-off-by: Ferruh Yigit Tested-by: Song Jiale Tested-by: Ali Alnubani --- app/test-pmd/testpmd.c | 20 ++++---------------- 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 5c1388a8c0..b69b248e47 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2355,13 +2355,6 @@ update_rx_queue_state(uint16_t port_id, uint16_t queue_id) ports[port_id].rxq[queue_id].state = rx_qinfo.queue_state; } else if (rc == -ENOTSUP) { - /* - * Do not change the rxq state for primary process - * to ensure that the PMDs do not implement - * rte_eth_rx_queue_info_get can forward as before. - */ - if (rte_eal_process_type() == RTE_PROC_PRIMARY) - return; /* * Set the rxq state to RTE_ETH_QUEUE_STATE_STARTED * to ensure that the PMDs do not implement @@ -2387,13 +2380,6 @@ update_tx_queue_state(uint16_t port_id, uint16_t queue_id) ports[port_id].txq[queue_id].state = tx_qinfo.queue_state; } else if (rc == -ENOTSUP) { - /* - * Do not change the txq state for primary process - * to ensure that the PMDs do not implement - * rte_eth_tx_queue_info_get can forward as before. - */ - if (rte_eal_process_type() == RTE_PROC_PRIMARY) - return; /* * Set the txq state to RTE_ETH_QUEUE_STATE_STARTED * to ensure that the PMDs do not implement @@ -2461,7 +2447,8 @@ start_packet_forwarding(int with_tx_first) return; if (stream_init != NULL) { - update_queue_state(); + if (rte_eal_process_type() == RTE_PROC_SECONDARY) + update_queue_state(); for (i = 0; i < cur_fwd_config.nb_fwd_streams; i++) stream_init(fwd_streams[i]); } @@ -3224,7 +3211,8 @@ start_port(portid_t pid) pl[cfg_pi++] = pi; } - update_queue_state(); + if (rte_eal_process_type() == RTE_PROC_SECONDARY) + update_queue_state(); if (at_least_one_port_successfully_started && !no_link_check) check_all_ports_link_status(RTE_PORT_ALL); -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-08-09 21:51:19.869420300 +0800 +++ 0066-app-testpmd-revert-primary-process-polling-all-queue.patch 2023-08-09 21:51:18.214352000 +0800 @@ -1 +1 @@ -From d7d802daf80f4a03c77a815da6d47a7b3657ef2c Mon Sep 17 00:00:00 2001 +From 56b89656df888c122f485125b0c259f9758cf690 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit d7d802daf80f4a03c77a815da6d47a7b3657ef2c ] @@ -23 +25,0 @@ -Cc: stable@dpdk.org @@ -29,3 +31,2 @@ - app/test-pmd/testpmd.c | 20 ++++---------------- - doc/guides/rel_notes/release_23_07.rst | 9 +++++++++ - 2 files changed, 13 insertions(+), 16 deletions(-) + app/test-pmd/testpmd.c | 20 ++++---------------- + 1 file changed, 4 insertions(+), 16 deletions(-) @@ -34 +35 @@ -index 1fc70650e0..c6ad9b18bf 100644 +index 5c1388a8c0..b69b248e47 100644 @@ -37 +38 @@ -@@ -2424,13 +2424,6 @@ update_rx_queue_state(uint16_t port_id, uint16_t queue_id) +@@ -2355,13 +2355,6 @@ update_rx_queue_state(uint16_t port_id, uint16_t queue_id) @@ -51 +52 @@ -@@ -2456,13 +2449,6 @@ update_tx_queue_state(uint16_t port_id, uint16_t queue_id) +@@ -2387,13 +2380,6 @@ update_tx_queue_state(uint16_t port_id, uint16_t queue_id) @@ -65 +66 @@ -@@ -2530,7 +2516,8 @@ start_packet_forwarding(int with_tx_first) +@@ -2461,7 +2447,8 @@ start_packet_forwarding(int with_tx_first) @@ -75 +76 @@ -@@ -3293,7 +3280,8 @@ start_port(portid_t pid) +@@ -3224,7 +3211,8 @@ start_port(portid_t pid) @@ -85,20 +85,0 @@ -diff --git a/doc/guides/rel_notes/release_23_07.rst b/doc/guides/rel_notes/release_23_07.rst -index be8027f71a..234650ac39 100644 ---- a/doc/guides/rel_notes/release_23_07.rst -+++ b/doc/guides/rel_notes/release_23_07.rst -@@ -286,6 +286,15 @@ Known Issues - Also, make sure to start the actual text at the margin. - ======================================================= - -+* **Testpmd is not forwarding on queues individually stopped.** -+ -+ Testpmd forwards packets on started queues. -+ If a queue explicitly stopped, and later port stopped and started again, -+ the status of the previously stopped queue is not updated, -+ so forwarding is not working on those queues. -+ -+ As a workaround start queues back explicitly, instead of port stop/start. -+ - - Tested Platforms - ----------------