From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 534D94301F for ; Thu, 10 Aug 2023 02:02:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4E7A040DD8; Thu, 10 Aug 2023 02:02:19 +0200 (CEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2065.outbound.protection.outlook.com [40.107.102.65]) by mails.dpdk.org (Postfix) with ESMTP id C3EFB406B6 for ; Thu, 10 Aug 2023 02:02:17 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=URpEI9uIwwysEAlURF6aYJmZ1hnwpQOIT74Cm/8HL4NlKkMMX+RdvsRv4aLKl1+5nP2zF/2/oeZu7LV2urf6l1t63IJbqbN05QFTvxKO5+8H7SOpG/na894YrF1TQrkL/8T2XisievcEAeJwrfCgMxNpocgwObRYoD+sj8TJaeAZkDIreXZuSOnOtxChX+pMUCYdSPssudmsJOvDwtJ8McegeKNX6wDp+oV4J6vLJD8RZqdr5Tzy9S4+rCjB96/yFoVj8RpbUBRlk69JQf3TtIe6kCAoN93TnB/Y+IbySsNxAPpY83iWpcRWDhBEnS4kZ+C47ASKzYwN6Vs3qkN5kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2NDxIzLAopIgg7aCG3lMC85QXZXypDc2HbxzqnfyCLc=; b=XRYHBgOgA99Bxeg+YCn7D6ZFFpr9iEmgEJ23L2rzH0/AxIrN8CSXuKuQRWj15m/u5C8wESp2z9eVen6ky09kZN+UuXKE+KdoilsgSBsqJX5ijwmsUuzPTAm7+07Nh0mC+DrliZ/N/ZT5l4PbF35K6FuRvIBuyE6esyDU/7FZwRaW/cG4cACdLXZOxYR4RpzA6pnzHg314dIbvFXwG2bbMJ8vQA0V4HZeSHI2SJNNHz9kYVrMmemQA0GxQHNtXUysAPUinLtiv9dpHo66taJneyaBA3UahtRzRTt6tcN8nyKRv9ke5oLrUMuVRGC1hWejUoWPh4hz6znJWS7ltbubtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2NDxIzLAopIgg7aCG3lMC85QXZXypDc2HbxzqnfyCLc=; b=RPyXqW/PI3a4ToYXgLR1IXBkLUbeRlsXOXBaYlUYCTAS0IU+ttShodGnPGwNbn8WfPmmF3ca8wT9t2XykXHZpRnqW/MVUsF0ZRBlZ4NYEEAuZIkdVvJTWyrbyd6Xk+eqiCkbSe2jmeCTeY2vrOM7f3fj0CSdYOdC7PR/2sd8SwjAZV39R+/QzwRUck8+psO38mXKwblNZdmutbNCsGhWwBRyDkAtL0tnr00aYJLozEx+rpZZx3w/bsVz3X2HQoPadnUwGctp/2M3hgv7uI5oOqpo4A7eqhvIA+A3+DW21IdwkyN0cMfr07H1VZia6pvqlhq8hxUD3Z5/C+joEvgNiA== Received: from CYZPR17CA0003.namprd17.prod.outlook.com (2603:10b6:930:8c::23) by SJ1PR12MB6316.namprd12.prod.outlook.com (2603:10b6:a03:455::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 00:02:15 +0000 Received: from CY4PEPF0000E9D1.namprd03.prod.outlook.com (2603:10b6:930:8c:cafe::16) by CYZPR17CA0003.outlook.office365.com (2603:10b6:930:8c::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.28 via Frontend Transport; Thu, 10 Aug 2023 00:02:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000E9D1.mail.protection.outlook.com (10.167.241.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.19 via Frontend Transport; Thu, 10 Aug 2023 00:02:15 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Wed, 9 Aug 2023 17:02:04 -0700 Received: from nvidia.com (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Wed, 9 Aug 2023 17:02:02 -0700 From: Xueming Li To: Bing Zhao CC: Ori Kam , dpdk stable Subject: patch 'net/mlx5: fix error set for age pool initialization' has been queued to stable release 22.11.3 Date: Thu, 10 Aug 2023 07:58:56 +0800 Message-ID: <20230809235947.1187-24-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230809235947.1187-1-xuemingl@nvidia.com> References: <20230625063544.11183-1-xuemingl@nvidia.com> <20230809235947.1187-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D1:EE_|SJ1PR12MB6316:EE_ X-MS-Office365-Filtering-Correlation-Id: 25bf4338-5caa-4da4-c0d5-08db99350e50 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FcuwYdn+rzE88SJXX7NRZSajy1hAfFVb86yESQ40d43D5etH/S8WX5wK91vxt4vP9tu2xjcGzfMUtHQPa67X/ZoZimqBghDi89Wqbi5FqRXGWhdVshXYcieco6ufsubfcmxuG7o8K6oInYaYoEIqnTDdXGitQznkoSnG2HY92IQiUX+E79bs7z3ySTNMGk1G2kVX1GpQ1AuLXCuntN+jsyj5oMOnw9LgIIvHSF/458erUYiqGMLYkCGVBGsw6ltyBU654Lxh1+nOTFpdlrq+bJ6NDqcTvhXw9Y4fKlaQAqZpqlZernddXyS6qQHwv9OjaTJZ/a0rASWOKjiLYKAC0sae3+WLZsxJIPjHVSjvpTIlE8VYO5nWHHrkLv4GABu5T3boIRtDpd0jzPkLVhu9Vs0VgT44tOP+kRKnRs5lIDLxSTREQU1a1RQDYGvmxE2Ed05DaTkLERtkLxyjlwd2FQyfq+X20Jc16EueUlm2+X3zq8T5WuCMoE+tlIVydzFvj9wlozkD/jg5F5ocdWWs80jIuCSExOzz1FguUNa005qkb1TzUuMMcCYLaPXzuzycOXaxd3X7x3dMtCL5coyZ8UHLZ4oKsKuZCn9/d05BTe2IpqYSzD+B/cw+EzdeQlTTsUlffnBSOQXkBpqDcXycPuGZFRVByDpX/yjHzli5U6N3960pm2KCBGfbuBjhXNfnQgRnMCRKRFB4UzVIBY8vrRAvMVkev+6zH+ty8NmSgnEVGw8kZxC5uarjAs24fY+SDh20VLQvBy2gzUy0G2GEGg== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(136003)(39860400002)(396003)(376002)(346002)(1800799006)(451199021)(186006)(82310400008)(46966006)(40470700004)(36840700001)(40460700003)(55016003)(40480700001)(16526019)(316002)(336012)(6286002)(426003)(41300700001)(2616005)(2906002)(82740400003)(5660300002)(8676002)(37006003)(54906003)(1076003)(26005)(53546011)(47076005)(36860700001)(83380400001)(6862004)(8936002)(6666004)(70206006)(7696005)(70586007)(478600001)(36756003)(86362001)(7636003)(4326008)(6636002)(966005)(356005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 00:02:15.4140 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 25bf4338-5caa-4da4-c0d5-08db99350e50 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D1.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6316 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/11/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=ab04a7f2da4eb590dd62b0d8498d61f2a3c32d8d Thanks. Xueming Li --- >From ab04a7f2da4eb590dd62b0d8498d61f2a3c32d8d Mon Sep 17 00:00:00 2001 From: Bing Zhao Date: Fri, 30 Jun 2023 13:26:49 +0300 Subject: [PATCH] net/mlx5: fix error set for age pool initialization Cc: Xueming Li [ upstream commit e8c51fa3ab0c43801ab144c6a4d7837dc7ab1cc2 ] The rte_flow_error needs to be set when the age pool initialization has a failure. Or else the application will crash due to the access of the invalid "message" field. Fixes: 04a4de756e14 ("net/mlx5: support flow age action with HWS") Signed-off-by: Bing Zhao Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow_hw.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index 3a1b3dfd06..5fe4cfa071 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -7072,8 +7072,11 @@ flow_hw_configure(struct rte_eth_dev *dev, goto err; } ret = mlx5_hws_age_pool_init(dev, port_attr, nb_queue); - if (ret < 0) + if (ret < 0) { + rte_flow_error_set(error, -ret, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, + NULL, "Failed to init age pool."); goto err; + } } ret = flow_hw_create_vlan(dev); if (ret) -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-08-09 21:51:20.136740400 +0800 +++ 0077-net-mlx5-fix-error-set-for-age-pool-initialization.patch 2023-08-09 21:51:18.234352000 +0800 @@ -1 +1 @@ -From e8c51fa3ab0c43801ab144c6a4d7837dc7ab1cc2 Mon Sep 17 00:00:00 2001 +From ab04a7f2da4eb590dd62b0d8498d61f2a3c32d8d Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit e8c51fa3ab0c43801ab144c6a4d7837dc7ab1cc2 ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org @@ -20 +22 @@ -index 94179ff747..0c72324617 100644 +index 3a1b3dfd06..5fe4cfa071 100644 @@ -23 +25 @@ -@@ -7914,8 +7914,11 @@ flow_hw_configure(struct rte_eth_dev *dev, +@@ -7072,8 +7072,11 @@ flow_hw_configure(struct rte_eth_dev *dev,