From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F4B84301F for ; Thu, 10 Aug 2023 02:03:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6960A40DD8; Thu, 10 Aug 2023 02:03:49 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2050.outbound.protection.outlook.com [40.107.94.50]) by mails.dpdk.org (Postfix) with ESMTP id C2A7C406B6 for ; Thu, 10 Aug 2023 02:03:47 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AaivWBM9FdHyhGumNVxnZcfbavUCmAYdCfNBMP3Z8ifbwbyZ3Ut/seZBChtQfBKbUWCslR6WU7sI9Zb7H3RBGKfwlmJf37un0CslViwML1b6e+3iS42sBxb6R95WLN1jms53jDLj/qxTxRUlFci/MRwdIVeWMBwbpllpX195QCd+3EUl8fLRkxMx9zSWUqdlUhmyuS59V3HZ4MY26xQF6tTIQlPDYWSt2JyeT66UXOYns0+zp5Vxn/VIuPYpg0yIMiJ0JRZClM/T8AVzZ5VZSMTDZRsVYirUIQdltUkeZTsAayJX2YHPvvoetlscIDioZjmr4in4dCR7hVo2i/9kRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LgIS0XURJXqM3UuZNHipP+IfWKy/H+4fOHpZLsva4Rw=; b=hB7g641k7TwCdzL52fpMZf665roFhHiClNNKOTFAwEGi+535q8CxHF8n2iAJ9bGQFpK/AHdW7W7JsR2GpS7HrgB/I/7KbxGn31ShGWWVFsPjH14fgi8yOJ/6BvWwIFrdEGxC+Xz7q7hUh0lycmx7vitjo841qsySYCQy0U+b96GJh2a7Ocop1WKYGvjjQJGuJ+DqqoOJkBhX1LuM08cm05kFtoatC2hq5MGrKraY3kPnagDsDV1/JB0U8BeyxS0iJ7DOqKxWOfHGIPXDetmDOKN7QZFCJDV22ySenfXaMGYr9KX5IMg8j7KXgHoX4KZeFUjMHc+y9QWpxWYPxU26CA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LgIS0XURJXqM3UuZNHipP+IfWKy/H+4fOHpZLsva4Rw=; b=p2hloJm6I1zk+fGSiXnnhrn+fKdZ3Qa1KVCxFsufPY0EdWd00FFkQ6hmDyXCcvlASF0kSM5Cq0jdjx/ylspf/yneUQZ0EB+cu78PeHFuAPp7dwO3juoImv+Xi+D5BDrVv9mbpkZVZgfSiV6z5T5NUiL9ejTm6ZIh4pc2GBJhp1Z0dEn6E3xVYvf13k9Wl5HkBbdURpr5frY3obhoy2FqXYjZXVQQXcGyHrjJ7z0ZqLY/lKFjgxLueKnzA4iuET1dwbol8uKxzzh40EWLidnWYmiz+13nxk21xWjC02C3mAAWl0Cl+6tLU8l+hI/a+grCUuGsVZ0gi35H9Bf0Ky9SaA== Received: from CYXPR02CA0041.namprd02.prod.outlook.com (2603:10b6:930:cc::6) by PH7PR12MB8594.namprd12.prod.outlook.com (2603:10b6:510:1b3::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 00:03:45 +0000 Received: from CY4PEPF0000E9D0.namprd03.prod.outlook.com (2603:10b6:930:cc:cafe::87) by CYXPR02CA0041.outlook.office365.com (2603:10b6:930:cc::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30 via Frontend Transport; Thu, 10 Aug 2023 00:03:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000E9D0.mail.protection.outlook.com (10.167.241.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.19 via Frontend Transport; Thu, 10 Aug 2023 00:03:45 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Wed, 9 Aug 2023 17:03:37 -0700 Received: from nvidia.com (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Wed, 9 Aug 2023 17:03:36 -0700 From: Xueming Li To: Yuying Zhang CC: Qi Zhang , dpdk stable Subject: patch 'net/ice: fix RSS hash key generation' has been queued to stable release 22.11.3 Date: Thu, 10 Aug 2023 07:59:09 +0800 Message-ID: <20230809235947.1187-37-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230809235947.1187-1-xuemingl@nvidia.com> References: <20230625063544.11183-1-xuemingl@nvidia.com> <20230809235947.1187-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D0:EE_|PH7PR12MB8594:EE_ X-MS-Office365-Filtering-Correlation-Id: f242bfc5-f1e0-40b8-093f-08db993543f2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /xemI6CVW7S38jSmJOOaOVOxgwjn1XHU6CFSttOqiL+DeGI9MSJj14p3UjIQz/lIbQwEhPRNOoLthVz7u3LR6xlJJG1PUVARSf1U/piSBMttFGif6PpnXC4AdTPx7Thi5MHSA1jckBWTfI91/hRPRdSDGeqEZjEx0V3ejvNv/4J45x24cQ+N+IPAi/oDBCgRp3yn7RPrnbgZymAj+K+DW3MU2AhNL3wSLyaRubWbVc9u6pZQ0RMFNBY8C6zWR3Fl4Bmr2fHZHdHFMu1QXrDZtAW6gYU/m53ToC8rbwTiRsN1pK2H4xf5sfEH9qMwtCoUbzTqryT5gvLbTfybkchjB6J0NX6rgIW3WA/I3CJeJi+Sl6qlAsKgupYM4UNrII8p/Q3PaoT5Pk/x1ORqUvIxaDrpPVctqYVJ6dkykmcW2MVYV0/sL7PIjsP0bW9DTqfYlZ8nZ+9N2ksBwFrtPBNMMhw663NEw/dkv7kKiW6V6B4tPGH0rapL6cnLI2UWra2TPu0TZOVATOUR/WSe/mUnQOI2Cbe0bNjXXttlzjTHGXs9YRGdyqCJBhhIMKL6H+HmE8LzdN0aLwz6y96WjxNYYser7qacGXqWzgjGmX9DEyR06eC91BYV6vUPBlFhjqaU+unHK6c9F8IzFC9ynNGRBZpItc3xW4kZZCahrf8RfVOrtpqNL56ktJKaIJcAHAkdcgHUXLqRZYgHRbFwu6xY0SFtq6rGByzGMlI0HnzC3el4aQV1nuKvqXfdfPXv63s6HFFV49NpxRovO9mfI2uW1w== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(136003)(39860400002)(376002)(396003)(346002)(1800799006)(186006)(82310400008)(451199021)(40470700004)(46966006)(36840700001)(36756003)(26005)(82740400003)(316002)(8676002)(8936002)(7696005)(966005)(36860700001)(1076003)(5660300002)(6666004)(356005)(6916009)(53546011)(4326008)(70586007)(41300700001)(70206006)(47076005)(83380400001)(7636003)(6286002)(16526019)(2906002)(426003)(336012)(40460700003)(2616005)(55016003)(86362001)(478600001)(40480700001)(54906003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 00:03:45.3902 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f242bfc5-f1e0-40b8-093f-08db993543f2 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D0.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8594 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/11/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=9b95d1a0f8d7dbb03fdaa27f2bb1ccc5c10a8f3a Thanks. Xueming Li --- >From 9b95d1a0f8d7dbb03fdaa27f2bb1ccc5c10a8f3a Mon Sep 17 00:00:00 2001 From: Yuying Zhang Date: Fri, 7 Jul 2023 02:10:46 +0000 Subject: [PATCH] net/ice: fix RSS hash key generation Cc: Xueming Li [ upstream commit b9f28be1bf72e120041416b461325941fd97cac0 ] Current code just generated 40 bytes standard rss hash key of ice driver. The extended 12 bytes were filled by hardware and were invalid for users. This patch generate 52 bytes rss hash key for ice driver just as other drivers. Fixes: 50370662b727 ("net/ice: support device and queue ops") Fixes: 20d6a017e148 ("net/ice: fix build with GCC 12") Signed-off-by: Yuying Zhang Acked-by: Qi Zhang --- drivers/net/ice/ice_ethdev.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index c004aa42ee..bba2715b1d 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -3312,7 +3312,8 @@ static int ice_init_rss(struct ice_pf *pf) rss_conf = &dev_data->dev_conf.rx_adv_conf.rss_conf; nb_q = dev_data->nb_rx_queues; - vsi->rss_key_size = ICE_AQC_GET_SET_RSS_KEY_DATA_RSS_KEY_SIZE; + vsi->rss_key_size = ICE_AQC_GET_SET_RSS_KEY_DATA_RSS_KEY_SIZE + + ICE_AQC_GET_SET_RSS_KEY_DATA_HASH_KEY_SIZE; vsi->rss_lut_size = pf->hash_lut_size; if (nb_q == 0) { @@ -3353,7 +3354,10 @@ static int ice_init_rss(struct ice_pf *pf) vsi->rss_key_size)); rte_memcpy(key.standard_rss_key, vsi->rss_key, - RTE_MIN(sizeof(key.standard_rss_key), vsi->rss_key_size)); + ICE_AQC_GET_SET_RSS_KEY_DATA_RSS_KEY_SIZE); + rte_memcpy(key.extended_hash_key, + &vsi->rss_key[ICE_AQC_GET_SET_RSS_KEY_DATA_RSS_KEY_SIZE], + ICE_AQC_GET_SET_RSS_KEY_DATA_HASH_KEY_SIZE); ret = ice_aq_set_rss_key(hw, vsi->idx, &key); if (ret) goto out; -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-08-09 21:51:20.514920400 +0800 +++ 0090-net-ice-fix-RSS-hash-key-generation.patch 2023-08-09 21:51:18.264352000 +0800 @@ -1 +1 @@ -From b9f28be1bf72e120041416b461325941fd97cac0 Mon Sep 17 00:00:00 2001 +From 9b95d1a0f8d7dbb03fdaa27f2bb1ccc5c10a8f3a Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit b9f28be1bf72e120041416b461325941fd97cac0 ] @@ -14 +16,0 @@ -Cc: stable@dpdk.org @@ -23 +25 @@ -index 949b13324f..4bad39c2c1 100644 +index c004aa42ee..bba2715b1d 100644 @@ -26 +28 @@ -@@ -3350,7 +3350,8 @@ static int ice_init_rss(struct ice_pf *pf) +@@ -3312,7 +3312,8 @@ static int ice_init_rss(struct ice_pf *pf) @@ -36 +38 @@ -@@ -3391,7 +3392,10 @@ static int ice_init_rss(struct ice_pf *pf) +@@ -3353,7 +3354,10 @@ static int ice_init_rss(struct ice_pf *pf)