From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 639954301F for ; Thu, 10 Aug 2023 02:08:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5BA934325A; Thu, 10 Aug 2023 02:08:28 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2063.outbound.protection.outlook.com [40.107.92.63]) by mails.dpdk.org (Postfix) with ESMTP id 5B65A406B6 for ; Thu, 10 Aug 2023 02:08:26 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NhpCCoY2Yo+vjjXAvOrFHpJ9hMDUIq+QZvmaPN8dJLKSKmB6w2jMonKD5uBSlphw4tUnkPJewqTiuEb7b+5XTre0LEXX+4uW0zex8myEujmzi2//PJVajAqKrvr2dv+PtjPvuqDHEcemw22rhbt3RBb3p6uWF0fqrWR8I/USGC97EkB008QCfLpcKC7++TIqyiDif/Y0aFjXRJlt0gktABSRJ4bSIPxNlOeNh7tyddNUQ99KYWQXWFi7YNTf/Z7rhsAZG/eHlnrl3gRTZ9AGnCm6DsajI6BWDZs0LXEpj/IAvMZ9k/32GNoUbFE+tkzJW9mXmz4etErnAUqotkwCaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=op+Z5KIpJhL2/oaqc/zOHXSq2UFrDK9pONx+N9cMSHQ=; b=mT2lqanrOvWdc+1Ga84O5Yl4J3Br+OYvYXKXehM2y/xorAU3WdsVK2dImbP3v/rCY1Ni4mi8yN+WFv+LTD61PbllZ+lBAahdJu5Fdp6cu71JTMf+wjNSphSbthMEkYDQLGHoUq7JC1zFM8Ai/SNf4SqQzGsSXm6UnChF+8dfPfakTRfdvb2a5y+2yInDeR6NWCFFU6aMZ4YC5pUnt8Q76FFiloOy8KC1LpgJ+uAk7m3D01tRtv15cv00xI5VHicQ/qzZkKkpsZFaIYNIvihZzn5hHykb3JSzWk/mqdp79/AJcqkzt89QkfV4JZTLSEjaQWqFDmOIp5K5lNRxfftheA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=marvell.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=op+Z5KIpJhL2/oaqc/zOHXSq2UFrDK9pONx+N9cMSHQ=; b=IHw1bLq7VcETDNpCy/Cm9uKN13l2sY3B0rZv3CS1Y/pMLUYwTtki+FfIJPoi8ARdJKgA15h61rxdhHoH25nKQouLT07XNKru+i9+98pV8jYNOmZgQ+S6A0tMPVgC4vl4kEOD9BhJF5dJPsn5EOF4lqLX+4WCL4wgMqkQpGw3rRc6CTPszU9OyTB4Vt50A0hMmOHglQCq/6jngSdR07EmzVLMNWvXAqTBCUZzQIySGuYjiXt7PaGREoC5LpzMvr3F3akWIlbPGVm7rWNJftmCEcU/K/1RyVJoGPnpAOhqocyagm56CtFmQbOc44Q4RPV+egSYWrP9LbZpiAoV8G8lTw== Received: from CH0P223CA0017.NAMP223.PROD.OUTLOOK.COM (2603:10b6:610:116::13) by SJ0PR12MB6901.namprd12.prod.outlook.com (2603:10b6:a03:47e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Thu, 10 Aug 2023 00:08:24 +0000 Received: from CY4PEPF0000EE36.namprd05.prod.outlook.com (2603:10b6:610:116:cafe::21) by CH0P223CA0017.outlook.office365.com (2603:10b6:610:116::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30 via Frontend Transport; Thu, 10 Aug 2023 00:08:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000EE36.mail.protection.outlook.com (10.167.242.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.19 via Frontend Transport; Thu, 10 Aug 2023 00:08:23 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Wed, 9 Aug 2023 17:08:11 -0700 Received: from nvidia.com (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Wed, 9 Aug 2023 17:08:09 -0700 From: Xueming Li To: Mohammad Iqbal Ahmad CC: Conor Walsh , Stephen Hemminger , dpdk stable Subject: patch 'examples/l3fwd: fix duplicate expression for default nexthop' has been queued to stable release 22.11.3 Date: Thu, 10 Aug 2023 08:06:51 +0800 Message-ID: <20230810000717.2191-10-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230810000717.2191-1-xuemingl@nvidia.com> References: <20230625063544.11183-1-xuemingl@nvidia.com> <20230810000717.2191-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE36:EE_|SJ0PR12MB6901:EE_ X-MS-Office365-Filtering-Correlation-Id: 76b287be-c14e-4a43-0daa-08db9935e979 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5HSEcBAWZgdUrTtQY7ECEE5DPr8LL5gA4qblUDZZAy6pm9DuRH/y1eZ5ykK4E1Dq8Qzvvg7dtdp9Io1nA1o0V+20YEImSR5ND5VtpcBSuLtHV5uKQnuqYvn8EqQ+4GmTdwv774XLZHTRYk7YXpvXET3emkp5fv6llFEQLd3yr74DAgBWVm7eDUxUABTvFI/3pupgrGzGErAzsGYt3zHWmQhsMAoTQpouqB6B8MH3HzVlkPeSv8O/JgNjgTDOV522JzJABsHBnjhjD9XuH0GpFxkHVdvlEuTmKj2JAmcLYr7hcJuF+hrBkIZKvAk7DQxdD5v75weP7Eqk2gJv/8ojnrW/r8K5Aq7+dVDGFFNpWxy0jt/GuSsoMkPJAtjBER0NP0J9liyLhHPHJ0TL1wJfylsE0DfnJ99a5RR42CNnkKKXKsUfTPHd0JcTh9j3QzeQfuaMCkkmv5WhEccW1B7UmlHhaP60LeMqHOXT5pvgXrXDh7lde9Q6EbQ6pR36p730sTPJ8aZA4nJlmsgVDqc2LVqPxGJlsiZkX4EUcmZw24ryyxOfhCnhb4JNKMF+UqJFGK9KXBZRZE+erDgIZtbUleslslrew6uXDXQZBOIq2pjjYAlhahbb7sMU1dtr30BwKCiJMCiboPy2uM36ED/gnvD/bYejM+GFJp9QJc2S3PDbuHDCQhRr2syroqMTSwh0wIxX4kV0mC4ihEGr+SbyI4Y4SEA+85NewLRcI9NyEwcxRWuFdwqbkS7UUpahNRhkpRcgdzRPGaZagUB6LDMxjw== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(346002)(39860400002)(376002)(136003)(396003)(1800799006)(186006)(82310400008)(451199021)(36840700001)(40470700004)(46966006)(40460700003)(2616005)(36860700001)(47076005)(7636003)(356005)(426003)(83380400001)(6286002)(16526019)(36756003)(478600001)(54906003)(26005)(336012)(86362001)(53546011)(1076003)(966005)(6666004)(7696005)(55016003)(40480700001)(2906002)(82740400003)(4326008)(316002)(70586007)(6916009)(70206006)(8676002)(8936002)(5660300002)(41300700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 00:08:23.1304 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 76b287be-c14e-4a43-0daa-08db9935e979 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE36.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6901 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/11/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=9f9ea16ee2e6c799f56399aaa4dd7f64437ace72 Thanks. Xueming Li --- >From 9f9ea16ee2e6c799f56399aaa4dd7f64437ace72 Mon Sep 17 00:00:00 2001 From: Mohammad Iqbal Ahmad Date: Tue, 10 Jan 2023 20:26:13 +0530 Subject: [PATCH] examples/l3fwd: fix duplicate expression for default nexthop Cc: Xueming Li [ upstream commit 9a518054b5551576745a89c1cf60301655c03a9b ] This patch fixes (Logically dead code) coverity issue. This patch also fixes (Uninitialized scalar variable) coverity issue. Coverity issue: 381687, 381686 Fixes: 6a094e328598 ("examples/l3fwd: implement FIB lookup method") Signed-off-by: Mohammad Iqbal Ahmad Acked-by: Conor Walsh Acked-by: Stephen Hemminger --- examples/l3fwd/l3fwd_fib.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/examples/l3fwd/l3fwd_fib.c b/examples/l3fwd/l3fwd_fib.c index edc0dd69b9..18398492ae 100644 --- a/examples/l3fwd/l3fwd_fib.c +++ b/examples/l3fwd/l3fwd_fib.c @@ -359,10 +359,10 @@ fib_event_loop(struct l3fwd_event_resources *evt_rsrc, nh = (uint16_t)hopsv4[ipv4_arr_assem++]; else nh = (uint16_t)hopsv6[ipv6_arr_assem++]; - if (nh != FIB_DEFAULT_HOP) - hops[i] = nh != FIB_DEFAULT_HOP ? - nh : - events[i].mbuf->port; + + hops[i] = nh != FIB_DEFAULT_HOP ? + nh : + events[i].mbuf->port; process_packet(events[i].mbuf, &hops[i]); events[i].mbuf->port = hops[i] != BAD_PORT ? hops[i] : -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-08-09 21:51:20.797561100 +0800 +++ 0102-examples-l3fwd-fix-duplicate-expression-for-default-.patch 2023-08-09 21:51:18.264352000 +0800 @@ -1 +1 @@ -From 9a518054b5551576745a89c1cf60301655c03a9b Mon Sep 17 00:00:00 2001 +From 9f9ea16ee2e6c799f56399aaa4dd7f64437ace72 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 9a518054b5551576745a89c1cf60301655c03a9b ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org