* [PATCH] net/nfp: update incorrect MAC stats offset
@ 2023-10-10 6:09 Chaoyong He
2023-10-16 13:25 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Chaoyong He @ 2023-10-10 6:09 UTC (permalink / raw)
To: dev; +Cc: oss-drivers, James Hershaw, stable, Peng Zhang, Chaoyong He
From: James Hershaw <james.hershaw@corigine.com>
The pointer to the beginning of the MAC stats counters for port 1 are
incorrectly set as the pointer to the beginning of the port 0 MAC stats
counters, plus the size of the MAC stats counters multiplied by the port
number.
This patch corrects this by setting the multiplier as the eth_table
index of the port.
Fixes: f26e82397f6d ("net/nfp: implement xstats")
Cc: stable@dpdk.org
Signed-off-by: James Hershaw <james.hershaw@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
---
drivers/net/nfp/nfp_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c
index ebc5538291..0645123c99 100644
--- a/drivers/net/nfp/nfp_ethdev.c
+++ b/drivers/net/nfp/nfp_ethdev.c
@@ -547,7 +547,8 @@ nfp_net_init(struct rte_eth_dev *eth_dev)
return -ENODEV;
/* Use port offset in pf ctrl_bar for this ports control bar */
hw->ctrl_bar = pf_dev->ctrl_bar + (port * NFP_PF_CSR_SLICE_SIZE);
- hw->mac_stats = app_fw_nic->ports[0]->mac_stats_bar + (port * NFP_MAC_STATS_SIZE);
+ hw->mac_stats = app_fw_nic->ports[0]->mac_stats_bar +
+ (hw->nfp_idx * NFP_MAC_STATS_SIZE);
}
PMD_INIT_LOG(DEBUG, "ctrl bar: %p", hw->ctrl_bar);
--
2.39.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net/nfp: update incorrect MAC stats offset
2023-10-10 6:09 [PATCH] net/nfp: update incorrect MAC stats offset Chaoyong He
@ 2023-10-16 13:25 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2023-10-16 13:25 UTC (permalink / raw)
To: Chaoyong He, dev; +Cc: oss-drivers, James Hershaw, stable, Peng Zhang
On 10/10/2023 7:09 AM, Chaoyong He wrote:
> From: James Hershaw <james.hershaw@corigine.com>
>
> The pointer to the beginning of the MAC stats counters for port 1 are
> incorrectly set as the pointer to the beginning of the port 0 MAC stats
> counters, plus the size of the MAC stats counters multiplied by the port
> number.
>
> This patch corrects this by setting the multiplier as the eth_table
> index of the port.
>
> Fixes: f26e82397f6d ("net/nfp: implement xstats")
> Cc: stable@dpdk.org
>
> Signed-off-by: James Hershaw <james.hershaw@corigine.com>
> Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-16 13:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-10 6:09 [PATCH] net/nfp: update incorrect MAC stats offset Chaoyong He
2023-10-16 13:25 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).