* [PATCH] net/nfp: fix coredump problem when testpmd exit
@ 2023-10-17 2:37 Chaoyong He
2023-10-17 13:57 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Chaoyong He @ 2023-10-17 2:37 UTC (permalink / raw)
To: dev; +Cc: oss-drivers, Chaoyong He, stable, Long Wu, Peng Zhang
The ".dev_close" should not call rte_eth_dev_release_port() API
directly, the rte_eth_dev_close() API will do it.
Fixes: 831c44ab7869 ("net/nfp: add flower PF related routines")
Cc: chaoyong.he@corigine.com
Cc: stable@dpdk.org
Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
---
drivers/net/nfp/flower/nfp_flower.c | 2 --
drivers/net/nfp/nfp_ethdev.c | 1 -
2 files changed, 3 deletions(-)
diff --git a/drivers/net/nfp/flower/nfp_flower.c b/drivers/net/nfp/flower/nfp_flower.c
index 0c54d7ed27..60d843451e 100644
--- a/drivers/net/nfp/flower/nfp_flower.c
+++ b/drivers/net/nfp/flower/nfp_flower.c
@@ -221,8 +221,6 @@ nfp_flower_pf_close(struct rte_eth_dev *dev)
nn_cfg_writeb(hw, NFP_NET_CFG_LSC, 0xff);
- rte_eth_dev_release_port(dev);
-
/* Now it is safe to free all PF resources */
PMD_DRV_LOG(INFO, "Freeing PF resources");
nfp_cpp_area_free(pf_dev->ctrl_area);
diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c
index 20940072fe..d32a82210c 100644
--- a/drivers/net/nfp/nfp_ethdev.c
+++ b/drivers/net/nfp/nfp_ethdev.c
@@ -286,7 +286,6 @@ nfp_net_close(struct rte_eth_dev *dev)
/* Mark this port as unused and free device priv resources */
nn_cfg_writeb(hw, NFP_NET_CFG_LSC, 0xff);
app_fw_nic->ports[hw->idx] = NULL;
- rte_eth_dev_release_port(dev);
for (i = 0; i < app_fw_nic->total_phyports; i++) {
/* Check to see if ports are still in use */
--
2.39.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net/nfp: fix coredump problem when testpmd exit
2023-10-17 2:37 [PATCH] net/nfp: fix coredump problem when testpmd exit Chaoyong He
@ 2023-10-17 13:57 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2023-10-17 13:57 UTC (permalink / raw)
To: Chaoyong He, dev; +Cc: oss-drivers, stable, Long Wu, Peng Zhang
On 10/17/2023 3:37 AM, Chaoyong He wrote:
> The ".dev_close" should not call rte_eth_dev_release_port() API
> directly, the rte_eth_dev_close() API will do it.
>
> Fixes: 831c44ab7869 ("net/nfp: add flower PF related routines")
> Cc: chaoyong.he@corigine.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
> Reviewed-by: Long Wu <long.wu@corigine.com>
> Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-17 13:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-17 2:37 [PATCH] net/nfp: fix coredump problem when testpmd exit Chaoyong He
2023-10-17 13:57 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).