From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 265B7431D5 for ; Sun, 22 Oct 2023 16:32:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1EACB40ECF; Sun, 22 Oct 2023 16:32:30 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by mails.dpdk.org (Postfix) with ESMTP id 4DE0B402EA for ; Sun, 22 Oct 2023 16:32:28 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mV7TqMvpwvxEJNLxHeHSM/DPmAtZwcW885l4AoC3Z2QUgj36gCLf5A+oFAv1KVyqvl9ij0D4jm5htREFmA7S6YyVdGWBsv3PFLE9QcH5nW0kb6eWkTUy4YggtQ1D5tnWMP6lca2AxTSbDbN+ibp9DWxTnb44J2ommt0TKd7xGuDCPWextV+ovNVRkQ04AReqBNnaMay5QdV8yRdmoLjyNkhd7rN+r2Pg/rLcejFaAfPrthaAWQ69wLOENoWJwDcg3WgW/oQDEO1Q+L1sn7JEbkjkX9piHc2mBVzzHPwuAOQHw1VaBxFBP1fgmZojBSIJE0x8+hkZXuDDhoXSCvCprQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+5NbO6aHBkRDwEdGl8jx6Sv1lUtxBdhpsQQm5p8qb+o=; b=HdUy8OFSHX2v884rv+QrxDB2FZFe0HU0+bJm4HrgyU0347h8d5L2iJ6Zb4MsjROeGi2CQJMilB4sIaQCpDP6x6hZcq5wviuYBjVAgGyzW0B8+PAXS2tO+VkFer9UFLGKLFT5S00yqtGQoGuJGiV4v8LZ3q9p5doR48NBDP+n/TVoMkV8/LNG3Q2Mj3omVGLyC5WftrlxhvcSl+BPYLrDYyU3RtmAoRiDBLL/CozZPLr+ANy5TwUbjdDuMS1gZ/avLmZv8qBQQa4YVacYJjgqZ+/0tA1+84Z6NIu9HleykfR3MuRhf9u3satXlNCrF0LJW/LwLsrXWsjfXDbCDYzyfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=huawei.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+5NbO6aHBkRDwEdGl8jx6Sv1lUtxBdhpsQQm5p8qb+o=; b=LorIDLm4AB052Exon3CVNQAcRqMqLyHCOSbQ5Mx2oF4Lpv8bDS18bx0kioozK5e8b+Ejt6x80Wy7/wpLQphzt8lUxFc32BQLKCQzVqtMJUBRrugm1Lvi3SXsV3gc2NxNIg3MzEIAOa0+ygrFENUTCpUJsnFK2iWm13t+ixWHufBaNW96l/N8s/6TuMvJcCbdQuu+A6Cnmx1NKRLp8lh81hWm1nFaDFuPYgwPn/ph1Ip+dsar7y8zCEgtlh+4PUAvbYjbvBvCgsJkRLmDe0qCpqzQmzLpplPTlKU6BdZCXbKT7G65/F+hqy5cIVbBfscCifvf5dQVXKMlTaZ/TjLrhQ== Received: from CY5PR10CA0029.namprd10.prod.outlook.com (2603:10b6:930:1c::27) by CY5PR12MB6033.namprd12.prod.outlook.com (2603:10b6:930:2f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.31; Sun, 22 Oct 2023 14:32:26 +0000 Received: from CY4PEPF0000EE30.namprd05.prod.outlook.com (2603:10b6:930:1c:cafe::3) by CY5PR10CA0029.outlook.office365.com (2603:10b6:930:1c::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33 via Frontend Transport; Sun, 22 Oct 2023 14:32:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000EE30.mail.protection.outlook.com (10.167.242.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.15 via Frontend Transport; Sun, 22 Oct 2023 14:32:25 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 22 Oct 2023 07:32:17 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 22 Oct 2023 07:32:15 -0700 From: Xueming Li To: Jie Hai CC: Ferruh Yigit , dpdk stable Subject: patch 'net/af_xdp: fix Rx and Tx queue state' has been queued to stable release 22.11.4 Date: Sun, 22 Oct 2023 22:22:16 +0800 Message-ID: <20231022142250.10324-108-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231022142250.10324-1-xuemingl@nvidia.com> References: <20231022142250.10324-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE30:EE_|CY5PR12MB6033:EE_ X-MS-Office365-Filtering-Correlation-Id: 56fb3cbe-53cb-4148-eaeb-08dbd30bb619 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UK3SyjFmxVbGcpafgVjTce9B8+fRWCllr2PtMbaLmUg4knm9IGDTrG58VkaFzg9DyjjdEyCZoBaUL8XNIjX5RlBQaPKVnatLh59ZM8OumOzaAnGF/b5lJkkiOTxFqAq4XAZT5AskHs4pgdzKp5+FSbHdPz2uWKgIon4jqEvNRX+FkWcchgYRMlpKbQZJWtVwDdvSy5VW5vqlnh0FgAJNFdScRcvzh1x0jnrQv4/yyr6TIEna3I4VpRiLlH2VpwQqoOyQe/BDt2pvyRgJBFO3fz/ZSf5GWeVGkq9QdNEKC5zrhGLIWhvjwpRK8uflj1rUD/HaIoXvQXTYUw3Fwx80yJfj//lEiraI6lnASNYKpaQblg6FyLaL6GAtCQanMqFA+tunaONDRpIVhPy7wgRyjnpgVz4sk+ms7CjZJTYfiFOqMFmFtQTuX3Euu+xkxRWX3iBVGIY+mib0CeAFg6etykhwy1P6N0ku8M68t99mbKtxa/6ww9hJYk7+MyCVg63gVWLlzOsVDnpWITGnZi2UI5wdajVbjBI9DDRJ7jMdVnD9mB3LS3UFcyftXLieoLzOQ+2KqSfPOiNsPxVbWt5HpAuggWphjNG2p6LKqc7iXFrTGC6V6840KrV+mdSaAluqEs1Y6dVgTsOfeHwjGBMET4MeUNs5EpzE4sBvLLAdU4KRb0huhgYuNC6BDNzUJgLfQjBa3aYg4CaKnEKRLAg1CWJ+k/jXCdWlV6TMniYTK+rB8I0vYzrStKpkKywrAnzr/DchLbEtCLjWTO3aMRkvww== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(396003)(39850400004)(136003)(346002)(376002)(230922051799003)(64100799003)(451199024)(1800799009)(82310400011)(186009)(36840700001)(46966006)(40470700004)(2906002)(36860700001)(6916009)(316002)(70206006)(70586007)(54906003)(82740400003)(19627235002)(2616005)(356005)(7696005)(26005)(6286002)(16526019)(7636003)(1076003)(478600001)(53546011)(966005)(55016003)(47076005)(40480700001)(336012)(426003)(40460700003)(41300700001)(5660300002)(36756003)(86362001)(4326008)(8936002)(8676002)(4001150100001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2023 14:32:25.4903 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 56fb3cbe-53cb-4148-eaeb-08dbd30bb619 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE30.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6033 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/15/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=b4078f8a6b8bdc098df5dddf181a029510d42a14 Thanks. Xueming Li --- >From b4078f8a6b8bdc098df5dddf181a029510d42a14 Mon Sep 17 00:00:00 2001 From: Jie Hai Date: Fri, 8 Sep 2023 19:28:28 +0800 Subject: [PATCH] net/af_xdp: fix Rx and Tx queue state Cc: Xueming Li [ upstream commit 9a204f7e4e86d8270cae3cdec2b7949f5954fde2 ] The DPDK framework reports the queue state, which is stored in dev->data->tx_queue_state and dev->data->rx_queue_state. The state is maintained by the driver. Users may determine whether a queue participates in packet forwarding based on the state. Therefore, the driver needs to modify the queue state in time according to the actual situation. Fixes: 9ad9ff476cac ("ethdev: add queue state in queried queue information") Signed-off-by: Jie Hai Acked-by: Ferruh Yigit --- drivers/net/af_xdp/rte_eth_af_xdp.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c index b6ec9bf490..738f4158e0 100644 --- a/drivers/net/af_xdp/rte_eth_af_xdp.c +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c @@ -672,7 +672,13 @@ eth_af_xdp_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) static int eth_dev_start(struct rte_eth_dev *dev) { + uint16_t i; + dev->data->dev_link.link_status = RTE_ETH_LINK_UP; + for (i = 0; i < dev->data->nb_rx_queues; i++) { + dev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED; + dev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED; + } return 0; } @@ -681,7 +687,14 @@ eth_dev_start(struct rte_eth_dev *dev) static int eth_dev_stop(struct rte_eth_dev *dev) { + uint16_t i; + dev->data->dev_link.link_status = RTE_ETH_LINK_DOWN; + for (i = 0; i < dev->data->nb_rx_queues; i++) { + dev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED; + dev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED; + } + return 0; } -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-10-22 22:17:38.245087200 +0800 +++ 0107-net-af_xdp-fix-Rx-and-Tx-queue-state.patch 2023-10-22 22:17:34.376723700 +0800 @@ -1 +1 @@ -From 9a204f7e4e86d8270cae3cdec2b7949f5954fde2 Mon Sep 17 00:00:00 2001 +From b4078f8a6b8bdc098df5dddf181a029510d42a14 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 9a204f7e4e86d8270cae3cdec2b7949f5954fde2 ] @@ -14 +16,0 @@ -Cc: stable@dpdk.org @@ -23 +25 @@ -index c7786cc53a..0cc51223ba 100644 +index b6ec9bf490..738f4158e0 100644 @@ -26 +28 @@ -@@ -694,7 +694,13 @@ eth_af_xdp_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) +@@ -672,7 +672,13 @@ eth_af_xdp_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) @@ -40 +42 @@ -@@ -703,7 +709,14 @@ eth_dev_start(struct rte_eth_dev *dev) +@@ -681,7 +687,14 @@ eth_dev_start(struct rte_eth_dev *dev)