From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28136431D5 for ; Sun, 22 Oct 2023 16:34:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 21D1D4114B; Sun, 22 Oct 2023 16:34:45 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2072.outbound.protection.outlook.com [40.107.96.72]) by mails.dpdk.org (Postfix) with ESMTP id 1E1A94027E for ; Sun, 22 Oct 2023 16:34:43 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HOJS8NQ3xXv2LbygNG7Hnky1iTQDmuVFzjOWmyfNeouh8pkZWsm3pIlyFVhGFgn0owOPFngCm8UzftSqXG0yJxCdSEiVCFX3mAlu9lcPOdJHM5bMA2X9ydJVw1OZT7ca07HF2lx7KDInUB8QOuPi2OpE1a9xFKQPSalzO/FdOrAVZiKAp1jKBHB0TlHKtfqhSSJTqJ0mSW9ZzBleVDdp11Hu03YaWKlitKItjL1M2w9aXcL8dh9rOCuJuSxRu/ZsXnBDdciEwtuUOBr3XKSQNF78Y0Ptjxa1VpZ/s+8oifg9uDixQPRLhjr3qLFVxVFr/JKf094V5BFuv0qqMorZhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sKw5UCOzvn4XpBTONt6/ycG7LoJ3pyXpmm7CxzqhdCU=; b=cbsrgGTS5IfIXlqqnn8UxWsZwP9qlpWSF3GDEn9Uxvw+yIgMRaI+G8HlEmv6a7MZtBdcMl1IDY+EqMM/B6sKmkPIlMlxTySO8+A4EUqvP3RpdP+DpnHPx0Ee3mfUy1+vsfNHIiLl/cj/J7jrt2vs8yQpZbYJ/JTbap8uH2XvjZfoy+2NwPaJb8NQ6Zp7rZnXw7AWcirPAedLexp1ttmwA5DU1lTKOpudP4wHwM31ixwUGT9pvM+URqj+D06nBFvK7BVSOx30EX/ge2lobkk+a+JgbB6sOgBrFmW9bOcDhljPzKcFKEUzfSYAzajrpMyISKge8nGcmv0zU/t2bk8uuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=huawei.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sKw5UCOzvn4XpBTONt6/ycG7LoJ3pyXpmm7CxzqhdCU=; b=bAOYgMsR/yGYZvXCwvolzJ5+sAy6DJe8twExz+jA9Vvczef6sR3UetXTRx3Myh7bAFwGHpbGNiCazKq6C77eY7b0A6m6+e7Ly8HXHDdNa+Cn21Q6uI3sDQ1m7tvNYymZkVvcG3wUlkCGuhLRbCCjh4JgmBQqPGPFT2M1DU/TtfGT74GCmTap/wPLHK4Ft8L9sQUsjpryiPHT+EL/+YaLASrXiD7ZoT9TGsrKBGy2mGMWaeGdojCTIIZhyjIi73hOGvsVQPACkrH1NZXkAewA9mjO78k7o6pJ0xOkrOXWpkAtyWpzyc5ITW6zGwNmI3BrVK68FbbXLKRrSTD7YCCm5w== Received: from CH2PR07CA0019.namprd07.prod.outlook.com (2603:10b6:610:20::32) by LV2PR12MB6015.namprd12.prod.outlook.com (2603:10b6:408:14f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.26; Sun, 22 Oct 2023 14:34:41 +0000 Received: from CY4PEPF0000EE32.namprd05.prod.outlook.com (2603:10b6:610:20:cafe::e8) by CH2PR07CA0019.outlook.office365.com (2603:10b6:610:20::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.31 via Frontend Transport; Sun, 22 Oct 2023 14:34:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000EE32.mail.protection.outlook.com (10.167.242.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.15 via Frontend Transport; Sun, 22 Oct 2023 14:34:40 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 22 Oct 2023 07:34:27 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 22 Oct 2023 07:34:25 -0700 From: Xueming Li To: Jie Hai CC: Ferruh Yigit , dpdk stable Subject: patch 'net/sfc: fix Rx and Tx queue state' has been queued to stable release 22.11.4 Date: Sun, 22 Oct 2023 22:22:41 +0800 Message-ID: <20231022142250.10324-133-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231022142250.10324-1-xuemingl@nvidia.com> References: <20231022142250.10324-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE32:EE_|LV2PR12MB6015:EE_ X-MS-Office365-Filtering-Correlation-Id: efa59771-704e-442f-b1b4-08dbd30c066b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4BsxvCqRfnyYYJqLO4LFUQrkSebBfBUsc9yIbagTGeh5qfia0yWdximVKRJ6QXNaQRNX9rH4WNllwTv2DUd5Z7Xf4m2kV007HwyK3ZGeV4a4uvO4CKNAqc3hpZD+A6sGX/DYQ2ajVChoLuNUubXp7p9QOAeOhnKLfIAQ4XNkUh3GrKcxQx1mNQdUNDABD/CIEaPws6uPTi0I9ek1GDvb8vC5xcz05E+mj9b1Ac9xDhUFlPzj1C3Kzp2aD0sRicxv7LeKJRiXdcN4Xi3QQuyf9kN2Gn3gEGvu798hGfmfOT6CkJWAnIbE5hQgxaCPaJWeCypFgW46xWT7SF1q3K71wIPwzv3BXg+BY07wCg3Ji8bIQawOApOc3QZuUhJ4YXSZNOT1i2OpgzF+etxg/DfG4wN2efYNtT/Vuhq8qadIFAZ+NGJ2AFPTcrVKZKKN+PbPSAdwSSTpigFwMzUkRNxjtKZ1dfrXJo+jG9mynFUx8IwHk8wsdCtAWcQYl59YsZda4D6htP2FHaXMHY43GuiITIXCidBm9jM1dXUcyjsY4tZtnDKviVmDifYUqaAaKW6NQd7qxpFO5y5w0CRI5GkOdDwTc7MtxYs1AQjbT1wNLWHPDFFTsW400bv7GJ22gog/SkKNdUkMcqsi92Wjo6oXPvyTn2SNsyInrzR0moXk+2+kjm7FyDx7KRU7IZvoUykLQRtQ8bxFCW6R0GNv8YL3NQDuwi3DjNTkVa36nHHsyKdbW5GcOvV8+hr9nwq6OhDOth1Gj+gWqXwEiBGrIUx0uozBNSkGAfNU2tW7UJhjY+g= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(376002)(39850400004)(136003)(396003)(346002)(230922051799003)(64100799003)(451199024)(186009)(82310400011)(1800799009)(36840700001)(46966006)(40470700004)(40460700003)(55016003)(47076005)(41300700001)(2906002)(36756003)(5660300002)(4001150100001)(4326008)(8676002)(86362001)(356005)(26005)(426003)(7696005)(83380400001)(1076003)(6286002)(7636003)(336012)(36860700001)(2616005)(53546011)(16526019)(82740400003)(40480700001)(19627235002)(8936002)(6666004)(966005)(478600001)(6916009)(70586007)(70206006)(54906003)(316002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2023 14:34:40.2440 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: efa59771-704e-442f-b1b4-08dbd30c066b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE32.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB6015 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/15/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=8ab4f361b051feeea2db87e1c9b09f65f5d05718 Thanks. Xueming Li --- >From 8ab4f361b051feeea2db87e1c9b09f65f5d05718 Mon Sep 17 00:00:00 2001 From: Jie Hai Date: Fri, 8 Sep 2023 19:28:55 +0800 Subject: [PATCH] net/sfc: fix Rx and Tx queue state Cc: Xueming Li [ upstream commit 35ac4f275f37d6002ed62e78342af96b9cf7e1e7 ] The DPDK framework reports the queue state, which is stored in dev->data->tx_queue_state and dev->data->rx_queue_state. The state is maintained by the driver. Users may determine whether a queue participates in packet forwarding based on the state. Therefore, the driver needs to modify the queue state in time according to the actual situation. Fixes: 9ad9ff476cac ("ethdev: add queue state in queried queue information") Signed-off-by: Jie Hai Acked-by: Ferruh Yigit --- drivers/net/sfc/sfc_repr.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/net/sfc/sfc_repr.c b/drivers/net/sfc/sfc_repr.c index b3a41167fb..79025e9052 100644 --- a/drivers/net/sfc/sfc_repr.c +++ b/drivers/net/sfc/sfc_repr.c @@ -291,6 +291,7 @@ static int sfc_repr_dev_start(struct rte_eth_dev *dev) { struct sfc_repr *sr = sfc_repr_by_eth_dev(dev); + uint16_t i; int ret; sfcr_info(sr, "entry"); @@ -302,6 +303,11 @@ sfc_repr_dev_start(struct rte_eth_dev *dev) if (ret != 0) goto fail_start; + for (i = 0; i < dev->data->nb_rx_queues; i++) + dev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED; + for (i = 0; i < dev->data->nb_tx_queues; i++) + dev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED; + sfcr_info(sr, "done"); return 0; @@ -366,6 +372,7 @@ static int sfc_repr_dev_stop(struct rte_eth_dev *dev) { struct sfc_repr *sr = sfc_repr_by_eth_dev(dev); + uint16_t i; int ret; sfcr_info(sr, "entry"); @@ -380,6 +387,11 @@ sfc_repr_dev_stop(struct rte_eth_dev *dev) sfc_repr_unlock(sr); + for (i = 0; i < dev->data->nb_rx_queues; i++) + dev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED; + for (i = 0; i < dev->data->nb_tx_queues; i++) + dev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED; + sfcr_info(sr, "done"); return 0; -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-10-22 22:17:39.087972900 +0800 +++ 0132-net-sfc-fix-Rx-and-Tx-queue-state.patch 2023-10-22 22:17:34.416723700 +0800 @@ -1 +1 @@ -From 35ac4f275f37d6002ed62e78342af96b9cf7e1e7 Mon Sep 17 00:00:00 2001 +From 8ab4f361b051feeea2db87e1c9b09f65f5d05718 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 35ac4f275f37d6002ed62e78342af96b9cf7e1e7 ] @@ -14 +16,0 @@ -Cc: stable@dpdk.org @@ -23 +25 @@ -index 5f93192522..c2e5d4eb9e 100644 +index b3a41167fb..79025e9052 100644 @@ -26 +28 @@ -@@ -263,6 +263,7 @@ static int +@@ -291,6 +291,7 @@ static int @@ -34 +36 @@ -@@ -274,6 +275,11 @@ sfc_repr_dev_start(struct rte_eth_dev *dev) +@@ -302,6 +303,11 @@ sfc_repr_dev_start(struct rte_eth_dev *dev) @@ -46 +48 @@ -@@ -338,6 +344,7 @@ static int +@@ -366,6 +372,7 @@ static int @@ -54 +56 @@ -@@ -352,6 +359,11 @@ sfc_repr_dev_stop(struct rte_eth_dev *dev) +@@ -380,6 +387,11 @@ sfc_repr_dev_stop(struct rte_eth_dev *dev)