From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2203431D5 for ; Sun, 22 Oct 2023 16:35:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E6F5240A89; Sun, 22 Oct 2023 16:35:32 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2088.outbound.protection.outlook.com [40.107.94.88]) by mails.dpdk.org (Postfix) with ESMTP id 49E26402D0 for ; Sun, 22 Oct 2023 16:35:31 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hAsviTvqtKmS5XgLtIpRtxvpm7csc7RHh3gLotF/PsI2pJSRHe6+D1qrBpJBcULJAQBD/ehrZ9OKlvd7d98BML3jhIPXBPArmrqFGYx+K7FHLOuRaMTtR1r5P057SshLPyEm6DkPnrWJR7sqJWCOfz1tdIXFxoQ+VDZqVbEGj4lSq2DFXqJlyCIQAtdKCINoBELvKmEbuw0ULinUsDhCXVD/0GIaMhr/MDKblOCJbvWSsUWr7ZftQpIPLRyLqNI2nafQb+QfcYTgpO3DrbiR2QyDs+eN1iwlv7vYhPTZXbolwWz5XuZ7babN7TaJ1s8NpBwj3DuLIhn3A8j1XZbUxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EfRCh18RTSuNLsNCIzIai53XEIYrAseqS15q9CnZ86Y=; b=Hc0ElbZkUJ9LqHHM2+yUzEd+GmWEICcJ5t/VQsMhfKOqFXHF7dApisQ4J+pQCsqO/KETRIeQag8RdMNdPHFdNZ1HwA2xnnhY93ICpMduL1abY2YjDT97UP7sH5SZsC8ZplQLDiX+stwgT7T+Pvp8wTAyVP3KwE2f9EpMGG8TgPTEsU2i9s1GP20JFVuQmQMbvxytbVppax5eUeVnxPDQGmIUsIuQ/OzWFJblEUONz18jortQjbN4lfoAjEaw96v1084zqJry/JKjFCqKm9lgWieIxPlyCpi6pd1yXpXiYZHaD3wKSYB179RsYSvuzzz2SQ0y6WO/+jMUd+F4h8+cAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EfRCh18RTSuNLsNCIzIai53XEIYrAseqS15q9CnZ86Y=; b=crFAKPB3x85RDwamJPC9f7fgMMsDVA4eGec/xKLUCNJAcXCl04yu6Wu9KzjSmnL6YMBSIOwaAI7vBXpALNf07z3gEmZ1h9nM9MkjWdOsjaH1JT3hixIHolcly/qOYpMGmYeWtCD1hkaMCcywqUGhySNs6xSVckeGZiymWIV5dzTIfoJWrWCk2k6g6CPRdPMra4nhU7OzKrypunLssKFoWO9zBaO779Z3eCCSSwmFfzfeAH9c5IuDzO4vhWLQQry8CklN8fVdN4VZ5KY+VUZyE6LNkCe9+mIOfm23gotLFWyZidy0la6IEl8vQpn30p4HdHIhedscWT484snhIGNcvg== Received: from CY5P221CA0126.NAMP221.PROD.OUTLOOK.COM (2603:10b6:930:1f::10) by IA1PR12MB6162.namprd12.prod.outlook.com (2603:10b6:208:3ea::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.24; Sun, 22 Oct 2023 14:35:28 +0000 Received: from CY4PEPF0000E9D6.namprd05.prod.outlook.com (2603:10b6:930:1f:cafe::3e) by CY5P221CA0126.outlook.office365.com (2603:10b6:930:1f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.27 via Frontend Transport; Sun, 22 Oct 2023 14:35:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000E9D6.mail.protection.outlook.com (10.167.241.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.15 via Frontend Transport; Sun, 22 Oct 2023 14:35:28 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 22 Oct 2023 07:35:15 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 22 Oct 2023 07:35:13 -0700 From: Xueming Li To: Suanming Mou CC: Ori Kam , dpdk stable Subject: patch 'ethdev: add check in async flow action query' has been queued to stable release 22.11.4 Date: Sun, 22 Oct 2023 22:22:49 +0800 Message-ID: <20231022142250.10324-141-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231022142250.10324-1-xuemingl@nvidia.com> References: <20231022142250.10324-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D6:EE_|IA1PR12MB6162:EE_ X-MS-Office365-Filtering-Correlation-Id: 78f5cc70-e597-41fd-c6da-08dbd30c231a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jP4gd0bP3DFs5askoetWASVa0ki9ul1bjhT+OJthdqtVDCc7zPzFdEVcfXfCIHYtzCc7Sw6bDygFmg0HUVp/GLGzzw7wutSQRudZ++FE1sa688Jhj8Ls6TW81ImhKfQl423UEyGiz30UXejiRCFOW44gC/HR2wESa2vBJl1hUaGOAVbWE1nVynwEgurAZpnyUUOiOcN1/LJ8HyRxEP1qA0wh477uYORufB1trRNlc/hkNCqqrMfZBUmw6yy84/u2I7CyFwvxNkp1I0GVM/OcCiA1n0SUYqW3IvV0u6exlYvZhsroowvUq3MQ3mvLOf2v5FwuoTLpVcqsbYwgoaSPBeVlJPa5V/KVJTG5X0mHD2KydxIy4BkwUeX63Mxi7ngsGDAxqgeJn1TREx4WejH1YxOPf5rJxEiCN2NWfuHu5gGPzI+DEY6+OzTDFYCsUvfsRVLYrOv7MSDC7kDmMB9OFI/EenfZkO8ZmaLl29sxDSbMFzV9PH35asE+HqE0+z9e0RJPvSgxZrIh8h9nXjOIf0VKXM6D2cARuv8ImbjJ5h3yNAe+u7+iFrLNM1mIlV+fPMO38H1rCg2BOeoGgvIo6UXizsmPr+cF73IhHINiMlelfv7zTwxbQLG4qSRO7KJpS9z+bbbpSwmoyRXnbrr1zZ0CJqlW1aJJkds17XGFA4S1F+Ali6sC0bYolPrZa+d317W2/Od5ViUCgQtyCnP3NvRzj3v/ghtFB/LDnopfDz0Zq6m4mj7iVj2Q0BGF7WJe X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(39860400002)(376002)(136003)(346002)(396003)(230922051799003)(64100799003)(82310400011)(451199024)(186009)(1800799009)(36840700001)(46966006)(426003)(16526019)(336012)(26005)(6286002)(1076003)(2616005)(2906002)(8936002)(4326008)(6862004)(36756003)(5660300002)(86362001)(8676002)(7636003)(40480700001)(55016003)(82740400003)(36860700001)(47076005)(7696005)(53546011)(4001150100001)(966005)(356005)(70206006)(6636002)(70586007)(6666004)(54906003)(41300700001)(37006003)(316002)(478600001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2023 14:35:28.3676 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 78f5cc70-e597-41fd-c6da-08dbd30c231a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D6.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6162 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/15/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=c20753f52ff8f3485f60595827ed24abd00a7c66 Thanks. Xueming Li --- >From c20753f52ff8f3485f60595827ed24abd00a7c66 Mon Sep 17 00:00:00 2001 From: Suanming Mou Date: Tue, 17 Oct 2023 16:23:17 +0800 Subject: [PATCH] ethdev: add check in async flow action query Cc: Xueming Li [ upstream commit a5ea57ac0d29a56400315a2acc7c58799b564367 ] This commit adds the ops check to fix the coverity issue. Coverity issue: 403258 Fixes: c9dc03840873 ("ethdev: add indirect action async query") Signed-off-by: Suanming Mou Acked-by: Ori Kam --- lib/ethdev/rte_flow.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c index 1a67a987f5..2eadb0a032 100644 --- a/lib/ethdev/rte_flow.c +++ b/lib/ethdev/rte_flow.c @@ -1887,6 +1887,8 @@ rte_flow_async_action_handle_query(uint16_t port_id, const struct rte_flow_ops *ops = rte_flow_ops_get(port_id, error); int ret; + if (unlikely(!ops)) + return -rte_errno; ret = ops->async_action_handle_query(dev, queue_id, op_attr, action_handle, data, user_data, error); return flow_err(port_id, ret, error); -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-10-22 22:17:39.351782600 +0800 +++ 0140-ethdev-add-check-in-async-flow-action-query.patch 2023-10-22 22:17:34.436723700 +0800 @@ -1 +1 @@ -From a5ea57ac0d29a56400315a2acc7c58799b564367 Mon Sep 17 00:00:00 2001 +From c20753f52ff8f3485f60595827ed24abd00a7c66 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit a5ea57ac0d29a56400315a2acc7c58799b564367 ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org @@ -19 +21 @@ -index 874f845513..3a67f1aaba 100644 +index 1a67a987f5..2eadb0a032 100644 @@ -22 +24 @@ -@@ -2226,6 +2226,8 @@ rte_flow_async_action_handle_query(uint16_t port_id, +@@ -1887,6 +1887,8 @@ rte_flow_async_action_handle_query(uint16_t port_id, @@ -30 +32 @@ - ret = flow_err(port_id, ret, error); + return flow_err(port_id, ret, error);