From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4FA7431D5 for ; Sun, 22 Oct 2023 16:24:48 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CE312402EC; Sun, 22 Oct 2023 16:24:48 +0200 (CEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2071.outbound.protection.outlook.com [40.107.102.71]) by mails.dpdk.org (Postfix) with ESMTP id 38F81402C4 for ; Sun, 22 Oct 2023 16:24:47 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VYVCxazgDoAoTt+DP71bm0d1Rowr7ugfSU0nUyrDjMTwxx97abLzkLmbf6bnb+Nsb7CUFYd/WRa9OBViD/RcnfaDigfgTw23VE2vXaX6Vy5R9neNwEM592pfvpCgLJrUDuJ/eHzmsIT7IV8S0cvVk0A/wE/w+ifIFdaPjZENAAl9hR0CbBcTVT1xTfycyClIYliXHsBZfuAPoW8Dn5tfSO2AB2kvwVOtvDqJPdECcrZpazgCYjm5b4dPYRMy/WePtLjKVhmZpNpmU8eWCYR2cLsNsc6ECxmGZMNvFOQ3drahWFSxF2bmrDNDnt9phueJK3PXVWEp6/odpOckkZ43GA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wbkehb1fuqiLbjtqzkrdNukFsFD4Vb4zfOZ5+68I9qA=; b=RwWNq7aW8gJeNh1Md1dlxbXq6Z2sIEblPGULfYdyuQclTE3OEr41LV5HD3A+i7ywtPSZ0jfsXumpiNbsXSMe/zPuhhl4ybAA7XAS1IlUapbCFh2dwdoftz/LPGu2yG6Ns+o/pzGGAqYAoA6k5hXH39z1ck3DGF4bMpO1nhF5u24+Wr48XtR1mIJfCHQgOjalKWqlufPiZklmZ5sIkKAe2qENnxP2fdJVP/nPRq8H1fcWeNeHSMHwqEkcC179SxSrCxFY+s8tusI0Fmxfy8nOrwnJHDOgV4cAcTrXtsWYl1sy7RTQgBNejyPwvMwfukhYcqM4teVqinc8Rpjiit/PDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=networkplumber.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wbkehb1fuqiLbjtqzkrdNukFsFD4Vb4zfOZ5+68I9qA=; b=hzMkOkj6dLGvz0r3BAGYWphffD7X8BfH/+0dq1j29BsqjfHUiuKns63hyMQEysW4nLBUZbooLxdT5rqQu5UzFS/E0gnu4x6DNCqAc+VMkD4i5d/b5iHy0orueQuY5flV6m9BaDhdM5Z7aEqKz52+/Jh+xnsixuLzbmhB1jvborGpX9g0O3USg8ETqzSylgUgYCdTpqr0LXrNdumquaz64F43tG18mXl4n4XFikp03SxRsVOtN+OMXPTJloOslWsvvv7L3i2hola1WwLzDE1mVwo/lB0DHMWjv3RuiGS+wlIFD31m3ESsiC6hguIpm1yuvy3ofMZBeHfpMJ00bbpXfA== Received: from MW4PR04CA0107.namprd04.prod.outlook.com (2603:10b6:303:83::22) by SA1PR12MB7317.namprd12.prod.outlook.com (2603:10b6:806:2ba::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.26; Sun, 22 Oct 2023 14:24:45 +0000 Received: from CO1PEPF000044EF.namprd05.prod.outlook.com (2603:10b6:303:83:cafe::41) by MW4PR04CA0107.outlook.office365.com (2603:10b6:303:83::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33 via Frontend Transport; Sun, 22 Oct 2023 14:24:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1PEPF000044EF.mail.protection.outlook.com (10.167.241.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.15 via Frontend Transport; Sun, 22 Oct 2023 14:24:44 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 22 Oct 2023 07:24:36 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 22 Oct 2023 07:24:34 -0700 From: Xueming Li To: Stephen Hemminger CC: =?UTF-8?q?Morten=20Br=C3=B8rup?= , =?UTF-8?q?Mattias=20R=C3=B6nnblom?= , "dpdk stable" Subject: patch 'random: initialize state for unregistered non-EAL threads' has been queued to stable release 22.11.4 Date: Sun, 22 Oct 2023 22:20:48 +0800 Message-ID: <20231022142250.10324-20-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231022142250.10324-1-xuemingl@nvidia.com> References: <20231022142250.10324-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044EF:EE_|SA1PR12MB7317:EE_ X-MS-Office365-Filtering-Correlation-Id: ff71a5f2-e558-40f5-cf20-08dbd30aa36d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ms084XOj1L7hI0hkzBi2j56TuIlytbURsP/e7Kc92+/iEHi2sNO/e1r+3A+wuHRTriIPKaUGWc76ElHjB8iP1E+vJUoRjfO4nYrud6+ihB9PWxsJbjXbgoUy0q47l2MPDl58HX7RV9OfbldJZDMSy31eVDj5XFAEbIj3XBd2vM+QuY6Bp+2fqZ3vaSM11e3fYltUWwL/DlgB+S3E2z0EEzCfhWSL8fNmy4JiiodxtMCMuXa8yo4rwpe9cXegmFN0rlPkLvdkK6xUO5JeU62CnNma/sEQuHwB59KK4QtGJEUbtHBIbSf4GvN4vvTS/0VLn9UrH5DBgleCv070aeNANyCUyF2EPRrlEhT8Go0Rg6yEKEVf9GvPLDcX03gIr97l6S1w+Jpyz6dKhCIInv9gtCzJbtRKWa3NwIfQk+g6hfZimxoEpMV2kY0o0fgqLdpMLkj27BchBBEAaoTN/IXAEwS/JLsS1Nrzx0DkSmb69hIGrvQTBgPTdJMUYCuu/3ni1ttDGd/gOlQwNrBS4DwbSCumEBh57TlhKMvQBUNtAhV4avODFweo/kyM+7eLNmUHZlGi2YlvrmAzjWqubpj9BHECcvU3gTS4hWQA7zd2aAe+LS5dcVd7J0Q834vDhnjOmoFdMCd7QhpqJ6ZDUi0gNMREWLvNubNOzArmS5/qehtXhpruoTDlxgWl78DeMT5nNx76QHUTAQitA3nAe13i809oBQYCUvb8QcKgYOWBXl2o3HxkOimo7fEu9UM1H5ObIdSIwc3p2iSRtG62Lozwg+t5KmxcHGQ7zksIbEv44X8= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(346002)(136003)(396003)(376002)(39860400002)(230922051799003)(1800799009)(82310400011)(64100799003)(186009)(451199024)(40470700004)(46966006)(36840700001)(478600001)(70586007)(966005)(70206006)(53546011)(6666004)(7696005)(5660300002)(6916009)(316002)(54906003)(55016003)(40480700001)(36860700001)(82740400003)(47076005)(7636003)(83380400001)(1076003)(426003)(36756003)(6286002)(26005)(4001150100001)(40460700003)(2906002)(336012)(41300700001)(356005)(16526019)(2616005)(8676002)(4326008)(8936002)(66574015)(86362001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2023 14:24:44.7135 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ff71a5f2-e558-40f5-cf20-08dbd30aa36d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044EF.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7317 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/15/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=517bb40874834adb14c9018e5b68a8ec048a970c Thanks. Xueming Li --- >From 517bb40874834adb14c9018e5b68a8ec048a970c Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 7 Sep 2023 08:24:55 -0700 Subject: [PATCH] random: initialize state for unregistered non-EAL threads MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Xueming Li [ upstream commit 3a4e21301c7a8bf709ff9e74d05628f87450a11e ] The per-lcore PRNG was not initializing the rand_state of all the lcores. Any usage of rte_random by an unregistered non-EAL thread would use rand_states[RTE_MAX_LCORE] which was never initialized. Fix by using RTE_DIM() which will get all lcores. Fixes: 3f002f069612 ("eal: replace libc-based random generation with LFSR") Signed-off-by: Stephen Hemminger Reviewed-by: Morten Brørup Acked-by: Mattias Rönnblom --- lib/eal/common/rte_random.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/eal/common/rte_random.c b/lib/eal/common/rte_random.c index 166b0d8921..ac1bf6c6ee 100644 --- a/lib/eal/common/rte_random.c +++ b/lib/eal/common/rte_random.c @@ -79,7 +79,7 @@ rte_srand(uint64_t seed) unsigned int lcore_id; /* add lcore_id to seed to avoid having the same sequence */ - for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) + for (lcore_id = 0; lcore_id < RTE_DIM(rand_states); lcore_id++) __rte_srand_lfsr258(seed + lcore_id, &rand_states[lcore_id]); } -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-10-22 22:17:35.147981400 +0800 +++ 0019-random-initialize-state-for-unregistered-non-EAL-thr.patch 2023-10-22 22:17:34.156723700 +0800 @@ -1 +1 @@ -From 3a4e21301c7a8bf709ff9e74d05628f87450a11e Mon Sep 17 00:00:00 2001 +From 517bb40874834adb14c9018e5b68a8ec048a970c Mon Sep 17 00:00:00 2001 @@ -7,0 +8,3 @@ +Cc: Xueming Li + +[ upstream commit 3a4e21301c7a8bf709ff9e74d05628f87450a11e ] @@ -16 +18,0 @@ -Cc: stable@dpdk.org @@ -26 +28 @@ -index 53636331a2..812e5b4757 100644 +index 166b0d8921..ac1bf6c6ee 100644 @@ -29 +31 @@ -@@ -84,7 +84,7 @@ rte_srand(uint64_t seed) +@@ -79,7 +79,7 @@ rte_srand(uint64_t seed)