From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF618431D5 for ; Sun, 22 Oct 2023 16:25:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A8C5F40689; Sun, 22 Oct 2023 16:25:10 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2061.outbound.protection.outlook.com [40.107.95.61]) by mails.dpdk.org (Postfix) with ESMTP id 1B04D402C4 for ; Sun, 22 Oct 2023 16:25:09 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WFrHG/6EBUs9zatYZmVxoJyFGlcBwEH1IeFVb4WJSAk736NSsIOORslmvCU5n4GPgiAFsGhUmEB1z/3m2ouM1pRr7orSQsWoeHo3A2mlMYA4I0gd7nt+uyKHfJxzzcCyGv84XN/rBfX7ff3XjMfNFv3nTGGCrhOpxQenKK4WTLh6rkveKOmoHfsRTLkZuODAP4usKVGUXTj6gAKUEq6+hv3utaA/zwIkaXWzrrSq+5D8ecqJGR03MDARXncDrvfT+S1xxHcCFzR1vzTHg89bZTJUkzWiOtoTV1z1TTtwEiGWyc6mYhcxACfBpIYQF0RaxaB3BL7Y3dEqSs3FBUHJeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KIHTXlz02oGirgjtbf8qfAPUz/+wBMD+m+SFGeeBKfE=; b=G9DGDcFGATxcUJwyJF5uOFHGT/5y41926tfJZ2647wrX/tqzB20it4/rBTELoI6KC5Maau1gf09/qxSVbPBeaVyfxep+lgMUGl1RvOvcNVBCMBA9+BJE9yvD6ULDZ3lCA0aVbT1X9esqt9LmvBv8L5042KvsVaZacsVPI5tHlOCCNMVqwv15bURkVWXzd4UR5czszLEJ4VcgNQam+IAJh4rqVbiAaofLXV+kHuEEbxGvPVcBjEaCNjmB/weOBBZe9OmBhDGXusgvVj7bLYPIKSaCQLpxBrAKf8stsHvH994NXVXcNpfpLs35aQ+y6Ml3V6cQorn1/xwZ0XQzddhDlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=nxp.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KIHTXlz02oGirgjtbf8qfAPUz/+wBMD+m+SFGeeBKfE=; b=BqmxAJ1jI0IzuiXumT/TZqAONN/oC1dogkxLBTU0iMi5aTEOux9v4UNNdBkb0PPGlcglsOpAyiEu/m+2FKO/W3nuNX2j8fjJHQ568NdMKcH/6PuyrWxvYTSHnsbeBP3JnrQbLAoSoUVnG68tFUqA+/Q8VtgNnUl6SQb3EZSzkM9Uh73xmNcB37od+77AMLnyFjvNiVPPgy3p09Ke24emQZxM22wMCQRJ3tdfHxWZ20QYmxYv4p2AFaDlDL99KuLe38DO/OHbHPH1Pn73e42u+8N5X6ESrbKDU7e00o9y9walTrxi+J+sL8mL1YD33p4FEjta2XprZo9jVIzPas8aow== Received: from MW4PR04CA0332.namprd04.prod.outlook.com (2603:10b6:303:8a::7) by SJ0PR12MB5437.namprd12.prod.outlook.com (2603:10b6:a03:302::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.29; Sun, 22 Oct 2023 14:25:05 +0000 Received: from CO1PEPF000044F2.namprd05.prod.outlook.com (2603:10b6:303:8a:cafe::b5) by MW4PR04CA0332.outlook.office365.com (2603:10b6:303:8a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33 via Frontend Transport; Sun, 22 Oct 2023 14:25:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1PEPF000044F2.mail.protection.outlook.com (10.167.241.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.15 via Frontend Transport; Sun, 22 Oct 2023 14:25:04 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 22 Oct 2023 07:24:55 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 22 Oct 2023 07:24:53 -0700 From: Xueming Li To: Gagandeep Singh CC: Hemant Agrawal , Jerin Jacob , dpdk stable Subject: patch 'bus/dpaa: fix build with asserts for GCC 13' has been queued to stable release 22.11.4 Date: Sun, 22 Oct 2023 22:20:49 +0800 Message-ID: <20231022142250.10324-21-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231022142250.10324-1-xuemingl@nvidia.com> References: <20231022142250.10324-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044F2:EE_|SJ0PR12MB5437:EE_ X-MS-Office365-Filtering-Correlation-Id: f7b086ea-76b8-4f81-6b30-08dbd30aaf7b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OceySsrsZvPNWQabfBAqFRazkCk4znAxwMe9cMVBVcNVGBVYs+WdjL2/ULF0S+cap9c6UY/cquO/bZpWmdixMg88310RIHbJvZmH+05ZqA/qrkQld1aqnW8Pot2YXLCR2an1S+R9iYAZ18NpV9OJUMzCr8vP+ePiqNu78DnUkOtyG/4cgnohDKYNhwSiiIzStypWqZwwE+q/d77lcGRhdAKZwTByrhucoSs0Y8AtQnWui/x6tfA5wdiKY3QJl1jP0UfnYCw3GBPibURXgKuuxzbSF7I44jYNVn4M4IjXK6LYEYw+Hs34EFhocvNRf2I+cpRMcYTo8zg4fGmwoKZKGb774BbPiPkUXL4173U1NNcI1hqQ728k9hoaL4qTq45f1Ot1xyCNpi3GI53syUsxuGrWX61AJuZfGY2FVxXqxutnGpnHZHGRuwJH9YmfBtUXLza+zFoXbGbqKBPeS06i4omp8q1Jslr+HDDGTRLejDvLg+HuPHv5odZrQpxrUQy42bnc2uCDJCchIAo349gVDdobRayykkiNWXJZy0mIa5Fak5+IlGZIpOnxBFnel5OoTErNPU+05APyG+ZYm+LdI8Z669pscBBPZwGOBItdIZzOF7CGPZZ92p5Iao4uX9tmhhCQAbfVMY0CNwMJfdep/nJIq2ejncWcx8Wq6/MmYV6lxJEXkT58ruw2igUC00CJmWIrp5KmWaqPF5zqLSf5u1mhyKFHY3jV8eZ4MPrRUhaihqwpSw9ZwqX0LSk5wwcmfK85LdTcI1qvRWS6DV8F1mKgpRM1iHwsT6Hly+E75ss= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(376002)(39850400004)(136003)(396003)(346002)(230922051799003)(186009)(82310400011)(451199024)(1800799009)(64100799003)(46966006)(40470700004)(36840700001)(6286002)(4001150100001)(26005)(2906002)(55016003)(36860700001)(41300700001)(40460700003)(86362001)(5660300002)(36756003)(8676002)(8936002)(4326008)(2616005)(356005)(478600001)(6666004)(7696005)(16526019)(7636003)(1076003)(82740400003)(54906003)(316002)(70206006)(70586007)(6916009)(53546011)(83380400001)(966005)(40480700001)(426003)(336012)(47076005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2023 14:25:04.8729 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f7b086ea-76b8-4f81-6b30-08dbd30aaf7b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044F2.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5437 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/15/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=e55de889b7ffc4b604b4dd05f62b93cbdc8cd298 Thanks. Xueming Li --- >From e55de889b7ffc4b604b4dd05f62b93cbdc8cd298 Mon Sep 17 00:00:00 2001 From: Gagandeep Singh Date: Fri, 21 Jul 2023 10:58:10 +0530 Subject: [PATCH] bus/dpaa: fix build with asserts for GCC 13 Cc: Xueming Li [ upstream commit 3bcd5b3198d4a31176b1ac73fc7236a12186fffe ] when RTE_ENABLE_ASSERT is enable, DPAA driver is doing wrong NULL check on frame queue which allows the code to have access to NULL address. GCC v13 is giving array bounds error if code is accessing any memory region less than 4KB. This patch fixes this issue by adding proper NULL checks on frame queue. Bugzilla ID: 1233 Fixes: c47ff048b99a ("bus/dpaa: add QMAN driver core routines") Signed-off-by: Gagandeep Singh Acked-by: Hemant Agrawal Acked-by: Jerin Jacob --- drivers/bus/dpaa/base/qbman/qman.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/bus/dpaa/base/qbman/qman.c b/drivers/bus/dpaa/base/qbman/qman.c index 3949bf8712..83db0a534e 100644 --- a/drivers/bus/dpaa/base/qbman/qman.c +++ b/drivers/bus/dpaa/base/qbman/qman.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0) * * Copyright 2008-2016 Freescale Semiconductor Inc. - * Copyright 2017,2019 NXP + * Copyright 2017,2019-2023 NXP * */ @@ -897,7 +897,7 @@ mr_loop: /* Lookup in the retirement table */ fq = table_find_fq(p, be32_to_cpu(msg->fq.fqid)); - DPAA_BUG_ON(!fq); + DPAA_BUG_ON(fq != NULL); fq_state_change(p, fq, &swapped_msg, verb); if (fq->cb.fqs) fq->cb.fqs(p, fq, &swapped_msg); @@ -909,6 +909,7 @@ mr_loop: #else fq = (void *)(uintptr_t)msg->fq.contextB; #endif + DPAA_BUG_ON(fq != NULL); fq_state_change(p, fq, msg, verb); if (fq->cb.fqs) fq->cb.fqs(p, fq, &swapped_msg); -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-10-22 22:17:35.181718800 +0800 +++ 0020-bus-dpaa-fix-build-with-asserts-for-GCC-13.patch 2023-10-22 22:17:34.156723700 +0800 @@ -1 +1 @@ -From 3bcd5b3198d4a31176b1ac73fc7236a12186fffe Mon Sep 17 00:00:00 2001 +From e55de889b7ffc4b604b4dd05f62b93cbdc8cd298 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 3bcd5b3198d4a31176b1ac73fc7236a12186fffe ] @@ -16 +18,0 @@ -Cc: stable@dpdk.org