From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 50D10431D5 for ; Sun, 22 Oct 2023 16:26:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4A19A406B7; Sun, 22 Oct 2023 16:26:05 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2071.outbound.protection.outlook.com [40.107.94.71]) by mails.dpdk.org (Postfix) with ESMTP id B98EA402C0 for ; Sun, 22 Oct 2023 16:26:03 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E+EtjcKnc+JX5fEt8VJcxQhtdW0NmnNqRLaMX4ptY9lle2u5AjXxNKxVasUbV0BajuuNR02FR3Fd1XaTqJtc50ZyLR5V1YdgtjglqKJ9JHMCZeDmG3hV+dy5G4tTJr7IKxQO7tY/STox1LL9P2cPLZ6RG6vhJgpy5+M9AOg2qIxE5MSxafVY2wVRqg/0AbtZl01Md5yDq/3f0Rv38i7+BEjVoLyrk8ulSk6RrzUWnPAyk1VyHaZn0Bb1vz6HE1iupIvMnBxkJqddaAuwu1qz9ALkn+7er3B3f6Q7j3qzDJHobh3dRQPF7s9RDlLQHluabDAU4m2jh5BMAxfwpwXNlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lB2z03mev9le70bOEy/2T8GJ5OZLnKOBd6Y9nCVF6Sk=; b=lTzYvicVw1H6FKV9lSy8YmrU39AWkrzC3O7vHscvLQQJKQLI50tbtm15XGJLRzGuaYUyVS6AwhXQMyHJ738VeAxGt8SyVMoIzt2QyebqpfJJMNJjfcWA5AqIIoZbhC6P2jkNMlPDN+Gq1pxpAjBRNOmhrEh45Y7nj4LbCAVQKn7R9l8tOBKQwF4ekLHHwx29+Xxrp8kI3jKBlMTrWe52QV3d8zEOHv4NvMPMiGswQn6wM6pSozMLixx6/44+dRHGbZP2iVE7y044rEgqFdwdriUYBaTSz6mw234dy5egSe58oQbDycNBPDLoXPNLwGbP7Yw4ndzQCpaD46FMUaJMhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=trustnetic.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lB2z03mev9le70bOEy/2T8GJ5OZLnKOBd6Y9nCVF6Sk=; b=b7ZvvDWhz+fZ1cPATQmuXvKBKAtOefsq9VqvlkIGWTUsdSBamWzlJje5Kk+wCkevbRzDaTUjxljEL+SA+KiWPS3E+Yy0gtN7bUqAdp6nJg8wtSWKbMGA1OsPSc9IVkM6/zljRweLi3TzB9cggwcdHqknm6L+nIg1Dc8uH+BsATydKGLcqfqiiCgfzYNHE/IAmfsJRJcCJYviGzARfoAbtxYJnNMRFIwLCeIaYCjJK6eeet7UjatguJZ7A6GdbuK+7cLeRwncgq8L8h8l9jiSwa0OHHo/osotP6q03oisFmMKCUczpm9uDOdu7OZmVcrmTgF8HAbVwZrVbyI3FWUrUA== Received: from SJ0PR03CA0381.namprd03.prod.outlook.com (2603:10b6:a03:3a1::26) by MW4PR12MB6998.namprd12.prod.outlook.com (2603:10b6:303:20a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.26; Sun, 22 Oct 2023 14:26:01 +0000 Received: from CO1PEPF000044F5.namprd05.prod.outlook.com (2603:10b6:a03:3a1:cafe::b7) by SJ0PR03CA0381.outlook.office365.com (2603:10b6:a03:3a1::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.31 via Frontend Transport; Sun, 22 Oct 2023 14:26:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1PEPF000044F5.mail.protection.outlook.com (10.167.241.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.15 via Frontend Transport; Sun, 22 Oct 2023 14:26:00 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 22 Oct 2023 07:25:51 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 22 Oct 2023 07:25:50 -0700 From: Xueming Li To: Jiawen Wu CC: dpdk stable Subject: patch 'net/txgbe: check process type in close operation' has been queued to stable release 22.11.4 Date: Sun, 22 Oct 2023 22:21:02 +0800 Message-ID: <20231022142250.10324-34-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231022142250.10324-1-xuemingl@nvidia.com> References: <20231022142250.10324-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044F5:EE_|MW4PR12MB6998:EE_ X-MS-Office365-Filtering-Correlation-Id: 6354d3ac-9212-473a-31af-08dbd30ad0c8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TjT1uGwYHiWPJmda9xwQGm7mtI3iwFwrYCGdg4zBewJBQQ16dnMwSJNPJybFpqqOkPBP1HHM41RuK1X+e/s9khUtSvySnU0gjmPxYZlJxesRPZazb1NzHFlKQx5cutgMfDQCCuK8F2iNMulwsVMxalSaNRkKgqMwN4is+QNK3w08/rFPUopGiNNaeDsxYOFRUaCr9NZrlzFZazDCgR/wmG9PgNQlyak9zf6QQSCVsB1BV2TXB8e2Sy5ceRWip0bLgUJlTH1B9O8cG7kgJOejzNDgzHYHKgZ2UnXK8nsZSNY5SG5nLv7eLRBLH+XKSW+kWxpFBEdHQiKGZxaOWxzk41Tn59CDzFJZAs+d1Wf9eUGOUOd2bVCTm3Qlo8jIjhhj05KNX/M04UIBHs8Ke2AexH2x+qk0uqJcdXoXtGsy8oR3BLHae2WFGtVMiU7Lvc1xiPNA6mq9iDaTXk6RBTj8wJQvIEUjefUhRHCDYcn240CtBGJW8JdorhiUUZwfOQka2PK8GdGTnEle0NfpYuY+w1SLwJASvbZCDhKCSrn+nL19kiUDxE99sExBdHme2SoGYHyAk9m8WdgEvCtX3qSln+T0neDGtFfuy0P7ZMKX6fUMb4uhH55q04jbc9ST0zQGjldnOxKG4xRBhYFwYeOa1E3hjpE0Dd0GPSxCPKEdErhWJLq6+R2FBh+xgz9yO39Mhheber/Nv0H2Ai7gjY4nCMM4mxuyt69gTifCpLnLVNVqoZq0E8x4n712cOR5EI5n6w4uRwBh+6Jzg0KY8UP/wiHLJxQMffqxrYIKQaRch2E= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(39860400002)(376002)(136003)(346002)(396003)(230922051799003)(82310400011)(1800799009)(186009)(64100799003)(451199024)(40470700004)(46966006)(36840700001)(70206006)(478600001)(70586007)(966005)(6666004)(53546011)(7696005)(6916009)(5660300002)(316002)(55016003)(40480700001)(7636003)(356005)(47076005)(82740400003)(36860700001)(83380400001)(2616005)(26005)(6286002)(336012)(36756003)(2906002)(40460700003)(41300700001)(1076003)(4001150100001)(4326008)(8676002)(16526019)(8936002)(426003)(86362001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2023 14:26:00.8034 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6354d3ac-9212-473a-31af-08dbd30ad0c8 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044F5.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6998 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/15/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=a340716239dd004589b83e296ce8e0be7700e6ce Thanks. Xueming Li --- >From a340716239dd004589b83e296ce8e0be7700e6ce Mon Sep 17 00:00:00 2001 From: Jiawen Wu Date: Thu, 28 Sep 2023 17:47:56 +0800 Subject: [PATCH] net/txgbe: check process type in close operation Cc: Xueming Li [ upstream commit 21ed282505ed8f60f03a93a27ac01f4152b8ab40 ] The secondary processes are not allowed to release shared resources. Only process-private resources should be freed in a secondary process. Most of the time, there is no process-private resource, so the close operation is just forbidden in a secondary process. Fixes: e1698e383c2a ("net/txgbe: add device init and uninit") Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index 5f596e9ab9..001f8c6473 100644 --- a/drivers/net/txgbe/txgbe_ethdev.c +++ b/drivers/net/txgbe/txgbe_ethdev.c @@ -2039,6 +2039,9 @@ txgbe_dev_close(struct rte_eth_dev *dev) PMD_INIT_FUNC_TRACE(); + if (rte_eal_process_type() != RTE_PROC_PRIMARY) + return 0; + txgbe_pf_reset_hw(hw); ret = txgbe_dev_stop(dev); -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-10-22 22:17:35.646711200 +0800 +++ 0033-net-txgbe-check-process-type-in-close-operation.patch 2023-10-22 22:17:34.196723700 +0800 @@ -1 +1 @@ -From 21ed282505ed8f60f03a93a27ac01f4152b8ab40 Mon Sep 17 00:00:00 2001 +From a340716239dd004589b83e296ce8e0be7700e6ce Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 21ed282505ed8f60f03a93a27ac01f4152b8ab40 ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org @@ -20 +22 @@ -index 2dad820cb5..6bc231a130 100644 +index 5f596e9ab9..001f8c6473 100644 @@ -23 +25 @@ -@@ -2052,6 +2052,9 @@ txgbe_dev_close(struct rte_eth_dev *dev) +@@ -2039,6 +2039,9 @@ txgbe_dev_close(struct rte_eth_dev *dev)