From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18392431D5 for ; Sun, 22 Oct 2023 16:30:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1218B40ED8; Sun, 22 Oct 2023 16:30:23 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2060.outbound.protection.outlook.com [40.107.223.60]) by mails.dpdk.org (Postfix) with ESMTP id 1841340ED0 for ; Sun, 22 Oct 2023 16:30:22 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TMTq5MVZcxtLuYBD4NcmXgkbJgLQQCBz6u5ibbfUOil0850pKTaOByEvK6L+LheXRyu8hTv4n0akuwc8qt/d8IOs39Lr6mQWSjOL2lNH9w4patYup8i+CuFg0qeoP2cXimn/6Wcror3+BSxJMc328en+qfSAJdxGdJXYP0GA+g/Ez8WCqS2ge6o1uZT9Mk2mRn2HLUVhzMwE9RPw1clzc4SWecz7F2QIRbATvk0yC5+ITJvhfcE9jesXfv7DVinZa0RQowqVgdK1268CoaiMI3vh03+2mNZQmlZ748odTohVG0HgaTXiqUKGn8gIi/5XXN+3oc1Fuxagjb6M6SN8eQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Nh4l3wU2xW8UtwlL02ArssMuUu6/GcbStjj3CkTJJcU=; b=dOk7cEG51WedtmvB0kND0vKWk62DbcnX0Us9syd1T1Kjfqz37SIUtsZpQoEapu6Z1VyZxXwh9KbuDRbBE/Q3/yEolPGeSOz7UkcWGGsLkGAjF9wwHMCK2zOJhpGgYyXfzv6CKQIItwSLwxIAKE3+PwjVEYuswogwxaNcyV+ToIIuoARjd5sIsuJ9HOfFxcBzXV7M22Y/7//Na9/3tfUOvj69Pew8OnU52kOBBz3nXbX1M2VAI/wld2j/+34VtmlXFn5ffvVxYYAdRFDVaU+eymTsWvNvCWDAXDV3ij1BRGuPfoZ2uFps/GVs0qOhoLtNpMUIFDbxyPTR6Gl2SpYOFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nh4l3wU2xW8UtwlL02ArssMuUu6/GcbStjj3CkTJJcU=; b=aopqLkx90mn1QeryjLOsW1S+NgqVwbQgYVfWTcUHpmTtnifZ1Cid31UQRIMfFHjibdgyK4hB3c1VkuKCCqWw/OeDUvpkV9TLKcF/r+UWq9qeI5JSwXTmGfUcQ6TVY749K4zl8WJgHJStLkS2V9j++Djw/fTaYokmPUo0jcybANrRzWMU4tu1SIkTJCifPcm6MVqE/a5SaFC8O5+xKEQRHX8qwbz/65lt2Tjwd/LvERDa2EnxRfr2WEYKQ9334XRSYEVwfF3RYilZtWywnLj+chqwLOAWK9p9Jg9/W9G+ozOLKKMeoFxVKptuXDblbFCr5kGpu5lWbTbOhSTleXYayw== Received: from DS7PR05CA0080.namprd05.prod.outlook.com (2603:10b6:8:57::18) by MN0PR12MB5882.namprd12.prod.outlook.com (2603:10b6:208:37a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.45; Sun, 22 Oct 2023 14:30:20 +0000 Received: from DS1PEPF00017093.namprd03.prod.outlook.com (2603:10b6:8:57:cafe::7c) by DS7PR05CA0080.outlook.office365.com (2603:10b6:8:57::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.15 via Frontend Transport; Sun, 22 Oct 2023 14:30:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DS1PEPF00017093.mail.protection.outlook.com (10.167.17.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.15 via Frontend Transport; Sun, 22 Oct 2023 14:30:19 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 22 Oct 2023 07:30:11 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 22 Oct 2023 07:30:09 -0700 From: Xueming Li To: David Marchand CC: Qi Zhang , dpdk stable Subject: patch 'net/iavf: fix checksum offloading' has been queued to stable release 22.11.4 Date: Sun, 22 Oct 2023 22:21:53 +0800 Message-ID: <20231022142250.10324-85-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231022142250.10324-1-xuemingl@nvidia.com> References: <20231022142250.10324-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017093:EE_|MN0PR12MB5882:EE_ X-MS-Office365-Filtering-Correlation-Id: 1217b077-d652-429b-7bc2-08dbd30b6b21 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MZuNW9e+QvqlOeKSlBh+9haSnsngYnBAMYKBN1DK5Bttdn+wjVPj+Ta6fGnXDAQRz+Dai2513dBqIRL7Tl80C3R4SQj3uEOq6q21OlW4CyYRG+y8jd8gzLA/2YL5yFY2qdOCxQlQqYMGwPk94B9zYCX43CqslmQCMaaJPCTB5ABz3RWyrrNU0zpDzQAPBfz54kUSJ28EJJc46s0RpeF1KCxxsKjq7erd75KgwtWbkdECDbGMo/FoyQcAJGN81kYREVWtpntfpz4TGHWoGYLsm9X7zgLFUFdrpS+wpTxs5GZ6YVnXr+klFIe7vt7r+I7+oQLAMD2qROlB2m6e+fsXR7CvKXPtMtD+7pBvS8LB0dUDIgUGvY907U0bkzyXgOlazK5EisAUbdGTIAR54S0WIoMexU0LCCEqIOdDZ4z75zxqrd45lSX6G8CQr9p/m9cMLp8gEFCd/vPkKKBnD6VpD7dDTarvv+29z8PNraVQb0Lh8odDXcanHvECKVdiV1MzeyBm2gXZDdbVdKUQrkWj804Ieby7kO2BaBI/0pwUN/AXBMPFK3bCttJpZUQ/VECD6H8MYuFAxzHq5VBE2TlDx47vyJB8k6eDiIjWLbfTUezpcA0Oei7f1jGmVP4gDWcW9qjCDf+Wfv/jp2Xiw+2L4+f6DqfAdQAfUSbCc69JQbsS9DEbQfWSJfTV4KpG8IyzW/EuFdRfE7HJC+h6hEN0iYpIVgOP82+zNDUXyGsXRvxGtRbfYXxHfjuUgcWoMnhq X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(346002)(39850400004)(396003)(376002)(136003)(230922051799003)(451199024)(64100799003)(82310400011)(186009)(1800799009)(46966006)(36840700001)(55016003)(82740400003)(40480700001)(6286002)(16526019)(2906002)(336012)(26005)(356005)(36756003)(4001150100001)(7636003)(478600001)(1076003)(2616005)(6666004)(41300700001)(8676002)(86362001)(6916009)(426003)(8936002)(5660300002)(70206006)(316002)(54906003)(70586007)(4326008)(966005)(7696005)(53546011)(47076005)(36860700001)(83380400001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2023 14:30:19.7108 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1217b077-d652-429b-7bc2-08dbd30b6b21 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017093.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5882 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/15/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=baaa29889396f58d78dd7d429c8ecf8970b9ca22 Thanks. Xueming Li --- >From baaa29889396f58d78dd7d429c8ecf8970b9ca22 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Wed, 23 Aug 2023 08:29:11 +0200 Subject: [PATCH] net/iavf: fix checksum offloading Cc: Xueming Li [ upstream commit 3c715591ece0771b7a5503ffe5340c6f3cc1cb62 ] l2_len and l3_len fields are related to Tx offloading features. It is undefined in the DPDK API what those fields may contain if an application did not request a Tx offload. Skip reading them if no Tx offloads has been requested. Fixes: 1e728b01120c ("net/iavf: rework Tx path") Signed-off-by: David Marchand Acked-by: Qi Zhang --- drivers/net/iavf/iavf_rxtx.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c index 4a38a7b985..97df9d1699 100644 --- a/drivers/net/iavf/iavf_rxtx.c +++ b/drivers/net/iavf/iavf_rxtx.c @@ -2597,6 +2597,9 @@ iavf_build_data_desc_cmd_offset_fields(volatile uint64_t *qw1, l2tag1 |= m->vlan_tci; } + if ((m->ol_flags & IAVF_TX_CKSUM_OFFLOAD_MASK) == 0) + goto skip_cksum; + /* Set MACLEN */ if (m->ol_flags & RTE_MBUF_F_TX_TUNNEL_MASK && !(m->ol_flags & RTE_MBUF_F_TX_SEC_OFFLOAD)) @@ -2656,6 +2659,7 @@ iavf_build_data_desc_cmd_offset_fields(volatile uint64_t *qw1, break; } +skip_cksum: *qw1 = rte_cpu_to_le_64((((uint64_t)command << IAVF_TXD_DATA_QW1_CMD_SHIFT) & IAVF_TXD_DATA_QW1_CMD_MASK) | (((uint64_t)offset << IAVF_TXD_DATA_QW1_OFFSET_SHIFT) & -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-10-22 22:17:37.434620200 +0800 +++ 0084-net-iavf-fix-checksum-offloading.patch 2023-10-22 22:17:34.316723700 +0800 @@ -1 +1 @@ -From 3c715591ece0771b7a5503ffe5340c6f3cc1cb62 Mon Sep 17 00:00:00 2001 +From baaa29889396f58d78dd7d429c8ecf8970b9ca22 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 3c715591ece0771b7a5503ffe5340c6f3cc1cb62 ] @@ -14 +16,0 @@ -Cc: stable@dpdk.org @@ -23 +25 @@ -index f7df4665d1..33b0f9f482 100644 +index 4a38a7b985..97df9d1699 100644 @@ -26 +28 @@ -@@ -2643,6 +2643,9 @@ iavf_build_data_desc_cmd_offset_fields(volatile uint64_t *qw1, +@@ -2597,6 +2597,9 @@ iavf_build_data_desc_cmd_offset_fields(volatile uint64_t *qw1, @@ -36 +38 @@ -@@ -2702,6 +2705,7 @@ iavf_build_data_desc_cmd_offset_fields(volatile uint64_t *qw1, +@@ -2656,6 +2659,7 @@ iavf_build_data_desc_cmd_offset_fields(volatile uint64_t *qw1,