From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0EA54431D5 for ; Sun, 22 Oct 2023 16:31:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 064D540EE3; Sun, 22 Oct 2023 16:31:18 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2089.outbound.protection.outlook.com [40.107.93.89]) by mails.dpdk.org (Postfix) with ESMTP id ED21A4027E for ; Sun, 22 Oct 2023 16:31:13 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JaXluXJpeS/98NnCzHVVcqHD0+5ysvh/fKrZZNv1t0SDuJwDMG27WCQTyCK93ofBJ36+ldBd0GUBpRqNymLYuF1t2DNBgNPtatKKygxmhAhDWFBFuMtjO1FAEGhyPMd1GHtugefWElKHOj6q/zo7EblYQw6mKDklatRn6LUBuSXNtXriVBF87o01pC+lMcxTXjPQ2wbZ6AO4QChcLHOUjA3K6iWibQRHX+WSJ3kYQMyVedxczGPdTViVqrwTyHSnMrpzStYvrQUnAktzsNDQ61a7dnZaraJwjXYV0iESSxS+whZ8r6G3c0v749vUtzunXm/LHhK6bYW3XLobyn1Nig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p+fJIJuchcirMIGou9Dt4KIwJT3rb4f42RcgbiXrfFA=; b=daOOZz1fvCKjVu0zXuZtKil7xtIoLaO3Uud/OnHVEtB5BSH5U88wpeUb5hjX6hRffzyFgx/zuDO5tw3+paqk0lUoN35MlrXA0+W/Nn2sW9ZFRWxFTzVjbO9PEgu2odfhefY0QkFJhftR9GAgNTYC2F1tR61NSfcXkgZO36DDNrNatXIvy0EvTw5AbsNOLC/OXyNu/cAebTJVBL52E9hNvOIl90j0x6rgbMK45lz9cY8HOYOmL2d8ydNEKJRPNHSeIyFbtOWhSjE7b2z/T3XZU1YMnmldsNMsopD90SPS563J0cQqJl7y4X2+1PY+pFg7K1JmD+Hi88xyd0iJvBnfoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p+fJIJuchcirMIGou9Dt4KIwJT3rb4f42RcgbiXrfFA=; b=o8DDXbsQQLrVCtApZsk8CU544c7Ines3FkhgUd93X4gG51DzOcZ55qZJtEvc7STfPzV+GeG/Whql8cLqMKgpD2vISb0MLeUbpVLz95li6OsgbMwlJOdvjGAGG5jnI2wMRI6IZ86XkvfLn0DShb21yVA2XdoW//Sk6gR0p+pBtHGufDjsVnnWK1t103aSOF9bTTkKjnsNkVqfgUxBJlYpWlQGtftAk6Oy74OnPnHkJGedm+1w9q8BNyRquKRvYwhc39rTqtnZfqR4RTCvPJ8FKN6Plwh/qcUVmygvBx0opjhwUrRCsInhaHcyUXlVMAwACkQdSitU/QZooJvT3pnFdg== Received: from DS7PR05CA0001.namprd05.prod.outlook.com (2603:10b6:5:3b9::6) by CH3PR12MB7618.namprd12.prod.outlook.com (2603:10b6:610:14c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33; Sun, 22 Oct 2023 14:31:11 +0000 Received: from DS1PEPF00017091.namprd03.prod.outlook.com (2603:10b6:5:3b9:cafe::ca) by DS7PR05CA0001.outlook.office365.com (2603:10b6:5:3b9::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.14 via Frontend Transport; Sun, 22 Oct 2023 14:31:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DS1PEPF00017091.mail.protection.outlook.com (10.167.17.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.15 via Frontend Transport; Sun, 22 Oct 2023 14:31:11 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 22 Oct 2023 07:31:02 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 22 Oct 2023 07:31:01 -0700 From: Xueming Li To: David Marchand CC: Qi Zhang , dpdk stable Subject: patch 'net/ice: remove log from Tx prepare function' has been queued to stable release 22.11.4 Date: Sun, 22 Oct 2023 22:22:03 +0800 Message-ID: <20231022142250.10324-95-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231022142250.10324-1-xuemingl@nvidia.com> References: <20231022142250.10324-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017091:EE_|CH3PR12MB7618:EE_ X-MS-Office365-Filtering-Correlation-Id: 284f032f-ddf7-4ed6-c6c7-08dbd30b8a2a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Vh6iRsxPwPRzF6THgA3+Fs79LgnUFb9fbHSi77oLaLWS/zaetyrOOnbWvv4e7V8UL3v4esjbAI9wZKw2BW21x7hZRvvOSmEe8UIQwjvj0a8hAMRW3HeGq9Q5YBDGWiFnxagg9/WKG36nFLXc877GMzrKPjC4ln7Czb9pFcGOnfZ1d41yUKRtooC2IuJVKbisxQ5AgVpRZf+WzBVVH8330p/aP1h1EtcAkqB63tYUHxszAotpLe2oLjs84m3CpcjqKcnjfcvcCanveZnn4JdUzw7pTwGhB7c7b4WKCTXhr5FdRhrE6SBh3XsmNDIu+F0GlroR24Ite5KXTAQk5GKMQjE0smL+RFqkILNZ5Ovy9vUjZ82MoN6oM7oUv9pO/99zX48C3VFT3CuayP/t752cOuQFWVhHsohcjr/d3EH+aSP0um0mkn2PdknblOs4elECbIdYpO8D3j5zD5U7oxnLdPiB+kp921ytfRpxiFY8xXMi+s3D55EoAP07o0kwcjZ/bhyuaUSybhKkjk+zczcT6QLmhhrHfNAPXTi23tcRAsaILR8baFbe4vMm1WlUZpBPYPS2ZSLj4eEUQHGWisuqmP1FUJq5xUWbtkNlYbYwjiy5Pe/dCxRbtXK2SfO+9VtqaeGeSTDXw1df6HwrQTJGvSkXvfy1QJqrBnEgujtNXHXZ02UFeIC+YseD01Z6iRNaWyU2NA4jWrMI1FVoaoLOOlRys2uhsDM5JGz6RnWJ2h+wC9EDKUF7ZLPtQdQ3FuCf X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(136003)(396003)(376002)(346002)(39850400004)(230922051799003)(64100799003)(451199024)(82310400011)(1800799009)(186009)(46966006)(36840700001)(55016003)(2906002)(36860700001)(316002)(6916009)(70586007)(70206006)(54906003)(82740400003)(356005)(7636003)(2616005)(26005)(6286002)(16526019)(1076003)(478600001)(7696005)(53546011)(966005)(40480700001)(47076005)(336012)(426003)(83380400001)(41300700001)(5660300002)(36756003)(86362001)(4326008)(8936002)(8676002)(4001150100001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2023 14:31:11.7498 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 284f032f-ddf7-4ed6-c6c7-08dbd30b8a2a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017091.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7618 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/15/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=a2799805b6e0385e79a52408d6afe06439b10801 Thanks. Xueming Li --- >From a2799805b6e0385e79a52408d6afe06439b10801 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Wed, 27 Sep 2023 11:41:47 +0200 Subject: [PATCH] net/ice: remove log from Tx prepare function Cc: Xueming Li [ upstream commit 9aa546d868b60027a6723f1a772d287d44f17ef8 ] ice_prep_pkts reports to the application that the packet is invalid (from the driver pov). Having a log message in those branches is not consistent with all other checks in this function and it may slow down the application if such invalid packets are being sent continuously. Fixes: ccf33dccf7aa ("net/ice: check illegal packet sizes") Fixes: 688cb2f2c61e ("net/ice: fix scalar Tx path segment") Signed-off-by: David Marchand Acked-by: Qi Zhang --- drivers/net/ice/ice_rxtx.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c index 39e72047a5..dc07a73b66 100644 --- a/drivers/net/ice/ice_rxtx.c +++ b/drivers/net/ice/ice_rxtx.c @@ -3699,7 +3699,6 @@ ice_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, if (m->data_len < ICE_TX_MIN_PKT_LEN || m->data_len > max_frame_size) { rte_errno = EINVAL; - PMD_DRV_LOG(ERR, "INVALID mbuf: bad data_len=[%hu]", m->data_len); return i; } @@ -3718,7 +3717,6 @@ ice_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, if (ice_check_empty_mbuf(m) != 0) { rte_errno = EINVAL; - PMD_DRV_LOG(ERR, "INVALID mbuf: last mbuf data_len=[0]"); return i; } } -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-10-22 22:17:37.819537300 +0800 +++ 0094-net-ice-remove-log-from-Tx-prepare-function.patch 2023-10-22 22:17:34.356723700 +0800 @@ -1 +1 @@ -From 9aa546d868b60027a6723f1a772d287d44f17ef8 Mon Sep 17 00:00:00 2001 +From a2799805b6e0385e79a52408d6afe06439b10801 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 9aa546d868b60027a6723f1a772d287d44f17ef8 ] @@ -13 +15,0 @@ -Cc: stable@dpdk.org @@ -22 +24 @@ -index e07c6d1f15..d5513e9e93 100644 +index 39e72047a5..dc07a73b66 100644 @@ -25 +27 @@ -@@ -3708,7 +3708,6 @@ ice_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, +@@ -3699,7 +3699,6 @@ ice_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, @@ -33 +35 @@ -@@ -3727,7 +3726,6 @@ ice_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, +@@ -3718,7 +3717,6 @@ ice_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts,