From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46A36433D8 for ; Mon, 11 Dec 2023 11:22:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3EE4642DBE; Mon, 11 Dec 2023 11:22:24 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2049.outbound.protection.outlook.com [40.107.243.49]) by mails.dpdk.org (Postfix) with ESMTP id 282D340ED2 for ; Mon, 11 Dec 2023 11:22:23 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ADEg0IbZkKvSY/k8oNW6wFZ8kPlHwjuSGagNhAmz0bJ1RVvyXvQyrEmTpypra887UgjzO9OcYk4Hp+MjCxOBJ6Lo96OafdHkW7o/s75z+Vf/Fpy6eYkVg/XnMa/oMUW1qoMHaZMYxjBQ8Gqrrmv22jW4MQ3Be2kxlNlLBgbHEh4/6QLPak1SV2s8015c99E5tX3fvWcyE1LwufzSVGdSNlUHL9psiquVAmDY18MjTibQiVI4xmACbQ5GYrpMv53BpQrcNGzcAfGEK9DBDw/r/8QazYzMWo0BUjT/PNAdDzjIz0k8A1sKnS4NQfvgHcaj6uvph9yz6NNNNGcOrUkhaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=evndeO2dsYfNV8qLddLya6BVpPq7Dj5wyseSMA/44Is=; b=TrcvOsQMB14Op3Wxf4yQjMYn/1Vj+icgFJja1Wo5oCCgEnjMMC1icLFQq9UlSs94o8e6k37yoCqq/VisQh9OeypqGDYYtSv+kZ4tPhT+SzL+1C8F+0EU13a32KuAV7qRrNoV8q3jgmkHqjBEvBXg6lQIkmbkHeszsNUN73COUrhC/AMdtq+k3EOVYTUcguoaIoLnxn78z/zIZLzd/NKPijYOyOIySJkWonY8lyYXo/3cJOk6mna4Zk4ZNgUL06PBdyCs7ClvXt4+OsAEeWIYZVoeY9yEd+Cdx2PSmFTcCpvNnyjMu8WozFkjbQH3AUWyepefbfvV+Yn1xEx0nYomhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=networkplumber.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=evndeO2dsYfNV8qLddLya6BVpPq7Dj5wyseSMA/44Is=; b=SkSWg4yUq8Afjb7PFrXoRpyeSy/VbtviPo5J0kSgRA91MMvqwVFuW2EBJBhMeVXEc6icwhiRBJNCjfKVS/YTuRYroXo+l86V3FANYSWpDuFHYW7nU9GAuccGUqZI8X6Lxbwn62ckdND+YmqULD1TsyLzL3jE+mly/H+7rEecW8DoisIrNqdGddPswGfMS7RDBZE0NceMldda9wT74xb+vgydGlwOWW7Arc6sCoXRuBWQFSVlAZcEgBU+pnb63TH6Sgisz8eJFrBlk5MNpZ2TrChlY9oOmryCcNJXTShsy7+Mi8mpjSV+zU4hyDAC/A2XkDyx0kNuk34BKFZsYS/wAg== Received: from CH5P221CA0010.NAMP221.PROD.OUTLOOK.COM (2603:10b6:610:1f2::28) by SN7PR12MB8059.namprd12.prod.outlook.com (2603:10b6:806:32b::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.32; Mon, 11 Dec 2023 10:22:21 +0000 Received: from SN1PEPF000252A2.namprd05.prod.outlook.com (2603:10b6:610:1f2:cafe::92) by CH5P221CA0010.outlook.office365.com (2603:10b6:610:1f2::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.33 via Frontend Transport; Mon, 11 Dec 2023 10:22:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SN1PEPF000252A2.mail.protection.outlook.com (10.167.242.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.18 via Frontend Transport; Mon, 11 Dec 2023 10:22:20 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 11 Dec 2023 02:22:08 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 11 Dec 2023 02:22:07 -0800 From: Xueming Li To: Stephen Hemminger CC: =?UTF-8?q?Morten=20Br=C3=B8rup?= , dpdk stable Subject: patch 'pdump: fix error number on IPC response' has been queued to stable release 22.11.4 Date: Mon, 11 Dec 2023 18:12:11 +0800 Message-ID: <20231211101226.2122-107-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231211101226.2122-1-xuemingl@nvidia.com> References: <20231022142250.10324-1-xuemingl@nvidia.com> <20231211101226.2122-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF000252A2:EE_|SN7PR12MB8059:EE_ X-MS-Office365-Filtering-Correlation-Id: 4608c49d-819f-47a8-5cf0-08dbfa330eec X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UjZEIpGPxLpd0lCbpFcP4AEE7NhMQCzSUsU4jswWmUIY7pTm0un2rR9rBNC1nmaOS9c1mzt7mGftK/Jg2Rkz0puvOfBCPUtrxefqn5u0Qo/sb4cQfct4+zBxQROuQeSwcWc9jmGkfwY/aiyztkfMttzoN8NyI8ogyZiYBjx0suvmmXFIUhEmvdSKQaPfX2ITdr9tprEFqj9hnH54pdKbPj7u69DyLxuehggsVaCaIpWS7rCwaLJ/tpNjdyVZToYjFWq2tP2ykrtgQns6YGI0/yN39QqxEDOotGwVjucPUm36TSrxsyiCBncjSZ/0rh+IkF5BnijomYFWIfzK42s5ggv/r9h/zKE9K66WFTdt2gUZ7PmdWrKZ7/U0D/eh20iuXlNF8pRQgIDewEqEA4Ij4fxFGw8unU7WUNExvRNMGgjVk8Y8ivqtbvOwSCE+ST4x4v4C0OgLLb5Bw7CT36WW2Ak/WADSiYz7xax13O62vHCixh2s4XwOkwWzmhFBzcyevvuMymyRkmouUJZ/u6pYt2E0QvPGM1jw7viFz3d53p6vyONoTRijRXjzT1toYIj/BiF9Tdt7xYYRRQ38dXA0Op044W1bmbL7KgZ/WRBsv8GMHXqox/KjZylZLTVWpDg0jTdszkQzc/2k2EDxH+F+s0q9ADSHqpClOaMbxrwMpAPn7R96uoT+6+ltOTaFVBF0r+oxpo2z0woR0zJof9CqPTDfP0NlTmp/T5ZZl5yuSCsoDogz6lSzin7stYL7yzL09yEGeYR2f15CKMD9SYGDcXGb+DR3ldvpyHTr7tIzL3Q= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(39860400002)(396003)(136003)(376002)(346002)(230922051799003)(64100799003)(82310400011)(1800799012)(451199024)(186009)(40470700004)(36840700001)(46966006)(4001150100001)(6666004)(7696005)(2906002)(54906003)(70206006)(6916009)(53546011)(7636003)(356005)(36756003)(86362001)(316002)(8936002)(4326008)(8676002)(5660300002)(55016003)(40480700001)(70586007)(966005)(478600001)(40460700003)(41300700001)(66574015)(36860700001)(82740400003)(47076005)(6286002)(26005)(336012)(426003)(1076003)(2616005)(83380400001)(16526019); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2023 10:22:20.2298 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4608c49d-819f-47a8-5cf0-08dbfa330eec X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF000252A2.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8059 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/13/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=578b87a95557d1d351fdf0b121710d6215b89edc Thanks. Xueming Li --- >From 578b87a95557d1d351fdf0b121710d6215b89edc Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Fri, 17 Nov 2023 08:35:55 -0800 Subject: [PATCH] pdump: fix error number on IPC response MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Xueming Li [ upstream commit 5ec9575d8c0abfcefbc353d540f228d6d7036fe6 ] The response from MP server sets err_value to negative on error. The convention for rte_errno is to use a positive value on error. This makes errors like duplicate registration show up with the correct error value. Fixes: 660098d61f57 ("pdump: use generic multi-process channel") Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup --- lib/pdump/rte_pdump.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c index 4b7a4b3483..63835a1a67 100644 --- a/lib/pdump/rte_pdump.c +++ b/lib/pdump/rte_pdump.c @@ -564,9 +564,10 @@ pdump_prepare_client_request(const char *device, uint16_t queue, if (rte_mp_request_sync(&mp_req, &mp_reply, &ts) == 0) { mp_rep = &mp_reply.msgs[0]; resp = (struct pdump_response *)mp_rep->param; - rte_errno = resp->err_value; - if (!resp->err_value) + if (resp->err_value == 0) ret = 0; + else + rte_errno = -resp->err_value; free(mp_reply.msgs); } -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-12-11 17:56:26.525606600 +0800 +++ 0106-pdump-fix-error-number-on-IPC-response.patch 2023-12-11 17:56:23.217652300 +0800 @@ -1 +1 @@ -From 5ec9575d8c0abfcefbc353d540f228d6d7036fe6 Mon Sep 17 00:00:00 2001 +From 578b87a95557d1d351fdf0b121710d6215b89edc Mon Sep 17 00:00:00 2001 @@ -7,0 +8,3 @@ +Cc: Xueming Li + +[ upstream commit 5ec9575d8c0abfcefbc353d540f228d6d7036fe6 ] @@ -15 +17,0 @@ -Cc: stable@dpdk.org @@ -24 +26 @@ -index 80b90c6f7d..e94f49e212 100644 +index 4b7a4b3483..63835a1a67 100644