From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A19D5433D8 for ; Mon, 11 Dec 2023 11:14:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9C90A41140; Mon, 11 Dec 2023 11:14:17 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2074.outbound.protection.outlook.com [40.107.93.74]) by mails.dpdk.org (Postfix) with ESMTP id 720D940ED2 for ; Mon, 11 Dec 2023 11:14:16 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HVAX53CgrOCw855N8phwOJONGM6ZRbGm0beltMGwY5wE9AoF8pt5o6+7uEOwlpl4Bx703Pdy5JPQ07HWhdoMg1cX/WNcalPzIaWeLLkSbE5AvEdTFD8KtT2MvHHEaGDBTjNy3OEfSTl2eDKt2SI6kvTugwQFC2qIHak2ZWYItANNJtYHWANVYZvrKPrSAmluDOVIB7cQS4vG+TPIT2tURvhquoFvr5gxbEETYjP4oIkoPsI2/xJ2RKIWTKApgsqNKUk8hzhm5IaD8K22q9VtlSFLf16ySIa6yAu1+dVS5c63zROq+qjgpBdtFuFcbEN/ftWFvSWwAYBMoktRVDn7CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hDvaDDhavQ5mqWqwogdCyAvXkJdhtLEKGEBdklLs7Q0=; b=b3Mq5Xemk5LIerZ6acmtA9J58Xxph965zv1d5n+9fDc8rWdHzkYQxjGukC0P7srjVNWxgNGd7P3gCCxlQFgvciGeZ8yzL/SzlIZP1JELdUkW4alAhAlN3sQikWDMnkDbR6muTnMPeVrwqs1uPCBRT0SIxE21P4Cr8+R+Vw6KEbrQdBudDwYi7zh+4GoYjKTtwkJBHoUhcLnd2e+kGIw2iXg/iCHCc7870vxQzY6vaW43GChgb2lMCkEeujgKVEIDRYNCPbnPM8JXXWBjxO2lormAiCnCL4saUTE4dd8aiDjGLgWq/h6+9zDeGu4oCp1Ez3h3ikhUV1XcNWSCF8b0Jw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hDvaDDhavQ5mqWqwogdCyAvXkJdhtLEKGEBdklLs7Q0=; b=IBXzMfiJ+8N6Eg7Ts7HkmcZxKEQf/3G+1CJlXL/dgu394huM6hAzDJ+N2enIbGDAclrJ8Ism9PfarvJYeebI4bXZPmGPF6fLl8FvxlTQ24jKzKlcIi1V5wuahR08ItskFJ6VI661MD4x/sVxu+iYGIN4Gou3Ql/EvCoLP88Ry83f38cYJMkGQsSjFSKCzeJmGXa+S3x6mrjpXIQBW+kWxjahz7Q5QhaZmB6i4nhpQ2lcc9eqipOffxVoncaoZT49egIq+1JQFiJ2qJGCBOYE8hv124cYcXukvpk4ZPtmsoFREyAHvaGc7BkEYCQ2Ej0GR9gDLkw0aDb/C0wtlKoaFw== Received: from DM6PR10CA0031.namprd10.prod.outlook.com (2603:10b6:5:60::44) by CY8PR12MB7514.namprd12.prod.outlook.com (2603:10b6:930:92::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.32; Mon, 11 Dec 2023 10:14:14 +0000 Received: from DS3PEPF000099E1.namprd04.prod.outlook.com (2603:10b6:5:60:cafe::3a) by DM6PR10CA0031.outlook.office365.com (2603:10b6:5:60::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.29 via Frontend Transport; Mon, 11 Dec 2023 10:14:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DS3PEPF000099E1.mail.protection.outlook.com (10.167.17.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.18 via Frontend Transport; Mon, 11 Dec 2023 10:14:14 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 11 Dec 2023 02:14:02 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 11 Dec 2023 02:14:01 -0800 From: Xueming Li To: Joshua Washington CC: dpdk stable Subject: patch 'net/gve: update max Rx packet length to be based on MTU' has been queued to stable release 22.11.4 Date: Mon, 11 Dec 2023 18:10:42 +0800 Message-ID: <20231211101226.2122-18-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231211101226.2122-1-xuemingl@nvidia.com> References: <20231022142250.10324-1-xuemingl@nvidia.com> <20231211101226.2122-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF000099E1:EE_|CY8PR12MB7514:EE_ X-MS-Office365-Filtering-Correlation-Id: ce001a65-ffc5-4c75-79d8-08dbfa31ed45 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GL5iLgC8HnH4mEQd2xKqvmliGl7lV3aOXQp7Pf4XElhwRsNito7xVR7n8L2dwz9ojZ+n2a2/IIPg6F6r2xrvuRzpH/vFkvG8ZT0hkWm2dXngkYvsFJ4YY60xwxC6vTgA6qKLFHuq0GTtrDMOmlFrDhIerdJSixFLI0Ac9PspZ0b5eFem5++W7Kyyj9qu9DArv04k0DEaomlUb/7nTBSRaNsMCitQvd8dP1SYlKmPjeftw6Wd1r6npds2ned+qdSQQVxbZvm4ww77QZzCUWEv9ZZA4FdAg0Cc/h0YS4l4STQZ6mrZ7Tx2XP0KVYy36E90EpmftWB0ZywKy2mcpa4rC5VkIdS1ZqZ0IaQixQAhP/S5QurkMrynBvMZLFbwkSASF5dVbMAWfgDziTncPsOc/7pTUg5luqlbiIZIrCM9PPY2hbLZ6NTX3rGGIv9Ky86901Lw6pRTSzvyT1CEiykq0R0RJczL6BHKdczQCWCyVVp91x4tm+0Rp86jDrykNQsSoNM43HHZREg66ZI8O8jNDTei0XIdUxES7m8O5XIjIzjCbjWZAIoe4npp8oJ9qv24uFMWM+x2/8byeM/amh/tqnJjWRSzI6L90i4wk7qikdPuBN/JyR/T09IFVZNwbowtPdWPoMRgHMYFpn6VIDL7JTLjCOO/7hC0ZwqNT2EVjKw0EAIom/tejdMCYJm+TUkFeaTcJmYzhLS6raudl3z25dkbKVNJBDXGWKiHoueYOqOzOGGXcFBX+wxqpKADtSV3GXVbsfbG1AXkoE8gefmgGQ== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(39860400002)(396003)(136003)(376002)(346002)(230922051799003)(64100799003)(82310400011)(1800799012)(451199024)(186009)(40470700004)(36840700001)(46966006)(4001150100001)(6666004)(7696005)(2906002)(70206006)(6916009)(53546011)(7636003)(356005)(36756003)(86362001)(316002)(15650500001)(8936002)(4326008)(8676002)(5660300002)(55016003)(40480700001)(70586007)(966005)(478600001)(40460700003)(41300700001)(36860700001)(82740400003)(47076005)(6286002)(26005)(336012)(426003)(1076003)(2616005)(83380400001)(16526019); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2023 10:14:14.2745 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ce001a65-ffc5-4c75-79d8-08dbfa31ed45 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF000099E1.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7514 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/13/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=8f4eb6095105663603e436adab910acfec485aed Thanks. Xueming Li --- >From 8f4eb6095105663603e436adab910acfec485aed Mon Sep 17 00:00:00 2001 From: Joshua Washington Date: Mon, 16 Oct 2023 13:59:48 -0700 Subject: [PATCH] net/gve: update max Rx packet length to be based on MTU Cc: Xueming Li [ upstream commit 3b7896cd4963933140e1621cc421ec744a3ca247 ] Before this patch, max_rx_pktlen was always set to UINT16_MAX. This, in conjunction with the MTU fix, causes problems with testpmd, as setting the packet length with the --max-pkt-len flag causes the MTU to be set higher than possible due to underflow. As an example, setting --max-pkt-len=1460 (the default MTU on Google Cloud VMs) causes testpmd to set the following: mtu = 1460 - eth_overhead, where eth_overhead = dev->max_rx_pktlen - dev->max_mtu = 65535 - 1460. Thus, mtu = 1460 - 65535 + 1460 = 2921 due to underflow. Fixes: 030025b74202 ("net/gve: fix max MTU limit") Signed-off-by: Joshua Washington --- drivers/net/gve/gve_ethdev.c | 2 +- drivers/net/gve/gve_ethdev.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c index 806f45b0a7..7872b4e476 100644 --- a/drivers/net/gve/gve_ethdev.c +++ b/drivers/net/gve/gve_ethdev.c @@ -276,7 +276,7 @@ gve_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) dev_info->max_rx_queues = priv->max_nb_rxq; dev_info->max_tx_queues = priv->max_nb_txq; dev_info->min_rx_bufsize = GVE_MIN_BUF_SIZE; - dev_info->max_rx_pktlen = GVE_MAX_RX_PKTLEN; + dev_info->max_rx_pktlen = priv->max_mtu + RTE_ETHER_HDR_LEN; dev_info->max_mtu = priv->max_mtu; dev_info->min_mtu = RTE_ETHER_MIN_MTU; diff --git a/drivers/net/gve/gve_ethdev.h b/drivers/net/gve/gve_ethdev.h index 975318938d..4123685b34 100644 --- a/drivers/net/gve/gve_ethdev.h +++ b/drivers/net/gve/gve_ethdev.h @@ -29,7 +29,6 @@ #define GVE_TX_MAX_FREE_SZ 512 #define GVE_MIN_BUF_SIZE 1024 -#define GVE_MAX_RX_PKTLEN 65535 /* A list of pages registered with the device during setup and used by a queue * as buffers -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-12-11 17:56:23.750701000 +0800 +++ 0017-net-gve-update-max-Rx-packet-length-to-be-based-on-M.patch 2023-12-11 17:56:22.897652300 +0800 @@ -1 +1 @@ -From 3b7896cd4963933140e1621cc421ec744a3ca247 Mon Sep 17 00:00:00 2001 +From 8f4eb6095105663603e436adab910acfec485aed Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 3b7896cd4963933140e1621cc421ec744a3ca247 ] @@ -20 +22,0 @@ -Cc: stable@dpdk.org @@ -29 +31 @@ -index b441f96623..eb3bc7e151 100644 +index 806f45b0a7..7872b4e476 100644 @@ -32 +34 @@ -@@ -297,7 +297,7 @@ gve_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) +@@ -276,7 +276,7 @@ gve_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) @@ -42 +44 @@ -index 1cba282128..755ee8ad15 100644 +index 975318938d..4123685b34 100644 @@ -45 +47 @@ -@@ -21,7 +21,6 @@ +@@ -29,7 +29,6 @@ @@ -51,2 +53,2 @@ - #define GVE_TX_CKSUM_OFFLOAD_MASK ( \ - RTE_MBUF_F_TX_L4_MASK | \ + /* A list of pages registered with the device during setup and used by a queue + * as buffers