From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 50DEE433D8 for ; Mon, 11 Dec 2023 11:14:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4AA5641140; Mon, 11 Dec 2023 11:14:44 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2062.outbound.protection.outlook.com [40.107.237.62]) by mails.dpdk.org (Postfix) with ESMTP id C524D40ED2 for ; Mon, 11 Dec 2023 11:14:42 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZlJUHi6x+u1qFgW19oE+h+JthdVCxefkHFxbn22eXvPZtH0PziGEx9wF3Ja1tn2ISeA3KY68rHxsn5Wcn8ZOyzxhDHrsB1r4Vzzas2fiGyn0UcNKj5KDBfLkIrx2JFjyeceV56m5p7liYdjGO5FXBhHlAby2S6qbe9u3PGPi9N0NUbdqggDGKfGWlgPWjIWoKq6HwZOTW8C/AMtUtRzUCmOAF77u/bZxkjBRQFlX/I8nrrqwKZnXY0RQvY4nXyJMEETZ43HN/3yu0NVyzJBhU2D/dZOgNjfJch5v0FKwwwsfRLjqZP1pTJaxTxQw6Aje0IS+nY3uEV5/BvT+/bwfgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=95Gm63PZ+12DFo85BZAqNOM6jGIsBjZnF78MqpQ+YdY=; b=IU6Xh5MsJMLNPsiSUWUxaeRjw8C2jLeb/2jv4PgM6S8EbxhMAC3dRWxTjhjEcVyDFj053m2Nq0oj8S+kxqE9MXStADRYZKSL7f+iAKq1hUgpBZbpGIKmxRznrQanX2hY6oZ0sVAJOSH5O14jZ79AYLc2ghlauEXI2NenZ4IZPTQbwWl9L86Vp/Kmoo5GVq5/Nkl7amziFM29EA5CM0DlOGIG0Uz1+GmFsP9N4Sj9BaLPrKSI3Oc9JARbwwoDcsohqGZxbsRBX9DiGFsWVEtVDgVCs8Ig214cyGjsJVMW9zsO+asQZRzBkUPhNUQP+sQ8W4wYF4NIBThNXxNTp70p/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=huawei.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=95Gm63PZ+12DFo85BZAqNOM6jGIsBjZnF78MqpQ+YdY=; b=KkJ981aW7Ivs5qciuwzxUz9tVbrp2iifxTqoDm4YPKm4kR2zWKTAn3JK4RV6OIq+5cJgTW4Q/ztwQ/VJtT1SFQgrYkW/nbhCxeo+4uf9orT6l9WhO01HCsZuvTBrDfNuIk2LU9n02C02n+5PchjRkOQPqIohpC0XFktI5RX8KDYcSoDP7SuvtCQMgGDZ59tM+Me+y2WyJHjFzAoFkhKyVnH+pbYDOCnsR5AxDs9WEYcrvTykxx8qqeFjr+rZEitkUfDgyiWyGvxzHeKqdRoN2uFt6u+UhPQXvD4HuWeyMfOMUsrmESdURru9ptnh4qMg0PILAHw3Zw1vKH40I9Qf4Q== Received: from MN2PR16CA0029.namprd16.prod.outlook.com (2603:10b6:208:134::42) by DM4PR12MB6136.namprd12.prod.outlook.com (2603:10b6:8:a9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.32; Mon, 11 Dec 2023 10:14:40 +0000 Received: from MN1PEPF0000ECDB.namprd02.prod.outlook.com (2603:10b6:208:134:cafe::f5) by MN2PR16CA0029.outlook.office365.com (2603:10b6:208:134::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.32 via Frontend Transport; Mon, 11 Dec 2023 10:14:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by MN1PEPF0000ECDB.mail.protection.outlook.com (10.167.242.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.18 via Frontend Transport; Mon, 11 Dec 2023 10:14:39 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 11 Dec 2023 02:14:25 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 11 Dec 2023 02:14:23 -0800 From: Xueming Li To: Dengdui Huang CC: dpdk stable Subject: patch 'net/hns3: fix unchecked Rx free threshold' has been queued to stable release 22.11.4 Date: Mon, 11 Dec 2023 18:10:45 +0800 Message-ID: <20231211101226.2122-21-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231211101226.2122-1-xuemingl@nvidia.com> References: <20231022142250.10324-1-xuemingl@nvidia.com> <20231211101226.2122-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN1PEPF0000ECDB:EE_|DM4PR12MB6136:EE_ X-MS-Office365-Filtering-Correlation-Id: a6ea7f66-a914-4aa9-9456-08dbfa31fc94 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VG8ftOJC82uZdxDuP/wPh28xi5S3O8CdB7fdW04LW5NlH5O/Kf2pkPGB0A1DkEzuyDjs5ve/G15iDBJmAzJPqULFtwqaYBbbbHpCmG+5DVbZjmJGI6NaWF3u74sCbl0wqqPXJ5bbYL3cjJ9EQdAyhhi4kFqhdsbmo8d6ezLfCVW8vSv7rNS6oJFv23VEynYkwEVkjV6/7WGT6ysaCHQeFTSwV/eMjMSS+Lr+W6cc2uafkF73iD29EP4vOZnCw1fsw1JdQy0CO+pOjdei7qLoKEI0LdZEWS7yDXM3GJ7yMshhL2PW9VhYO1WxrGlEsZcPp/DCNmzUrmDX/dgMzUUreaOxRY/P+zDq3ASJ/iWEOBpmlj08ieHcAEgezpgU0ZLZhRlbioAGj5d75MW+qGc4BYJim7uw6hWV2XmQ+S5JOo1n0gYqgagF5lrA3sdN7o4CDOAZLtbpZfYJnNIjq6QPVNKL7yQdunRueEKJzodVLTF2shvAtE44OuxhQ2VyLGj1YXHUjH+2TRf4RCI9IS6qEbpjIL5X5S+jz9us4KeH7YL3iPpLZAHxdRyjavlhYsvOR+u0jZ+NeF2RFML1GBQs0IFJcYZEtbBifpYZ93qEOqJm/m+N+0vuIJdcmTiHR1ZpU5i0eD9NxWIbHdyN9iLwPWL8dUQT4iv+NXncT6WJA8tEYe+CYjvJkjhN0TtumSQcrMmgKVeVgOSDXfwmMNyaoY5TWzj0C1wftd0fnP014hk4iPlsF5GO/lgeXAocjBvhwiSFwcE0OMrA4HtHMVZnRoRzDDGxeYYQ5dxtJPiP6To= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(376002)(396003)(39860400002)(136003)(346002)(230922051799003)(451199024)(1800799012)(186009)(82310400011)(64100799003)(40470700004)(36840700001)(46966006)(83380400001)(2906002)(82740400003)(478600001)(356005)(41300700001)(4001150100001)(7636003)(55016003)(70206006)(70586007)(6916009)(426003)(966005)(40480700001)(316002)(6666004)(86362001)(7696005)(4326008)(8936002)(8676002)(53546011)(40460700003)(36756003)(1076003)(47076005)(6286002)(5660300002)(36860700001)(26005)(336012)(2616005)(16526019); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2023 10:14:39.8963 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a6ea7f66-a914-4aa9-9456-08dbfa31fc94 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: MN1PEPF0000ECDB.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6136 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/13/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=70c868a1556ef6a89571298d5b7cac97e7eb458a Thanks. Xueming Li --- >From 70c868a1556ef6a89571298d5b7cac97e7eb458a Mon Sep 17 00:00:00 2001 From: Dengdui Huang Date: Fri, 27 Oct 2023 14:09:40 +0800 Subject: [PATCH] net/hns3: fix unchecked Rx free threshold Cc: Xueming Li [ upstream commit c1f0cd3a4c834c2e550370b6d31b6bcd456a15f9 ] To reduce the frequency of updating the head pointer of Rx queue, driver just updates this pointer when the number of processed descriptors is greater than the Rx free threshold. If the Rx free threshold is set to a value greater than or equal to the number of descriptors in Rx queue, the driver does not update this pointer. As a result, the hardware cannot receive more packets. This patch fix it by adding Rx free threshold check. Fixes: bba636698316 ("net/hns3: support Rx/Tx and related operations") Signed-off-by: Dengdui Huang --- drivers/net/hns3/hns3_rxtx.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c index 296aba8b35..5db0d3418c 100644 --- a/drivers/net/hns3/hns3_rxtx.c +++ b/drivers/net/hns3/hns3_rxtx.c @@ -1789,6 +1789,12 @@ hns3_rx_queue_conf_check(struct hns3_hw *hw, const struct rte_eth_rxconf *conf, return -EINVAL; } + if (conf->rx_free_thresh >= nb_desc) { + hns3_err(hw, "rx_free_thresh (%u) must be less than %u", + conf->rx_free_thresh, nb_desc); + return -EINVAL; + } + if (conf->rx_drop_en == 0) hns3_warn(hw, "if no descriptors available, packets are always " "dropped and rx_drop_en (1) is fixed on"); -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-12-11 17:56:23.836913800 +0800 +++ 0020-net-hns3-fix-unchecked-Rx-free-threshold.patch 2023-12-11 17:56:22.907652300 +0800 @@ -1 +1 @@ -From c1f0cd3a4c834c2e550370b6d31b6bcd456a15f9 Mon Sep 17 00:00:00 2001 +From 70c868a1556ef6a89571298d5b7cac97e7eb458a Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit c1f0cd3a4c834c2e550370b6d31b6bcd456a15f9 ] @@ -16 +18,0 @@ -Cc: stable@dpdk.org @@ -24 +26 @@ -index f3c3b38c55..13214d02d5 100644 +index 296aba8b35..5db0d3418c 100644 @@ -27 +29 @@ -@@ -1785,6 +1785,12 @@ hns3_rx_queue_conf_check(struct hns3_hw *hw, const struct rte_eth_rxconf *conf, +@@ -1789,6 +1789,12 @@ hns3_rx_queue_conf_check(struct hns3_hw *hw, const struct rte_eth_rxconf *conf,