From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18DD6433D8 for ; Mon, 11 Dec 2023 11:15:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1434240ED2; Mon, 11 Dec 2023 11:15:15 +0100 (CET) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2071.outbound.protection.outlook.com [40.107.102.71]) by mails.dpdk.org (Postfix) with ESMTP id 463F841156 for ; Mon, 11 Dec 2023 11:15:12 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bJk6cMOiPotTN5AwEUpHoMGINoCy4TTzrVwXERJ2KwVuWW+edhEzcJD/leAYmnXvOxAbZf84VEC1vNjDH0PcaiKcCu1FiNiqGUTxK8md+MCRh7Kn/FP7s836/auV7aq4IC6BgQq2Q2ZLO2EeXehu8r9DE/i2XN6s/Zki7baFwGJP3gha2dZeBoeMtQaMCg0HhZ14RkVSsm28wWzP6BfJZXWYkknC8s/aDzrbbFwxaQG7MgVj+ayxOeADhD7ZKZfEbGj/QjriVlF+0oQlv1TpHnsrBDDGP60MaI6pyg1LY7BNxn2PsZkaME4WkAwldgW4CzOE5uB5NIc2HlgijVw9BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t8SMqZpV4M6eTLQlEcCfMDalZk8pBIUshFfUirqkdao=; b=KLjVIYQg28eqPNg1pSXAFWs4FdheMsnFLlhpdAWQTym4G6MfymdZi2sm7i3Lv1b7a8IGamQPlsv4ObvgjWqPHfEbbCaeYM3uG6idyIlgUWTHfgXDN7gtTr/hXJlzQ8obS7f7y86C+2Epao/1IC/32o95fLoeTGolfqVZdo4SnD6dyw8RLP2b/6SC+7DVNdUOtgolspfSAcZbN1T6gx7hSWDO1YEatdXzBIssdtIjO1A6wZEHxBYA/06pLEaGi+fH770h6CjMU15UdshHKLYJ9mvYCD/Gc6LqF8sjJY57KdX/AXpy9l0lXMTHOsfRMNWKk+DJb8zsZPjV1xVJ00+3Ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=corigine.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t8SMqZpV4M6eTLQlEcCfMDalZk8pBIUshFfUirqkdao=; b=bu5JhawAuujg6uDrGjdFPtpBDvmpJe1m7lowUxybxvrSgqXQsL6/wgUj+BE+Vt2PgVZQPlJEDiqCxR1klkvRaQWPQuGz8PiW01BaMi8N4vOuQtWwEMKEGX7+NicriAB7zxHoidc1f6n8wsKzL4QuRvMBZmIHOnsKPxGC7GRLegRGj0OTpQVUtepwKrSbjxmEoaPF6TgaSl0mTDNAuvUR+YX6xgRMzi/xJdAEKtCBF2zfYgT9u2krtmKuDEPDvgLvtkeVAf8NUVvm29VaZU/gSUZ/hMRatwwCi2fqGUUjN+4IutEQ+vXRZsj5TAyURwJ7KWsT53XFrD+kNktao46U2Q== Received: from MN2PR20CA0064.namprd20.prod.outlook.com (2603:10b6:208:235::33) by BN9PR12MB5066.namprd12.prod.outlook.com (2603:10b6:408:133::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.33; Mon, 11 Dec 2023 10:15:10 +0000 Received: from MN1PEPF0000ECD4.namprd02.prod.outlook.com (2603:10b6:208:235:cafe::b6) by MN2PR20CA0064.outlook.office365.com (2603:10b6:208:235::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.32 via Frontend Transport; Mon, 11 Dec 2023 10:15:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by MN1PEPF0000ECD4.mail.protection.outlook.com (10.167.242.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.18 via Frontend Transport; Mon, 11 Dec 2023 10:15:09 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 11 Dec 2023 02:14:57 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 11 Dec 2023 02:14:55 -0800 From: Xueming Li To: Long Wu CC: Chaoyong He , Peng Zhang , Ferruh Yigit , dpdk stable Subject: patch 'test/bonding: remove unreachable statement' has been queued to stable release 22.11.4 Date: Mon, 11 Dec 2023 18:10:53 +0800 Message-ID: <20231211101226.2122-29-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231211101226.2122-1-xuemingl@nvidia.com> References: <20231022142250.10324-1-xuemingl@nvidia.com> <20231211101226.2122-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN1PEPF0000ECD4:EE_|BN9PR12MB5066:EE_ X-MS-Office365-Filtering-Correlation-Id: 5f120b2f-82c3-4997-5389-08dbfa320e5a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Izm0y9j+AQ8wpbInlkbZPzM/29774EMsgBRSMcMh8RTGpUWDfhumvTxh7mKa5NDt5VC3eg2GCfqsJSlQom6fZSWk185LbGNK301yXhQKPohtofHZLKmDDMjuTP2Xp0Dyr/YIcqXLQyabd86uEr9z/owyw3ETJYRB8e1k1dYReTfS/sUqJIv7gMswkzNHh0em3KYEukgXrgzekMkBkCWJ0a1w1RCZ3kceJrwjXwhb3tGRTDI0LSxfCghMOVzPR5wXqKwWzONCK2Bk2llod1T3TVnY+1/rXWnv/YFdQZf+UQs1NxkqUKZHBY2Y2EyMPKZlXvDsJSpT54yreOznb0uM2+t9kV7UkgwgQzcsLUyxnjqV+8n3IoyZsbgzjfY1PS26pOBG8LzqGWA5M/VyQvcIGJbuxqHhVUBxI1e4eXOharPgtlR7ef7yVx5/rXmPOOet4LCzW5/NqMWto16OERydhkbX0ZSOe6tZHm+0c35c5wKbrPbMPJDJKB9MRRBvtDzO7faaoLMxPeD2z7oL6HB5COn12D18FwqEvAeUSKAQo7fe8I3BltChKROMf+/u5CMoEwILkL24KcP3NYfy/k+oto0mHn2GXhAYVgGW9QELTxULHwaxBaHlBJJCk4AWkoX/Oazg7RcXX6v1FChxlyeg65ejuToscJzcION9gwD0GVLlnqkb47Wlp6wASxIO5FgcM9W7CdkoqhSO7vGkEjFhI5AXVhtPrshELYo+LQ2lChYtAY0iH4bWRRxMrEi00Z4XiPxGlcNsBODDm49LSNMnKG8WB69171IKr5OP/HhaSxg= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(376002)(39850400004)(396003)(346002)(136003)(230922051799003)(1800799012)(186009)(82310400011)(64100799003)(451199024)(40470700004)(36840700001)(46966006)(40460700003)(4001150100001)(2906002)(41300700001)(36860700001)(36756003)(86362001)(7636003)(82740400003)(356005)(2616005)(336012)(426003)(16526019)(1076003)(26005)(6286002)(478600001)(53546011)(7696005)(47076005)(966005)(83380400001)(4326008)(5660300002)(316002)(6916009)(70586007)(70206006)(54906003)(8936002)(8676002)(55016003)(40480700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2023 10:15:09.7135 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5f120b2f-82c3-4997-5389-08dbfa320e5a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: MN1PEPF0000ECD4.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5066 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/13/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=7989293c6668d63bac5d3c2ff63c6dcfde89a7f6 Thanks. Xueming Li --- >From 7989293c6668d63bac5d3c2ff63c6dcfde89a7f6 Mon Sep 17 00:00:00 2001 From: Long Wu Date: Tue, 10 Oct 2023 14:23:02 +0800 Subject: [PATCH] test/bonding: remove unreachable statement Cc: Xueming Li [ upstream commit 9f4f98c9898fc6aa730ed02571790aa0b2ac4813 ] CI found that execution cannot reach the expression "else" inside this statement. Coverity issue: 403097 Fixes: 5e41ab250dfa ("app/test: unit tests for bonding mode 4") Signed-off-by: Long Wu Reviewed-by: Chaoyong He Reviewed-by: Peng Zhang Acked-by: Ferruh Yigit --- app/test/test_link_bonding_mode4.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/test/test_link_bonding_mode4.c b/app/test/test_link_bonding_mode4.c index 21c512c94b..7410f99617 100644 --- a/app/test/test_link_bonding_mode4.c +++ b/app/test/test_link_bonding_mode4.c @@ -641,8 +641,7 @@ bond_handshake(void) /* If response didn't send - report failure */ TEST_ASSERT_EQUAL(all_slaves_done, 1, "Bond handshake failed\n"); - /* If flags doesn't match - report failure */ - return all_slaves_done == 1 ? TEST_SUCCESS : TEST_FAILED; + return TEST_SUCCESS; } #define TEST_LACP_SLAVE_COUT RTE_DIM(test_params.slave_ports) -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-12-11 17:56:24.089521500 +0800 +++ 0028-test-bonding-remove-unreachable-statement.patch 2023-12-11 17:56:22.927652300 +0800 @@ -1 +1 @@ -From 9f4f98c9898fc6aa730ed02571790aa0b2ac4813 Mon Sep 17 00:00:00 2001 +From 7989293c6668d63bac5d3c2ff63c6dcfde89a7f6 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 9f4f98c9898fc6aa730ed02571790aa0b2ac4813 ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org @@ -22 +24 @@ -index 645fc1e0d4..ff13dbed93 100644 +index 21c512c94b..7410f99617 100644 @@ -27 +29 @@ - TEST_ASSERT_EQUAL(all_members_done, 1, "Bond handshake failed\n"); + TEST_ASSERT_EQUAL(all_slaves_done, 1, "Bond handshake failed\n"); @@ -30 +32 @@ -- return all_members_done == 1 ? TEST_SUCCESS : TEST_FAILED; +- return all_slaves_done == 1 ? TEST_SUCCESS : TEST_FAILED; @@ -34 +36 @@ - #define TEST_LACP_MEMBER_COUT RTE_DIM(test_params.member_ports) + #define TEST_LACP_SLAVE_COUT RTE_DIM(test_params.slave_ports)