From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86C52433D8 for ; Mon, 11 Dec 2023 11:15:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 812D84113C; Mon, 11 Dec 2023 11:15:17 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2073.outbound.protection.outlook.com [40.107.237.73]) by mails.dpdk.org (Postfix) with ESMTP id 6A6DF427DC for ; Mon, 11 Dec 2023 11:15:15 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FEAQnZT49yCdw2q1BPqddS99EC6NlLx/IOP1TSL3o4Z2Uk0a1p1iwYcNuCeOBKr05aXOuzs0b0y2YDxaqVLfZfuDPPONVW5BY4xPyWWLBfy4G7Wj3pPfkpvB6Xh9d2O7e4vLJGxiWhXRpg0tUqUOGrdTRwNh8R4LtkK2pD29Chyjd7o+47XTJub2K+7guSPZMv949R/VSy+V+qWUIgNobuxlRifidjTieySIn56IsJON3rkR3+PocbPo1Jp448X7bh5WkaTa/JHcrcIoz0r61q7+E/MYVaeXfemaRkLrEIobtzUQwdz/6gKQRTnl4fDSvqhIpJLmyT+zjP8MJOmN2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ACvDw9hAmMqUlTvZehb1YGmmj7ZD3QglLm+NZEI0mvA=; b=oPgL+x0aifPWh5iPSBGyq+XgFjM/6WTVzIdRjHFfMtlrqlhPMp6AfVI+Hv7SVFyZyQ2fiyXjFN7d/OJbm2LmpJnsuHB3tRDeAvtFjTo8B6/lf5lchcqH3gzFMzL50IMHzN9S3aD1HbLCOuWXtNduKUv8yMQed8xKhQQ7j/4A5z8nARFa2hOCuQsxzJI82ywnmTPKod7B/l/DX/mwiKkjSwKX2rzxMTcdThdlbHlci3WT+HkhEWvQ0LykBM3v1MN2C7J7VbXzpkOElybv3P5fJiu/tI3SjbzjbaeIqvKrOE6vdH7Vew04BRU0jrpsTKR55FKYpELY+YNCo9fuvh+GGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=corigine.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ACvDw9hAmMqUlTvZehb1YGmmj7ZD3QglLm+NZEI0mvA=; b=YIvjAXVYU0q7DEXTV2TntV+J0d8m1bSJsHN92I+qPRDId/jaSovjzSVQG3PztTWS4s81ktXW9EV0F2RxiBRMwoBEkYnx/ZgVykotlL91UKm0zXu05K6Ec8isjGc/bw1X5CnsCaMIPqMCwbZ4dFNBVm4I/LZ8I3PZQrR51mgkO8d4p3yGiPLU4VvxjgJcM7LgWh09IZqhGqb88ou06V1FR6Y8m6A918SiLHP1ynoXUde5NNTSlVjXleTJ7Q7xZ5jCTKz62t+Fnd+KWBohj+9sGy/yuBmR3vCiK/L5bKexowV2LL/30SypzCyrcLlVg0bgZSMpAGoBjwGKI6h82ZycvQ== Received: from CH0PR04CA0079.namprd04.prod.outlook.com (2603:10b6:610:74::24) by PH7PR12MB9102.namprd12.prod.outlook.com (2603:10b6:510:2f8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.32; Mon, 11 Dec 2023 10:15:12 +0000 Received: from DS3PEPF000099DE.namprd04.prod.outlook.com (2603:10b6:610:74:cafe::e1) by CH0PR04CA0079.outlook.office365.com (2603:10b6:610:74::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.32 via Frontend Transport; Mon, 11 Dec 2023 10:15:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DS3PEPF000099DE.mail.protection.outlook.com (10.167.17.200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.18 via Frontend Transport; Mon, 11 Dec 2023 10:15:11 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 11 Dec 2023 02:14:59 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 11 Dec 2023 02:14:57 -0800 From: Xueming Li To: Long Wu CC: Chaoyong He , Peng Zhang , Ferruh Yigit , dpdk stable Subject: patch 'test/bonding: add missing check' has been queued to stable release 22.11.4 Date: Mon, 11 Dec 2023 18:10:54 +0800 Message-ID: <20231211101226.2122-30-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231211101226.2122-1-xuemingl@nvidia.com> References: <20231022142250.10324-1-xuemingl@nvidia.com> <20231211101226.2122-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF000099DE:EE_|PH7PR12MB9102:EE_ X-MS-Office365-Filtering-Correlation-Id: 97243e10-c271-4339-b1c9-08dbfa320f2d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xxFuL1QU6wUTZfRdjTP4Cbm+mL7lA2zvRQywZpytFGD65uAJgicO6L4k/ky0B7PeWYptQ+RsTYHdtjRHCLuMiYmTqFdYHhgRnlIyPF5oiMS9mR2FXMJIV2PnfG/vWa9PPAUstV9z3DYqvGMSLsYzhPO/yM7XIyQapCRMHgzmEy8Q4o9TZ05TFxFK0ogFPZnOJUUS6t/vOQ/gqfdgyaZG6QRunvKg2w2M9Vn9JFJJ7n9bzfWR2q5fDQgQhx57d2U0TvScg2vEFqvyQ2iem2qpzeGPGM7GjgKDTPa9ph8Icj1so021k/kKVNSp02H6WseBIt2oX1OEKTX1k8oHMMH1VQhZC2bjuy6HwyTq9kBJ3I+OY2IsBV75s+hL3rtKh4f0e9KoVVk7F+uJ3RPvyivSKrxvsB6ZIKxUIvBasoqftMKVA+SD/XsCEPnAo6zexgV8MKn5Rra/DFjQZW7aNAS2AMAAGYfUm96co1wWJklOYw2khTvVVg2JMGxYDYf5WsGXwhZSXBQi7ZCl7o6/tyUprQukvlkmNtE6QMsNOwcHit3cd16+fTeVRA3o2hlyLAiVl6m+P4N/m94N8LkxwoCDsbF/LwdkA3KLYvwo7V5N1G3H//EbkxRBoKb/yG8KczVX2WKEV9/769mIN5yv8B0E2Vcv0x1FBQicsBXgIRePop88DplZvM+JmB0xIxCDHQipoMs6+Mp9/5podyUn1srDce8AVySffgBmDYwo2hMv8wjb61W1/p1ZxOBgpdcOVk40r/QTSoBWvpZSW/PTliWNGOI+KDqPxqXN22UkxPXgGbY= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(136003)(396003)(39860400002)(376002)(346002)(230922051799003)(1800799012)(82310400011)(64100799003)(186009)(451199024)(40470700004)(36840700001)(46966006)(40480700001)(1076003)(426003)(336012)(6286002)(26005)(16526019)(2616005)(40460700003)(82740400003)(36756003)(55016003)(356005)(7636003)(86362001)(83380400001)(5660300002)(53546011)(7696005)(6666004)(36860700001)(47076005)(8936002)(8676002)(70586007)(70206006)(966005)(54906003)(316002)(6916009)(2906002)(4001150100001)(41300700001)(478600001)(4326008); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2023 10:15:11.1612 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 97243e10-c271-4339-b1c9-08dbfa320f2d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF000099DE.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB9102 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/13/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=d3f778e0770274d1a0cc42f0d0a4360d7de1fa4a Thanks. Xueming Li --- >From d3f778e0770274d1a0cc42f0d0a4360d7de1fa4a Mon Sep 17 00:00:00 2001 From: Long Wu Date: Tue, 10 Oct 2023 14:23:04 +0800 Subject: [PATCH] test/bonding: add missing check Cc: Xueming Li [ upstream commit 0ecafc2e44268e4d0626dcf0c811590466291f20 ] CI found the function without checking return value in this place. Coverity issue: 403101 Fixes: 92073ef961ee ("bond: unit tests") Signed-off-by: Long Wu Reviewed-by: Chaoyong He Reviewed-by: Peng Zhang Acked-by: Ferruh Yigit --- app/test/test_link_bonding.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c index d74e2f5fca..53f5c13a24 100644 --- a/app/test/test_link_bonding.c +++ b/app/test/test_link_bonding.c @@ -447,7 +447,8 @@ test_add_already_bonded_slave_to_bonded_device(void) uint16_t slaves[RTE_MAX_ETHPORTS]; char pmd_name[RTE_ETH_NAME_MAX_LEN]; - test_add_slave_to_bonded_device(); + TEST_ASSERT_SUCCESS(test_add_slave_to_bonded_device(), + "Failed to add member to bonding device"); current_slave_count = rte_eth_bond_slaves_get(test_params->bonded_port_id, slaves, RTE_MAX_ETHPORTS); -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-12-11 17:56:24.131390500 +0800 +++ 0029-test-bonding-add-missing-check.patch 2023-12-11 17:56:22.937652300 +0800 @@ -1 +1 @@ -From 0ecafc2e44268e4d0626dcf0c811590466291f20 Mon Sep 17 00:00:00 2001 +From d3f778e0770274d1a0cc42f0d0a4360d7de1fa4a Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 0ecafc2e44268e4d0626dcf0c811590466291f20 ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org @@ -21 +23 @@ -index 4d715c4465..4d54706c21 100644 +index d74e2f5fca..53f5c13a24 100644 @@ -24,2 +26,2 @@ -@@ -449,7 +449,8 @@ test_add_already_bonding_member_to_bonding_device(void) - uint16_t members[RTE_MAX_ETHPORTS]; +@@ -447,7 +447,8 @@ test_add_already_bonded_slave_to_bonded_device(void) + uint16_t slaves[RTE_MAX_ETHPORTS]; @@ -28,2 +30,2 @@ -- test_add_member_to_bonding_device(); -+ TEST_ASSERT_SUCCESS(test_add_member_to_bonding_device(), +- test_add_slave_to_bonded_device(); ++ TEST_ASSERT_SUCCESS(test_add_slave_to_bonded_device(), @@ -32,2 +34,2 @@ - current_member_count = rte_eth_bond_members_get(test_params->bonding_port_id, - members, RTE_MAX_ETHPORTS); + current_slave_count = rte_eth_bond_slaves_get(test_params->bonded_port_id, + slaves, RTE_MAX_ETHPORTS);