From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 561DE433D8 for ; Mon, 11 Dec 2023 11:15:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 510B242686; Mon, 11 Dec 2023 11:15:46 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2085.outbound.protection.outlook.com [40.107.237.85]) by mails.dpdk.org (Postfix) with ESMTP id A70A940E0F for ; Mon, 11 Dec 2023 11:15:44 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QqvB9oe6Xf96H9scq5oi2F51qU8sbf/gvLjqJS2HbEQL1fAJDwHyKEAb/E0X4DQelIeEz8qhc/Iyq1H3SIuZhGpRiu6Q11syFoLZ6NV9Bkc5vrAb/yuTnf1xB6h34JaT/jc87Z1wcKKE8NIgLD84erwGi8GUJVaTSgOMp2krNw3dTSlKMb0zQQ4vEYZ02oqzKiTUmOuGAvn4jnDWQ73tdfcbW6dq4KYZQBzbq/ZPZD0b7IqfHsvpRQLsw+QWkCPDsM8Wn2up/V1uV40a/n2UK+957C2UzKT9KRztrd9rwqrJHMcL7hkhvE3Bf0Aoi2+XmfhfR0pTkKFJguOJnaakcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Pak7es0cKDY2fCxoT4zwzgO/nDBzQ9fob5kGmkijj6E=; b=h4l3VUSCMMlQslwDbTZpO9OrdaKD4McpUQ2azW0+TeSPK+pqNDzy1YXoVZqtoD4kv9iT8sgYItMHqcQVfCfIToz8xv23mrHysvVMy+0EWofKrr8tpngsvE1XtWiBXINEyRtuTUgoF864FoweEUwfLQFlXY8IzEB5S7Xl5OxwzNsm2YEA2wxml9GLoptxq2cuNqWpc7dkRWPifcKjSu0jfahH1qGfjR22ZzcX5dIY8U5ZKXNugQmdmr77Vffpq7vwQFCzKqUEs+7NCym8/x6iN68dozR1Vp8c59gtZYGh/JbTflhgSdaRfeE3AwcfiWCLT6W1AJVZPUtHc8TbM3lzVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=arm.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Pak7es0cKDY2fCxoT4zwzgO/nDBzQ9fob5kGmkijj6E=; b=QDi66p7FzmD8dXxxYb1JhoJRwRfGqA+Qscr18InFVEq/3+EOHGluftopSnpkTd6/I7alMk0U7ry6QtpzgMzfNtGGnTE5PawK80r484ZuEt5dqfBh7xhhxRmE6a4UtMAFVagMnZXTQtf6OD1luUj0zNF+sO0/WqWXob8ec8nob/5zz6/3DKb4yK8++mC6rBJGnN79LrWMLvJYrIqjDD31dPw67HqMWwMUTo51ESKZF/drfnseLjLpOWdPr2yDAnk+U4rPWl/5AH4e/s3ycTHrh93WWS13gjlJ8IugcuXbevt2tdD5K13YsTgqUhAFWKRy7423k5dvzzhhIqHS4Tuj3w== Received: from BL1PR13CA0133.namprd13.prod.outlook.com (2603:10b6:208:2bb::18) by PH8PR12MB6745.namprd12.prod.outlook.com (2603:10b6:510:1c0::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.32; Mon, 11 Dec 2023 10:15:42 +0000 Received: from MN1PEPF0000ECD7.namprd02.prod.outlook.com (2603:10b6:208:2bb:cafe::11) by BL1PR13CA0133.outlook.office365.com (2603:10b6:208:2bb::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.21 via Frontend Transport; Mon, 11 Dec 2023 10:15:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by MN1PEPF0000ECD7.mail.protection.outlook.com (10.167.242.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.18 via Frontend Transport; Mon, 11 Dec 2023 10:15:41 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 11 Dec 2023 02:15:24 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 11 Dec 2023 02:15:22 -0800 From: Xueming Li To: Ruifeng Wang CC: Luca Boccassi , Ori Kam , Ferruh Yigit , dpdk stable Subject: patch 'ethdev: fix 32-bit build with GCC 13' has been queued to stable release 22.11.4 Date: Mon, 11 Dec 2023 18:10:58 +0800 Message-ID: <20231211101226.2122-34-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231211101226.2122-1-xuemingl@nvidia.com> References: <20231022142250.10324-1-xuemingl@nvidia.com> <20231211101226.2122-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN1PEPF0000ECD7:EE_|PH8PR12MB6745:EE_ X-MS-Office365-Filtering-Correlation-Id: 2f75dc36-692b-4f5b-c900-08dbfa322138 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lQRrFKiUyIJcUnS7Ta/bsCSnKnbRmDHFM+2YJRV98R9hEkH/pe51G/f8y0lufiJZqcAIpZLfia9FEQ0HThCje2CSbHrrbMAhVyQ0UDTAW9Vt4Zz1PMwoUR+hTlpUf4ilf1Kp6pukxJxs+4ilY40mAhX3oDJt+IZzPMswXVBXZv+ZsYnU7hhjdEkb87TpNooIfOmMbyuBIG4jBUvDv4KwvL78GHF7d5y2pDtxEFTBKPL47kpTk0kq1Tdw4w6n9vOgd8nxeCYJsVvHMsH2Exo17QNGZiIZqnN6rR478w+wRrf0HtRjhiOG8w3cX29nc8ps4zhbjnPU5e1dhgTxaVgyUooz+cF1QikXtXKNbUFU/jncC//mbxKoguKHZkWRyRuI7kA4MP/4SWsYhYQixp2B/vEs+8CYJDzb0wM3kVrSzwQLL6dNDBaf7MRS1TKrF15e8q73ectF0tjisKqfGBoRSbYjg/gSi+eCUu9icLCbo+P7KOKnfM8iOwzHIZUiMCId30FvRlQl+AdYGhlbYvSxmOZqrs4vEuME+TPxKlzFuq2g3srSmu32kiTMZaQAYbCQn6XIHUSDsnNe4d0DxVW2dOh4hYLXralvVmBrOZf044yfn14kRlmCHU98gQVBAACn4hn1d9aV0rPcT3FC1GAkUaRwfJfuxIUWsy4JzLcc6N3NN5R8z71szDwKPkGa5PATv0OMaCyamalqM0x+tvUMEcn0tOH9TQSch+e1327jyNXZA0yuDNfX8tEFAIHdc6xGgCetIJy0SImBUvemQYQIhjkaLgIDvZlGBtuqGlmGf6ut7+/33iasMv6cFzoH5yMIzJb3lr+OT2Ztv2Yd9EcZOA== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(376002)(136003)(346002)(396003)(39860400002)(230173577357003)(230922051799003)(230273577357003)(451199024)(186009)(64100799003)(1800799012)(82310400011)(46966006)(40470700004)(36840700001)(41300700001)(36860700001)(16526019)(1076003)(426003)(336012)(26005)(6286002)(2616005)(83380400001)(47076005)(82740400003)(36756003)(86362001)(7636003)(356005)(5660300002)(316002)(8936002)(8676002)(4326008)(2906002)(4001150100001)(7696005)(6666004)(53546011)(54906003)(6916009)(70206006)(70586007)(478600001)(966005)(40480700001)(40460700003)(55016003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2023 10:15:41.3704 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2f75dc36-692b-4f5b-c900-08dbfa322138 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: MN1PEPF0000ECD7.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6745 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/13/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=73440e9fd34389f4ed218b95ac0b1d594cd84095 Thanks. Xueming Li --- >From 73440e9fd34389f4ed218b95ac0b1d594cd84095 Mon Sep 17 00:00:00 2001 From: Ruifeng Wang Date: Wed, 1 Nov 2023 15:15:54 +0800 Subject: [PATCH] ethdev: fix 32-bit build with GCC 13 Cc: Xueming Li [ upstream commit 3d67012ab70252190fcfea12c122567a4d010228 ] aarch32 build with gcc-13.0.1 generated following warning: In function 'memcpy', inlined from 'rte_memcpy' at .../eal/arm/include/rte_memcpy_32.h:296:9, inlined from 'rte_flow_conv_action_conf' at .../rte_flow.c:726:20, inlined from 'rte_flow_conv_actions' at .../ethdev/rte_flow.c:936:10: warning: '__builtin_memcpy' specified bound 4294967264 exceeds maximum object size 2147483647 [-Wstringop-overflow=] The issue is due to possible wrapping in unsigned arithmetic. The 'size' can be 0. 'off' is 32. When 'tmp' is equal to (unsigned)-32, the copy length is more than half the address space. Hence the warning. Cast variables to 64-bit to avoid wrapping. Fixes: 063911ee1df4 ("ethdev: add flow API object converter") Reported-by: Luca Boccassi Signed-off-by: Ruifeng Wang Acked-by: Ori Kam Acked-by: Ferruh Yigit --- lib/ethdev/rte_flow.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c index 2eadb0a032..ae22755ee6 100644 --- a/lib/ethdev/rte_flow.c +++ b/lib/ethdev/rte_flow.c @@ -654,7 +654,7 @@ rte_flow_conv_action_conf(void *buf, const size_t size, if (src.rss->key_len && src.rss->key) { off = RTE_ALIGN_CEIL(off, sizeof(*dst.rss->key)); tmp = sizeof(*src.rss->key) * src.rss->key_len; - if (size >= off + tmp) + if (size >= (uint64_t)off + (uint64_t)tmp) dst.rss->key = rte_memcpy ((void *)((uintptr_t)dst.rss + off), src.rss->key, tmp); @@ -663,7 +663,7 @@ rte_flow_conv_action_conf(void *buf, const size_t size, if (src.rss->queue_num) { off = RTE_ALIGN_CEIL(off, sizeof(*dst.rss->queue)); tmp = sizeof(*src.rss->queue) * src.rss->queue_num; - if (size >= off + tmp) + if (size >= (uint64_t)off + (uint64_t)tmp) dst.rss->queue = rte_memcpy ((void *)((uintptr_t)dst.rss + off), src.rss->queue, tmp); -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-12-11 17:56:24.248016300 +0800 +++ 0033-ethdev-fix-32-bit-build-with-GCC-13.patch 2023-12-11 17:56:22.947652300 +0800 @@ -1 +1 @@ -From 3d67012ab70252190fcfea12c122567a4d010228 Mon Sep 17 00:00:00 2001 +From 73440e9fd34389f4ed218b95ac0b1d594cd84095 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 3d67012ab70252190fcfea12c122567a4d010228 ] @@ -22 +24,0 @@ -Cc: stable@dpdk.org @@ -33 +35 @@ -index 4d6c28ee0e..20ee8430ea 100644 +index 2eadb0a032..ae22755ee6 100644 @@ -36 +38 @@ -@@ -724,7 +724,7 @@ rte_flow_conv_action_conf(void *buf, const size_t size, +@@ -654,7 +654,7 @@ rte_flow_conv_action_conf(void *buf, const size_t size, @@ -45 +47 @@ -@@ -733,7 +733,7 @@ rte_flow_conv_action_conf(void *buf, const size_t size, +@@ -663,7 +663,7 @@ rte_flow_conv_action_conf(void *buf, const size_t size,