From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09129433D8 for ; Mon, 11 Dec 2023 11:16:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 03EAE42830; Mon, 11 Dec 2023 11:16:36 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2065.outbound.protection.outlook.com [40.107.94.65]) by mails.dpdk.org (Postfix) with ESMTP id 754F140E0F for ; Mon, 11 Dec 2023 11:16:34 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S6iAF2h1agpuNbyv5JvzwlJv3htpuSeVF1x13KAEyW2Zmd5V7iux3PBdyYNHZ+ol+JraaPGQzpIMwKkfizwL7QdjkbmpicjMu8b4Yq1C8MWFOnmtGcps7Rr2p4eu7sWY5q8B6x3FR2G0q6+7cdUGFBlmYxj0X/QM3pkbGK3fXkPIIFfVGuI9CF/l8cP3lqInzVQxGs2I7jLFO+5IxeBoBPwvIJy2ZMppCsSz0N5r6Zo5TxQxPRuHPZuLZeooGyxPEnZEdEaflILhXHtG7Tt9oT+XZVi8/rY+J9sCkkbOv43navm3ymOpM/8YH0vpb++frUZ5wQrVOVFS5uNNt9ld0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3MPwqmfqcBs4uKc433ecSi8yT8jovf+QHbE6fv3BJ9o=; b=IkjeVkF7JHhtSfKHO0kokBakmcfAAH4PsedENC7TJJthVeNtrWKalUwPPVzTV67cLn8sq7fdtTnW0oGS8DaF8ZILoljXXrOP0Il1IKyBh+e8hEwMOdYhijzRk1N9L+dMGdq1Rx1I/iPKHRTPneY0zgNmKnRHwmBb2K07S8S/1lHP3FqeJ5dOJObWWMgALyzypodtTJi1azYu1hUPDWH/ZbjThP8gsQ8E+VRSsKi/NsHybKaiNVNmf032XmYr2zoTUaFlnwltbL5KXuSWRwYH11UeuaVQ9OotL/YAcwf4gp0cE53lAhqp01aJpON0nBdRuDnCFMRm9O+SwCnOiyzf4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=huawei.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3MPwqmfqcBs4uKc433ecSi8yT8jovf+QHbE6fv3BJ9o=; b=qjGWPpbFAIuI9AuGiJHwEyGrBk4ASJMX9In7hwbz/s1XiWhDDJLneD28FLol2BnAgQQsmOpqfq302UK0Oj3uPHveiVrPYN3xFxPiQOayV8co0unCE1GaADBfm6ZTqlk4eqtL63jEEmKmt+9asJOVC0kgm4rttKly/o5aSS8wJU/AdWpm+Os3dp5CQvibG9SX5EPWHY6g/bDSHJmQPrUJkRcvlqNqQD/pq1fm03wqehbRj66lM43tTENSKtOv1yYkH3muyh8nbW8f7DuaEIdtSBWVKyAS09IRpdH3E7JitZ582Akvfe7kBtf2ZN9pp8Jmr5rVLw86twXrKIZ/5BnJFw== Received: from MN2PR18CA0004.namprd18.prod.outlook.com (2603:10b6:208:23c::9) by CY8PR12MB8339.namprd12.prod.outlook.com (2603:10b6:930:7e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.32; Mon, 11 Dec 2023 10:16:32 +0000 Received: from MN1PEPF0000ECDA.namprd02.prod.outlook.com (2603:10b6:208:23c:cafe::90) by MN2PR18CA0004.outlook.office365.com (2603:10b6:208:23c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.32 via Frontend Transport; Mon, 11 Dec 2023 10:16:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by MN1PEPF0000ECDA.mail.protection.outlook.com (10.167.242.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.18 via Frontend Transport; Mon, 11 Dec 2023 10:16:31 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 11 Dec 2023 02:16:17 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 11 Dec 2023 02:16:15 -0800 From: Xueming Li To: Jie Hai CC: Dongdong Liu , Reshma Pattan , Chengwen Feng , "Huisong Li" , dpdk stable Subject: patch 'app/procinfo: fix RSS info' has been queued to stable release 22.11.4 Date: Mon, 11 Dec 2023 18:11:08 +0800 Message-ID: <20231211101226.2122-44-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231211101226.2122-1-xuemingl@nvidia.com> References: <20231022142250.10324-1-xuemingl@nvidia.com> <20231211101226.2122-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN1PEPF0000ECDA:EE_|CY8PR12MB8339:EE_ X-MS-Office365-Filtering-Correlation-Id: 2b3ff98a-6b4e-44cc-2b2e-08dbfa323f35 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C6/QAvKe9x9iAguIJS6MAmgbe5z9PEoqD10GlGlvxJUUt1abNP75Bn1uc0Ke7391LnVVPomBLOGx1iSZOYH+HCcmmolIVrLkLY4f3KzCAQ3qozKlu9G4PuetbDsxixXjl5l6Xjh7QAsXZSPDeH3PZcOdIkH0moXJwyXlHHpsNBBccuX7WUjsi25MIyxOO/RYcVMLyqgqDXnu424hjNDzg1Lg95oq5x82+SFhLLkWQKFs1qyHcpKHkl91R6zGwkfqnVrv3tTT0PP5TMKfCNz+r0DJOK5v/F4ywi3yw22M2y12oxp9ksNq5UsnzmdDwuUey0JRuBtPpMOsqqe1rgd1IggamGYvnjw/zG6TFHEJ/mEDkl4b8Dtbtz4PyzSU8NyQKuC5y4TwJ9eFuj5OEmxx/fUNQXUPADnzpSP+ZodAnjIcb9A8IB0z+ewZDb7x/+876To14QGpcffycWO6YN2io7XD531d+8MsncltNwTH0zclxDNxIZ+JVzbHbaRK7NYHxEGYYjqcBZxaMb6f+FAIVKVzBzsha2w3YUnxgXuATFGeJBhSRRGpSkFZLi64o6AwBD+lnQCD2hL9kOT+ocoagoCd3Mrxy0wx0GmKzPAeWKd1U8VN4ao8O6LZt1k9xPhZO6iYC1KwMnMt76DQtW2omzT5a510lXTANjtLrHknS+5lu6KetVnxMnEAmF25Pa/cx+JkY2MSoaDuf+rk+XZbaqCAbyNOGSVf2PwmxYzURYYnCK/Uw1gvzTR4NdtHcm3GUDAwmSUS9IdJd0+ddIKSulTgOcjb5TramwHTIff6nSw= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(396003)(346002)(376002)(39860400002)(136003)(230922051799003)(1800799012)(451199024)(64100799003)(186009)(82310400011)(46966006)(40470700004)(36840700001)(55016003)(40480700001)(6286002)(1076003)(26005)(426003)(336012)(16526019)(2616005)(40460700003)(82740400003)(36756003)(7636003)(86362001)(356005)(47076005)(83380400001)(5660300002)(53546011)(7696005)(6666004)(36860700001)(316002)(70586007)(70206006)(966005)(8936002)(8676002)(6916009)(54906003)(41300700001)(4001150100001)(4326008)(2906002)(478600001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2023 10:16:31.6940 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2b3ff98a-6b4e-44cc-2b2e-08dbfa323f35 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: MN1PEPF0000ECDA.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8339 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/13/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=df4470f94c7072597669e29e66d5d8c304f42cde Thanks. Xueming Li --- >From df4470f94c7072597669e29e66d5d8c304f42cde Mon Sep 17 00:00:00 2001 From: Jie Hai Date: Thu, 2 Nov 2023 16:20:16 +0800 Subject: [PATCH] app/procinfo: fix RSS info Cc: Xueming Li [ upstream commit 33079eccf5c1a99af722fe168d8465f602bc98b2 ] Command show-port should show RSS info (rss_key, len and rss_hf), However, the information is shown only when rss_conf.rss_key is not NULL. Since no memory is allocated for rss_conf.rss_key, rss_key will always be NULL and the rss_info will never show. This patch fixes it. Fixes: 8a37f37fc243 ("app/procinfo: add --show-port") Signed-off-by: Jie Hai Signed-off-by: Dongdong Liu Acked-by: Reshma Pattan Acked-by: Chengwen Feng Acked-by: Huisong Li --- app/proc-info/main.c | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index 50871c92a0..5f7fa64dc5 100644 --- a/app/proc-info/main.c +++ b/app/proc-info/main.c @@ -131,6 +131,8 @@ struct desc_param { static struct desc_param rx_desc_param; static struct desc_param tx_desc_param; +#define RSS_HASH_KEY_SIZE 64 + /* display usage */ static void proc_info_usage(const char *prgname) @@ -821,6 +823,7 @@ show_port(void) struct rte_eth_fc_conf fc_conf; struct rte_ether_addr mac; struct rte_eth_dev_owner owner; + uint8_t rss_key[RSS_HASH_KEY_SIZE]; /* Skip if port is not in mask */ if ((enabled_port_mask & (1ul << i)) == 0) @@ -979,17 +982,17 @@ show_port(void) printf("\n"); } + rss_conf.rss_key = rss_key; + rss_conf.rss_key_len = dev_info.hash_key_size; ret = rte_eth_dev_rss_hash_conf_get(i, &rss_conf); if (ret == 0) { - if (rss_conf.rss_key) { - printf(" - RSS\n"); - printf("\t -- RSS len %u key (hex):", - rss_conf.rss_key_len); - for (k = 0; k < rss_conf.rss_key_len; k++) - printf(" %x", rss_conf.rss_key[k]); - printf("\t -- hf 0x%"PRIx64"\n", - rss_conf.rss_hf); - } + printf(" - RSS\n"); + printf("\t -- RSS len %u key (hex):", + rss_conf.rss_key_len); + for (k = 0; k < rss_conf.rss_key_len; k++) + printf(" %x", rss_conf.rss_key[k]); + printf("\t -- hf 0x%"PRIx64"\n", + rss_conf.rss_hf); } #ifdef RTE_LIB_SECURITY -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-12-11 17:56:24.537430600 +0800 +++ 0043-app-procinfo-fix-RSS-info.patch 2023-12-11 17:56:22.987652300 +0800 @@ -1 +1 @@ -From 33079eccf5c1a99af722fe168d8465f602bc98b2 Mon Sep 17 00:00:00 2001 +From df4470f94c7072597669e29e66d5d8c304f42cde Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 33079eccf5c1a99af722fe168d8465f602bc98b2 ] @@ -13 +15,0 @@ -Cc: stable@dpdk.org @@ -25 +27 @@ -index ce53bc30df..3a441ba075 100644 +index 50871c92a0..5f7fa64dc5 100644 @@ -28 +30 @@ -@@ -151,6 +151,8 @@ struct desc_param { +@@ -131,6 +131,8 @@ struct desc_param { @@ -37 +39 @@ -@@ -1011,6 +1013,7 @@ show_port(void) +@@ -821,6 +823,7 @@ show_port(void) @@ -45 +47 @@ -@@ -1169,17 +1172,17 @@ show_port(void) +@@ -979,17 +982,17 @@ show_port(void)