From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0863E433D8 for ; Mon, 11 Dec 2023 11:18:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EE54540ED2; Mon, 11 Dec 2023 11:18:32 +0100 (CET) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2053.outbound.protection.outlook.com [40.107.95.53]) by mails.dpdk.org (Postfix) with ESMTP id F109A40E0F for ; Mon, 11 Dec 2023 11:18:31 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D79MR83pytpgCA0Yv/s2lU1srvDQUxtL+3r2FlgwuKbz4wW4R9WJ6d0rJTsVKnLaZ3oX+u/eyXDjsWtfb4LnatSKDtiN3yCI6wHc6NhwxeqnUBrf+n5qaAzUzdDJu+YwWLUmsznSyKtGwY5XSfti0AJRJPPiG1OLTLXSnLrIycJvqjDmL78ZboWkdq+A2fdHgvmwZvWsWg+jU1xISQZu/dOszzDlemOL+kEw6E4evImom22gintI4cQmhO7YF8PiBx2lICEfmHSV77Z0+OIKMQUMS7QroJmR6gpLOCfE004J5C0U8iJftXVmhIJ9gAf5dX6e2n3Ik3/ysYZ4hSMmbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FASk2AzypeoDWLVfgxQ4/XytIe+A1g9NR4yM77n0r6g=; b=nd7BBn6j98MAGRYWEW4JHZUUx8HIR3v7H2mvWr20icP/jZr9D8YxMehlSXgI2Tr2PSvt3hkpdX0j20Pbodr4RwISB89FKYloNpiHWAr0aIHpK/y8fDwWtnkHThnaf/T2m3Y9u08QMjwWPLJyzlSz2+98EXekSRYZqjrLcDniODJyiNdQwAEcEq83OqjTL3QQeA7SNzmbH5yUvkVputcYclgI0SD5/8+bd7+0EKFXE+z8orEglReiw2E+EMmBJ+nL6eShcHaf1MzhMGImfaphtBOEgUxOZmvoKE/DnofvnftHqt2UVic4wfW7yyF3ESKqmEUgLAMYpSbx3HMoph+yMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=pantheon.tech smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FASk2AzypeoDWLVfgxQ4/XytIe+A1g9NR4yM77n0r6g=; b=rTo/rgoEjUTzPIWI4oxC+VMvh0ImYdmjMEnXyQZ5Tun8qjmUw+ELkbmg3WjSNALSLV3ta0rDKuqEMyTeHnBI8L7aTUgqQqixCHRv58UJeij+IFI7fMrKe9S6PMu6oR9Ez0PkMGuqki/Z3cTJhZ+L5MJ04LgFW4SKPjo2N/Md7GKCO0PBbyDbZM3F8jN+3+aFmNLZnJ52p3Q/zG/JcB1HcxqgOLiIYHA5rD/CJ44cG0KH3W2vuc7FHw5Z/R1KV03//4xwShaU+HWJ5hs1+Pi2zs5AbrmRMWvalicRwzjI5C0TuzRcc3vhUvDdh9dJo21ytAV24dqIq2veGZ/2Zm09XQ== Received: from CY5PR18CA0008.namprd18.prod.outlook.com (2603:10b6:930:5::11) by PH8PR12MB7028.namprd12.prod.outlook.com (2603:10b6:510:1bf::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.33; Mon, 11 Dec 2023 10:18:29 +0000 Received: from CY4PEPF0000EE39.namprd03.prod.outlook.com (2603:10b6:930:5:cafe::81) by CY5PR18CA0008.outlook.office365.com (2603:10b6:930:5::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.32 via Frontend Transport; Mon, 11 Dec 2023 10:18:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000EE39.mail.protection.outlook.com (10.167.242.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.18 via Frontend Transport; Mon, 11 Dec 2023 10:18:27 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 11 Dec 2023 02:18:12 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 11 Dec 2023 02:18:10 -0800 From: Xueming Li To: =?UTF-8?q?Juraj=20Linke=C5=A1?= CC: Ruifeng Wang , Paul Szczepanek , dpdk stable Subject: patch 'config/arm: fix aarch32 build with GCC 13' has been queued to stable release 22.11.4 Date: Mon, 11 Dec 2023 18:11:28 +0800 Message-ID: <20231211101226.2122-64-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231211101226.2122-1-xuemingl@nvidia.com> References: <20231022142250.10324-1-xuemingl@nvidia.com> <20231211101226.2122-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE39:EE_|PH8PR12MB7028:EE_ X-MS-Office365-Filtering-Correlation-Id: 3a060d22-d77e-4ad4-98af-08dbfa32843b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X4KQKCLjswIjrUAPF4XQuH7pQQqBRaGdhIMh5kt6gCGTf7VWSD0rZG8b+rrfzGpq8Rj5Bzp1tnaIdJCIMW4R5O1Vnd2b5TxdDzURZk7LvjfKrxl5fzjTH/73iSqVVveJkKuQbc5GWrskSLFr0AVSbq5UAKKsUniVleKf9Z9Kci1/txfrBgc/rXVJb9XDg5Q4xIIoNnjto3pK26AKXCFjCqb+BSMnQQrP5KSXCKXGNGI7AiqeB0Vg+uKMPcUK4Am0pCTQPJOlL5QHRT2F6OEjl4sWRdT0orMyoBzC6i5nv4JUN41V0si+xyWujpY+7Su6vNtUC8tvEX+ejN5m5xPJJhSbFhEvJ1Rh7QYXzeYXONenbbt2fGc4Bwwjg28/eOLXYI/vcBDbWDOPEkF7x9lsj9H/sxiqL8Fxg2hS5qfePdm7HPQ0DsJjNybVaUKFk55F/vlDK1Sfr5UEpdJp1EwqBERKZ8oaB2BVuFTgzVC3ID4BjmlT5tA2jheKulNvyfdPx2eXkKJF/aQgdL7H7iPnjDzOGkeAK5c5DwT2pGsUDrUym/wMW1ikXmHXZF4Vz76j0QXl0y7LwHYYyITO9CU3zn4vRKQl004K69oP0VSQ4B8PdmrZsS3Nt/alms97zXwneTcNdJpBChoKPzGrvwlMgO3YYInM2Ggi5BXRWf/WB5fmOaENngMpujqtCgdcvG0a5YoruKTrvmPycPlVcjgFaB2BHYwu2qEmAG1wJH3ehl5H5J3EDYzJkYP8OcXd5MG0y+QWqEwpS5Dd/A1PliJOcLEyIV5zDVxv7JvK9PAH2OcHzpTaV46DZdDEgLH1x9Qf69DtMo7Hn8Dw8zmauvwUhQ== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(39860400002)(136003)(376002)(346002)(396003)(230173577357003)(230922051799003)(230273577357003)(451199024)(64100799003)(82310400011)(1800799012)(186009)(36840700001)(46966006)(40470700004)(40460700003)(53546011)(36860700001)(5660300002)(6286002)(1076003)(47076005)(336012)(26005)(2616005)(16526019)(36756003)(55016003)(7636003)(4001150100001)(426003)(70586007)(70206006)(6916009)(54906003)(966005)(40480700001)(2906002)(83380400001)(82740400003)(41300700001)(356005)(478600001)(7696005)(86362001)(8676002)(8936002)(4326008)(316002)(6666004); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2023 10:18:27.5457 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3a060d22-d77e-4ad4-98af-08dbfa32843b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE39.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7028 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/13/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=cb225e1ae9d8f204d0e6b7d9a463540fe97cbab3 Thanks. Xueming Li --- >From cb225e1ae9d8f204d0e6b7d9a463540fe97cbab3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juraj=20Linke=C5=A1?= Date: Wed, 25 Oct 2023 14:57:14 +0200 Subject: [PATCH] config/arm: fix aarch32 build with GCC 13 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Xueming Li [ upstream commit 7bfb0d4eaf51d329464e6c041315cf2025b97784 ] The aarch32 with gcc13 fails with: Compiler for C supports arguments -march=armv8-a: NO ../config/arm/meson.build:714:12: ERROR: Problem encountered: No suitable armv8 march version found. This is because we test -march=armv8-a alone (without the -mpfu option), which is no longer supported in gcc13 aarch32 builds. The most recent recommendation from the compiler team is to build with -march=armv8-a+simd -mfpu=auto, which should work for compilers old and new. The suggestion is to first check -march=armv8-a+simd and only then check -mfpu=auto. To address this, add a way to force the architecture (the value of the -march option). Signed-off-by: Juraj Linkeš Acked-by: Ruifeng Wang Reviewed-by: Paul Szczepanek --- config/arm/meson.build | 40 +++++++++++++++++++++++----------------- 1 file changed, 23 insertions(+), 17 deletions(-) diff --git a/config/arm/meson.build b/config/arm/meson.build index 6442ec9596..5028c74613 100644 --- a/config/arm/meson.build +++ b/config/arm/meson.build @@ -43,7 +43,9 @@ implementer_generic = { }, 'generic_aarch32': { 'march': 'armv8-a', - 'compiler_options': ['-mfpu=neon'], + 'force_march': true, + 'march_features': ['simd'], + 'compiler_options': ['-mfpu=auto'], 'flags': [ ['RTE_ARCH_ARM_NEON_MEMCPY', false], ['RTE_ARCH_STRICT_ALIGN', true], @@ -613,21 +615,25 @@ if update_flags # probe supported archs and their features candidate_march = '' if part_number_config.has_key('march') - supported_marchs = ['armv8.6-a', 'armv8.5-a', 'armv8.4-a', 'armv8.3-a', - 'armv8.2-a', 'armv8.1-a', 'armv8-a'] - check_compiler_support = false - foreach supported_march: supported_marchs - if supported_march == part_number_config['march'] - # start checking from this version downwards - check_compiler_support = true - endif - if (check_compiler_support and - cc.has_argument('-march=' + supported_march)) - candidate_march = supported_march - # highest supported march version found - break - endif - endforeach + if part_number_config.get('force_march', false) + candidate_march = part_number_config['march'] + else + supported_marchs = ['armv8.6-a', 'armv8.5-a', 'armv8.4-a', 'armv8.3-a', + 'armv8.2-a', 'armv8.1-a', 'armv8-a'] + check_compiler_support = false + foreach supported_march: supported_marchs + if supported_march == part_number_config['march'] + # start checking from this version downwards + check_compiler_support = true + endif + if (check_compiler_support and + cc.has_argument('-march=' + supported_march)) + candidate_march = supported_march + # highest supported march version found + break + endif + endforeach + endif if candidate_march == '' error('No suitable armv8 march version found.') endif @@ -659,7 +665,7 @@ if update_flags # apply supported compiler options if part_number_config.has_key('compiler_options') foreach flag: part_number_config['compiler_options'] - if cc.has_argument(flag) + if cc.has_multi_arguments(machine_args + [flag]) machine_args += flag else warning('Configuration compiler option ' + -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-12-11 17:56:25.155140200 +0800 +++ 0063-config-arm-fix-aarch32-build-with-GCC-13.patch 2023-12-11 17:56:23.067652300 +0800 @@ -1 +1 @@ -From 7bfb0d4eaf51d329464e6c041315cf2025b97784 Mon Sep 17 00:00:00 2001 +From cb225e1ae9d8f204d0e6b7d9a463540fe97cbab3 Mon Sep 17 00:00:00 2001 @@ -7,0 +8,3 @@ +Cc: Xueming Li + +[ upstream commit 7bfb0d4eaf51d329464e6c041315cf2025b97784 ] @@ -27,2 +29,0 @@ -Cc: stable@dpdk.org - @@ -37 +38 @@ -index efd0bf32bc..36f21d2259 100644 +index 6442ec9596..5028c74613 100644 @@ -51 +52 @@ -@@ -696,21 +698,25 @@ if update_flags +@@ -613,21 +615,25 @@ if update_flags @@ -92 +93 @@ -@@ -742,7 +748,7 @@ if update_flags +@@ -659,7 +665,7 @@ if update_flags