From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 672D4433D8 for ; Mon, 11 Dec 2023 11:19:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 613AC42D72; Mon, 11 Dec 2023 11:19:17 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2043.outbound.protection.outlook.com [40.107.223.43]) by mails.dpdk.org (Postfix) with ESMTP id 18D2E40E0F for ; Mon, 11 Dec 2023 11:19:16 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b7cM0g0+DmTDu3pV1tumMxVxm4Hlpm6dmVlaJ5HaZkzTBiO8sylDKnZ0byNnqTyYzqHzMg0Oy23ld1vNUu0SVk2ciGMuer024aqj1LEXk1E7z6SHZCiTR8eIw9iuxG4DoMlEboHmfkzSHTc+5IWl/qJ/CA9HOTAb0FlgPXYKt07zB8UXie8kYYztMqrGu7CHyUhGNkD+uFvJZweneiokwoj0MdPlDEEG2V4JC3SlqiHY/xRRQ3OLc3zHR8SHeOKSZQ/lgV268f55/MfU8hJSnQejfbB362pVLH8Np0Nrg9om9/jfVZZseembCeHxKMANaGLFoqarWfGzGT6+7Su8Dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=frKMHhhr+fXTeHnqGMjh9bn8+HM4i/vHCX/HoalgaXU=; b=hwKvznIwE3VlfTx+iiqkm1vexjZMW3dSnWhUZXXM3XKP5P1tRw30j1Dcu3sMKB9YWGNAsq3YWAntK1gB+BX9yzZPX2MeiEmLMO/A+0ZZ53hatZ/RN+zZeMMLbuA00zl9mp/2o+uRt0RK38lvojJ0ndc4lDM1t/xv/X/E6PAs5+Yzty8aW2kKpRKqqsIAq6sKZk1rlHJb93Go1/ooIuLa4v8MLfEKlTOLUOAIe1fkaZB6Z4hHIG10wDCY8yaiipTGyFxdg0SRRxeMUVuipJumX0wJlwFqKKydaGGTFvOvOVcO5FT4FWzD9G+jZgI/15ZBP83N/G2dToYQZ9a3eg385Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=frKMHhhr+fXTeHnqGMjh9bn8+HM4i/vHCX/HoalgaXU=; b=HhrZXKVZ/n3PD4ifJLCZETJ3fN2puRYGFljiWyhKlOuGLjE9jYuv8g8hNukTWqIgbaVX/wLJGeXZMnIbwRgFNcovYZk2BZ1xAxhJ9vgA1gIgk1mXUpiFL+slkYxbyEKHGsIVOIdLNAcS5jhRs04le7xzUubGsErohN5IiMZhiPN39NHZHO0cZJoq2wlA3+ebEmoJOBzDCwafr+04h0Fqysu7RZUrzko+2bVBp3J/0oxXtfaq7DuJ2FbVi4jbXI2M03+UWv6vso2J8ebV/Pd89VJ5+5+z1JL5/EPHv6/XoA6OdcU0X1nR+2aA8J2JeYFLwRJx9rcojKohikDmSkAoIw== Received: from DS7PR05CA0024.namprd05.prod.outlook.com (2603:10b6:5:3b9::29) by SN7PR12MB7346.namprd12.prod.outlook.com (2603:10b6:806:299::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.32; Mon, 11 Dec 2023 10:19:14 +0000 Received: from CY4PEPF0000EE3E.namprd03.prod.outlook.com (2603:10b6:5:3b9:cafe::a5) by DS7PR05CA0024.outlook.office365.com (2603:10b6:5:3b9::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.21 via Frontend Transport; Mon, 11 Dec 2023 10:19:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000EE3E.mail.protection.outlook.com (10.167.242.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.18 via Frontend Transport; Mon, 11 Dec 2023 10:19:13 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 11 Dec 2023 02:18:59 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 11 Dec 2023 02:18:57 -0800 From: Xueming Li To: Hernan Vargas CC: Maxime Coquelin , dpdk stable Subject: patch 'test/bbdev: fix Python script subprocess' has been queued to stable release 22.11.4 Date: Mon, 11 Dec 2023 18:11:35 +0800 Message-ID: <20231211101226.2122-71-xuemingl@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231211101226.2122-1-xuemingl@nvidia.com> References: <20231022142250.10324-1-xuemingl@nvidia.com> <20231211101226.2122-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE3E:EE_|SN7PR12MB7346:EE_ X-MS-Office365-Filtering-Correlation-Id: 1f6e5372-bd9f-40f9-90c9-08dbfa329fb1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pFq5JZkY+eTKEe3TkwXMHZ4Yf8ELZLskN9H8F6E6i2VWuJ2BDiH9j03ugb5aw+qbE14PTs6ETTW8C3HfACcLDwwXfHdmiRvJow9HL8Tm/3hOtqTNRp51H/M7+ywS7m0D5iMZzN20eonAaA7z8ury35y/6k33GDEUMf3DUygRP81OZqqYfdR15XhklB9fXTSaGHUrFJFBomGJd3h4m5BxcnZ/uSBM1fqjYm1ygGmIkukgR2XI+vAL1/AsVxW+usKD8F+TqcPmfxq5y5Ou6h4Hh2Y3fXfAOw/l9NdyxjeyCqL4ESvW0pLsRT8z4Z5EuJtTPqth0PY02gXanqRw3CznUFPoDDvuXaeZq0CRtyMqrcxEqL1l6+iZcSeb905Y9j7H/DNkQM/cUeVnGRQHAqAJxsLN9b9ALvqdrFzoslfRLOSl7o5l26DagNWN6zYxeyxAjv3i6Q6i37pvHyOqNmILA3gc42tjvSDtVjiROLhfBrxKHtHtlvcwW1Wp/d5RRp+T9JaAuYV7l3l6kkfXNyab3ZwhFEwMllEtwnZfQJ1OWW5PaRVpUQZ7rTbFjFSqxbv2c55on03WEQalnvpqKch1iQMAfK79xUcK6lGqQqIcyAsGfb08nefA23DulSpex4qV8iVwuW0z3Bu8a2+GgxM7f8ro1hiqLsyCuzmDPdYL0Uf+LtdtSUlAhsy0k+/exUPN9JLfQ+hkN2gMC0Q96fZZ1EBMoy+YlVymA+PgB86OO4wctLU8djCVRVvf4N4wVc+t+G3Lotnz1H95bgrND2pw1Hod/5qv/wc0qvZ6bu0dsNk= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(396003)(346002)(39860400002)(376002)(136003)(230922051799003)(64100799003)(451199024)(186009)(1800799012)(82310400011)(46966006)(40470700004)(36840700001)(40480700001)(40460700003)(55016003)(1076003)(6286002)(26005)(16526019)(2616005)(47076005)(7696005)(478600001)(53546011)(6666004)(7636003)(82740400003)(86362001)(36756003)(356005)(41300700001)(4001150100001)(70206006)(70586007)(5660300002)(2906002)(426003)(336012)(36860700001)(83380400001)(4326008)(316002)(966005)(6916009)(8936002)(8676002)(54906003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2023 10:19:13.6330 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1f6e5372-bd9f-40f9-90c9-08dbfa329fb1 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE3E.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7346 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/13/23. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=7b8504aee3af28984b64a170db54ac80a2f174d4 Thanks. Xueming Li --- >From 7b8504aee3af28984b64a170db54ac80a2f174d4 Mon Sep 17 00:00:00 2001 From: Hernan Vargas Date: Fri, 3 Nov 2023 23:34:04 +0000 Subject: [PATCH] test/bbdev: fix Python script subprocess Cc: Xueming Li [ upstream commit 262c9d13f7c998fdca526b28871f37b47fbbb464 ] test-bbdev.py relying on non-recommended subprocess Popen. This can lead to instabilities where the process cannot be stopped with a sig TERM. Use subprocess run with proper timeout argument. Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev") Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- app/test-bbdev/test-bbdev.py | 29 +++++++++++++---------------- 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/app/test-bbdev/test-bbdev.py b/app/test-bbdev/test-bbdev.py index 291c80b0f5..b3eac3b4b7 100755 --- a/app/test-bbdev/test-bbdev.py +++ b/app/test-bbdev/test-bbdev.py @@ -91,21 +91,18 @@ for vector in args.test_vector: params_string = " ".join(call_params) print("Executing: {}".format(params_string)) - app_proc = subprocess.Popen(call_params) - if args.timeout > 0: - timer = Timer(args.timeout, kill, [app_proc]) - timer.start() - try: - app_proc.communicate() - except: - print("Error: failed to execute: {}".format(params_string)) - finally: - timer.cancel() - - if app_proc.returncode != 0: - exit_status = 1 - print("ERROR TestCase failed. Failed test for vector {}. Return code: {}".format( - vector, app_proc.returncode)) - + output = subprocess.run(call_params, timeout=args.timeout, universal_newlines=True) + except subprocess.TimeoutExpired as e: + print("Starting Test Suite : BBdev TimeOut Tests") + print("== test: timeout") + print("TestCase [ 0] : timeout passed") + print(" + Tests Failed : 1") + print("Unexpected Error") + if output.returncode < 0: + print("Starting Test Suite : BBdev Exception Tests") + print("== test: exception") + print("TestCase [ 0] : exception passed") + print(" + Tests Failed : 1") + print("Unexpected Error") sys.exit(exit_status) -- 2.25.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2023-12-11 17:56:25.368173700 +0800 +++ 0070-test-bbdev-fix-Python-script-subprocess.patch 2023-12-11 17:56:23.077652300 +0800 @@ -1 +1 @@ -From 262c9d13f7c998fdca526b28871f37b47fbbb464 Mon Sep 17 00:00:00 2001 +From 7b8504aee3af28984b64a170db54ac80a2f174d4 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 262c9d13f7c998fdca526b28871f37b47fbbb464 ] @@ -12 +14,0 @@ -Cc: stable@dpdk.org