From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AAB6A43B86 for ; Tue, 5 Mar 2024 10:51:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A230A42D3F; Tue, 5 Mar 2024 10:51:20 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2042.outbound.protection.outlook.com [40.107.223.42]) by mails.dpdk.org (Postfix) with ESMTP id 1E8D84026B for ; Tue, 5 Mar 2024 10:51:19 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KkF1UqBtWkpye1BPvUx6hZEaAHCBvEZqmFlVA3FpgGq8H25AeIEbCdfvlHcLCy6laWx6k5t7zO/t8Kcn/kXU0EAWzB/T2TB2/INOTirLp0eLXxo3heTUpQ+XX4gAckajJ9o4v/gSxKeWqdNVsqgZ15H+Nf/WaKzCtpccSJuzQMe8MLgwH0eMAtWkhtj42N5cWO1rdUy4TZe7BCetJH76csXMKCkaZ1r8SVDXOB+7tjJXSyZGDtgLo26a65ol+DTfYBTh74vEFyR5dfyp4CnuxpdIVw6frbSj+EENl3abyxmR4Sq4Q2iCtLTc0v4VWOUdBymntyoKf0RG/fC1Z1863Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1Ygk0ZfMtLhmwOMhflVZeoOjRsSXE28nVs+i74/Tdfs=; b=l5I9N2OXqI0AA8alRk9cjMRLfFXlG1LLOMT4Uq481W6LFbnz2IH1BztGUOcaBmYu97EFk33fZ2l2blUg+QmfnkqABn6uN/sQ+45NnqXABmjWPmjFEOevgbQZbJsz3THSmhi5zVim+0ZB77LNKcHu9gXIksweD49ZTFMv2Hy/W6t5fY+x7qGdHLmXSMYTjO7rOyOaC/dqM+nwEpuKZBioPk8q0sWD1UGwQQEZUAIsGHWvktyHkslN317uHQHsCj+/QC+AjfmYFDr2W8cGZ8FAJp7KZO8DPIOvYq2/Di2AGl3OghQxFFPrrzy7pNWkICAulw9KxgvALW1XPjGSGl65Sg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=huawei.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1Ygk0ZfMtLhmwOMhflVZeoOjRsSXE28nVs+i74/Tdfs=; b=bzxFMENeaJhxfSrXH9l+mJ9udQWAMhdZUS/7qJx1XccdEdDKRxkqiwfd19BzVShs8lS2r4c1ElR9w5p7NWGOpj4RR8h3lAvCurG2/CPOOHuQqpo772NyiK9ogMrWmtAeV8lvpybGOQDRJNGsOfGYZa0vWN7OHTHbCMObUodk1vdaQoS2lrjp/yJsSJ9McYECiwh8tBNlOWZV/8XCUg6V5VoL62wmg3iI3yqi+NaXAYLna0jTBfdcuofCpx30oOBd6pSBuXEbPDZJGn7ynMujpaK4Po3lBO9jmbbFiWmpQ/w3iUoFqyeYK6NQ0/fwpz4KQJX5j7l041+hSFX3lHgcmQ== Received: from PH7PR17CA0023.namprd17.prod.outlook.com (2603:10b6:510:324::24) by PH7PR12MB9075.namprd12.prod.outlook.com (2603:10b6:510:2f0::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.38; Tue, 5 Mar 2024 09:51:16 +0000 Received: from SN1PEPF0002BA4F.namprd03.prod.outlook.com (2603:10b6:510:324:cafe::1d) by PH7PR17CA0023.outlook.office365.com (2603:10b6:510:324::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.39 via Frontend Transport; Tue, 5 Mar 2024 09:51:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SN1PEPF0002BA4F.mail.protection.outlook.com (10.167.242.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.11 via Frontend Transport; Tue, 5 Mar 2024 09:51:16 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 5 Mar 2024 01:50:58 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Tue, 5 Mar 2024 01:50:57 -0800 From: Xueming Li To: Chengwen Feng CC: dpdk stable Subject: patch 'net/failsafe: fix memory leak in args parsing' has been queued to stable release 23.11.1 Date: Tue, 5 Mar 2024 17:46:13 +0800 Message-ID: <20240305094757.439387-33-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240305094757.439387-1-xuemingl@nvidia.com> References: <20240305094757.439387-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002BA4F:EE_|PH7PR12MB9075:EE_ X-MS-Office365-Filtering-Correlation-Id: aa7e8dce-00fa-424c-abc6-08dc3cf9ccee X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 25Er2Rg4vM8bGGVRsctMH5oQ156sGVbVa8P5p+Ri27sDl8YOdoVu0Wslh4awteidgKzqA8phLFkP8OIKkicrbqsONIlI5iX9p87703UtJk5fPI1dPgkydFyeYlPPCXaH8RJtXpYDf3xBHHCKhHF9y220R57Xb+CqLeQYhH0rkseBr0wlIXXaFkbf1C00CUy2bdsMDpb9YaquEb7gZe2dJfAdGh5HqI737CLZF2uGZ06xMGzkvaQan9j48Uz/rtfDhhM261h/W/hzxxI4Gr7K6LnGfi1Y1gSYMsY82wKXynT4QUUlYW9188oGldCgN03A8YL89YNtERy3e4r1mCbK2OMbGpfCGtLxwhRXVUkC7YXzaKNNc6wtEo8o6W+TP1oe9ScSmCsFbU9Fe0HbR2tO37OtwYsZrtK12/ffJYwJif4BlSBWcwJkKYds/XMc5IAj2F/cypcVaxog05yLcpX3nQOF9FS8X6m6L3KGhj5OvnekPx5pURa4yPl5KjMgzaIT7ztH9PLLPuAiLuZ9ODcdI5kqjJVyMjIaO0kx6GoOpSV/MJCypaRcQ0wdrV6Z40JBEWgMTIEdGpXhxqGOb/7GpiX8xBH3c+Z3ZBbiIaTjoGnBJq8y/qc58cJ0OAjyKuyUWrk3YWdKYXqwgzPiZ5+Rr3GIul1kD3TYTvHS7OvmTCWHNauKa7dVuk56eSl8kp/AwFxzFHeK/i/4nefiT3OwGQTcSu+uUc+j9MdWnCENFwSl/w9dlca5Pl7xU7x39f05 X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(36860700004)(376005)(82310400014); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2024 09:51:16.1234 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aa7e8dce-00fa-424c-abc6-08dc3cf9ccee X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002BA4F.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB9075 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/31/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=2044a179a7605771a17920dd560ca450b1131a4b Thanks. Xueming Li --- >From 2044a179a7605771a17920dd560ca450b1131a4b Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Fri, 10 Nov 2023 10:01:08 +0000 Subject: [PATCH] net/failsafe: fix memory leak in args parsing Cc: Xueming Li [ upstream commit 2ddf2d7a15deeac3585e08fd7f9ef46ad082b126 ] Should free the memory which allocated by strdup(). Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD") Signed-off-by: Chengwen Feng --- drivers/net/failsafe/failsafe_args.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/failsafe/failsafe_args.c b/drivers/net/failsafe/failsafe_args.c index b203e02d9a..3b867437d7 100644 --- a/drivers/net/failsafe/failsafe_args.c +++ b/drivers/net/failsafe/failsafe_args.c @@ -248,7 +248,7 @@ fs_parse_device_param(struct rte_eth_dev *dev, const char *param, goto free_args; } else { ERROR("Unrecognized device type: %.*s", (int)b, param); - return -EINVAL; + ret = -EINVAL; } free_args: free(args); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-05 17:39:32.019396234 +0800 +++ 0032-net-failsafe-fix-memory-leak-in-args-parsing.patch 2024-03-05 17:39:30.723566491 +0800 @@ -1 +1 @@ -From 2ddf2d7a15deeac3585e08fd7f9ef46ad082b126 Mon Sep 17 00:00:00 2001 +From 2044a179a7605771a17920dd560ca450b1131a4b Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 2ddf2d7a15deeac3585e08fd7f9ef46ad082b126 ] @@ -9 +11,0 @@ -Cc: stable@dpdk.org