From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8700A43B86 for ; Tue, 5 Mar 2024 10:51:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E42642DDF; Tue, 5 Mar 2024 10:51:41 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2089.outbound.protection.outlook.com [40.107.223.89]) by mails.dpdk.org (Postfix) with ESMTP id 66C1442DCD for ; Tue, 5 Mar 2024 10:51:40 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TVDZMdp+BC2r12pjQxjr1hp8Z9QDTFaYAGCM4Cq3krpgeRX/GYoYIJZh9VIpjo7W1Jovx3bjSnEHOEugIEvCju6yt1FU/jiSiQplY+2SfRXZvKc6HLGvz6HtehJ/MQez5Kk+aixKfjdVF3VFNR8sAd5Hk6PIv7DekZJVwLESwpm73PPu7nvi3q1fhJNlI2zB76ne1N+rRXG9DUUXJmWEf0d9AFU2H0zrx0dLR4mqgzQ92UDoK+SAcmOEG9ClvVKv6z9h33JuMMJZtCsUKiDqeNDpHdTanX51ZF/n/IqVWWqXj2tXBdR4iCEMFqzVkzbBArZQwABwKMdG80Db9NmgGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l8DP7n3BVE26NwrQxRyHtta/UfZzlSWZuY+aIpbJN0s=; b=SBUeot87FOWxjNSyAie5On9Y1p9OjQxgmREspU5VCzki5trRIsr89GjTs6V47mSW15AIJIx9pJZskzMV6Nai/FYr7/lfDXHJvm8Az2y4CPqdfn9ESThzdYiXisNphmM+QJOEuRHrLw6WzP4bO+jeUtkO0vXN7m5U+vNNiwgkMy5HqQnZVQRkwHqIuZtwiJVKy8p9GMLVqoYzuQ6EQpMSPCLXZaLRc116kxr3g4b3GatfPJF1KiAoCDbgywx54hheH9yKtWTJzR0apzf+hdSLlyIJDtao1tMEVhF2EADidu5NJCeWjbQJfRCgbVrgUNVtgF3Ic+5x7RilPms3zq09Og== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=huawei.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l8DP7n3BVE26NwrQxRyHtta/UfZzlSWZuY+aIpbJN0s=; b=BqPefWjvjRdtgu1zw5fnwaXGOaLeuor5jJRHFdqwuXYSotDVAMVH5ZtjWMCxToy2DAeE0r0LnMYDOlCEzHSInGnHNgAb6JrdqVoH92RSvk1Md9oqHIuBpsOIzbHFPyYFna4omm+CkDMSlQY7CfEuxPyu6BW6hYXWZBLsn4ylO8ykIEkgkJ9ZydkNlEKargvgD8beudSpUDnZ/+FRil5A8lJNHf3jlnO9O0zzJXTiR3MCP3tBa1mQfpNrMaW+l7I5VgNdh1grgXEvxy7R1LTXrxaZ0YdE81Nz9/5O51CkbTfq69Yc1AAvsSEHgO4gUnFdiswXMaorSg2U+L8f8rT2jg== Received: from CY8PR10CA0038.namprd10.prod.outlook.com (2603:10b6:930:4b::22) by PH7PR12MB7161.namprd12.prod.outlook.com (2603:10b6:510:200::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.39; Tue, 5 Mar 2024 09:51:38 +0000 Received: from CY4PEPF0000FCBF.namprd03.prod.outlook.com (2603:10b6:930:4b:cafe::e0) by CY8PR10CA0038.outlook.office365.com (2603:10b6:930:4b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.39 via Frontend Transport; Tue, 5 Mar 2024 09:51:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000FCBF.mail.protection.outlook.com (10.167.242.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.11 via Frontend Transport; Tue, 5 Mar 2024 09:51:37 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 5 Mar 2024 01:51:25 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Tue, 5 Mar 2024 01:51:24 -0800 From: Xueming Li To: Chengwen Feng CC: Ivan Malov , Huisong Li , dpdk stable Subject: patch 'app/testpmd: verify strdup return' has been queued to stable release 23.11.1 Date: Tue, 5 Mar 2024 17:46:19 +0800 Message-ID: <20240305094757.439387-39-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240305094757.439387-1-xuemingl@nvidia.com> References: <20240305094757.439387-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000FCBF:EE_|PH7PR12MB7161:EE_ X-MS-Office365-Filtering-Correlation-Id: 75ca483f-cdbe-403d-5c74-08dc3cf9d968 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +p3oNO9Mzcwon/wpKY0UmCJzXX1Xomi460KziRvo+Jcj+FUKXrJVtx2SA/jM5A1fpiBevAeaVk2NpK81p15AwiCGmbm5qGSx/CGT77gF9kyIhQT3IUSdFiwQWE9hZP+WV0MchuNkrr1GJqonT9du655ESyu9iv7NzejMFzn+onfW7h8gERSdLxi4ZCaGM4HIDEsipYWXi1n110dmOMrK2ziol7m3KzyVNT+98MQ7IPRAJrLu0d863R1gCB6MZgfpO+B2uC5is0agGaffs6nafRZIEHG4q7CxBX0cD7GVr5CAgiElR8hJLSiAgeNMkfeZ/AY7KQRaR+SAmr8OaOBYuGPY0Uw5rJ6KaYl0GK36Nih4j+7WMxEq+4fHDlO1icTQzHz8ZxBntaS2elFUE3d9z/7Wo+7XZXrrIM024w77G47hk4rJObZZaPufpJ4/eykxOWRNz+on8qCyyJJqKGKEA2bSA71ppC0QFX444TCqMqYDqqykD4SlaPe4TbihZWpoPV+y45TeSr1dpUTbpQxMUEa09mYWpamlGqEHjTa9+ICgeSHODD28lnP+/jfNmyQsaXKJpx1qvLeMRrBypFnR4oE8E7jF/hM4CEqCw0l0JkV4zL6QDwdhAe7Hd+cTSh19lRUda2L2KGAtUMogLOppi4XKezxX0mV/Ut+yG6opyHmaPZAhMkBVnkJhbh/EckHXMbH0C8WLkHc1xyaeSNI9/586b6WdZnLPsYYzld+Mzk8L8nX/on8/r4R27xfkFAiH X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(82310400014)(36860700004)(376005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2024 09:51:37.0380 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 75ca483f-cdbe-403d-5c74-08dc3cf9d968 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000FCBF.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7161 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/31/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=c830d9e2afb0cdb8748d8d31347a36f24ea039c6 Thanks. Xueming Li --- >From c830d9e2afb0cdb8748d8d31347a36f24ea039c6 Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Fri, 10 Nov 2023 10:01:15 +0000 Subject: [PATCH] app/testpmd: verify strdup return Cc: Xueming Li [ upstream commit 365cdd7d01f70da2b10671aea05c5aaa036d3771 ] Add verify strdup return value logic. Fixes: 52e2e7edcf48 ("app/testpmd: add protocol-based buffer split") Signed-off-by: Chengwen Feng Acked-by: Ivan Malov Acked-by: Huisong Li --- app/test-pmd/cmdline.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 9369d3b4c5..d9304e4a32 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -3528,6 +3528,8 @@ parse_hdrs_list(const char *str, const char *item_name, unsigned int max_items, nb_item = 0; char *str2 = strdup(str); + if (str2 == NULL) + return nb_item; cur = strtok_r(str2, ",", &tmp); while (cur != NULL) { parsed_items[nb_item] = get_ptype(cur); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-05 17:39:32.189705840 +0800 +++ 0038-app-testpmd-verify-strdup-return.patch 2024-03-05 17:39:30.733566492 +0800 @@ -1 +1 @@ -From 365cdd7d01f70da2b10671aea05c5aaa036d3771 Mon Sep 17 00:00:00 2001 +From c830d9e2afb0cdb8748d8d31347a36f24ea039c6 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 365cdd7d01f70da2b10671aea05c5aaa036d3771 ] @@ -9 +11,0 @@ -Cc: stable@dpdk.org