From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87CB243B86 for ; Tue, 5 Mar 2024 10:54:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 828FD42E39; Tue, 5 Mar 2024 10:54:24 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2061.outbound.protection.outlook.com [40.107.94.61]) by mails.dpdk.org (Postfix) with ESMTP id 85BB442E23 for ; Tue, 5 Mar 2024 10:54:23 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eDp/BKY7ArWHJVWC1l9zWxMtwg+pPfgYZtKAhDqu0DEt0IvDngU7SZeujK/VBaGj8kRiy/EbAyNTbSVmvIoGmQb1ln7qQHOacNBAs1aWrCBnWM2fekIR3d5D3vVKCGt+3PNaOcUsKhvfl0D2hcGR2Nt1TEBeQuoGs2jbXk3BWYFPOTYjIUjxWi8QVXsKrSF4TQV6/5BvBpv8GQxwaddPAXROjq/I1OX4XA1v3eUw9NZMcnnkzNzKe/AxNhPt6yyfe5JrqLp5fHajPDIPZjwLZFZ/n9UxyGoUIjcyEugpxxqNOzMtw5Nw2xCtpqHbaQtXZ8vZv9bZdFgY8YXDpD6hsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TpmIdNqcy4uq38Qtvi8kR+J/U7uQmjPZC2ih+pLbpYA=; b=VRFqY4yegAs/0N8DG5Shw/aYCYikqkl2gfhij3w5rG6ykaSbSTFewm0u/d1G+QTjQGpjFk4Z13bjsO+1e0wEhpnm46crKnuja2CNcaM0Cs2LKStpfs1WFd7OCbkTFwaP6Sls0v8Q8eTM87xJnIs9i+WnjGCHsiptp4h1+CLytFtwzEVX/wb3tlKhdjdlNebSn91FJiHG8+XXO4ZsYGwUX18KTWNOH2DnnaIl9ukQpmApzQt/HJo/TJ68duH14zVOkoOQ0kFxqFg/hBzxBZJ/AhpIRCbAeGJWBtDqzoSgYE2gN4VvucHLQ1y9HKTent/xIaFMDsATj/wkkfy1LxTv3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=marvell.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TpmIdNqcy4uq38Qtvi8kR+J/U7uQmjPZC2ih+pLbpYA=; b=ZussGO/N2e4ZKhAa30daUxY7llPg/ozKs1MOg4yhqZdFjTHcQW4fk1l2RDfpL0c/7a4Zy9UDRH7gP6LaTJv6wzyuR0S9P0ZNLCWe0oRjU4DoB7F3QOMnIs2cp9wHhg2sp0M8iCpK7sVnrt9re0eneQWA7598eiIP5H2r1yMQQXsqf8gNP6LYUvMn5f6CE1fcNrORtwvOe5YgE6gDeRnc7MUPjHbe3pX7++w7iOUNnmR3QnZ6AtWTRUeh1AK0/mCC4uqjqmFnB1ninIWwhGjJjB9LHNNt1ui9Qwlz5ZflyPqBRarmD6Lf/o3CLWCtx33E/9QAxSdev4VQFDHnCp04Qg== Received: from MW4PR03CA0212.namprd03.prod.outlook.com (2603:10b6:303:b9::7) by DM4PR12MB5940.namprd12.prod.outlook.com (2603:10b6:8:6b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.38; Tue, 5 Mar 2024 09:54:20 +0000 Received: from CO1PEPF000042AB.namprd03.prod.outlook.com (2603:10b6:303:b9:cafe::6d) by MW4PR03CA0212.outlook.office365.com (2603:10b6:303:b9::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.39 via Frontend Transport; Tue, 5 Mar 2024 09:54:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1PEPF000042AB.mail.protection.outlook.com (10.167.243.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.11 via Frontend Transport; Tue, 5 Mar 2024 09:54:20 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 5 Mar 2024 01:54:04 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Tue, 5 Mar 2024 01:54:02 -0800 From: Xueming Li To: Suanming Mou CC: Anoob Joseph , Ciara Power , dpdk stable Subject: patch 'app/crypto-perf: fix data comparison' has been queued to stable release 23.11.1 Date: Tue, 5 Mar 2024 17:46:48 +0800 Message-ID: <20240305094757.439387-68-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240305094757.439387-1-xuemingl@nvidia.com> References: <20240305094757.439387-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000042AB:EE_|DM4PR12MB5940:EE_ X-MS-Office365-Filtering-Correlation-Id: 4c43acc0-43ab-44bf-68d5-08dc3cfa3a99 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2gKovW3egLiZIacNEWIR0DTbLPfJtpDtt8q5VfiZ+Kilx43cIV3Gx8ZHD5HegfsNCPQx59Z3ZML9OQcOywz/EyiKIvWvfQO5E+HRbJRnh9eDvQ+fZ8zkCgU7Yl3se30vV86VcgMZ4W2OAYlMuLzU+9whfxxTSbTTbzAxTA6E8d34wCJt8pl2tMExIVO7wbb8SCetjRP9+ZpK/g23N78d8s/CsPDU3erEXYrmRJF7tlP6b7USvXYTncIdCShcQUMYX8GNn83mWIOEhWnVS3iYCzXeBQlBHazs+5KBx8YBPF/yF1QcHim1Wq0YDQvKcI5iAjYOQXpRwDUDPQdcs5mXP8A/gCvkITHMcYqNH9sKsNN+sBsooESz9LRCUIyo4XpatDC23/1Bnwd3cGI281gzdpVMw4ajdIX6vHLK3I/mGyFGn3pdieWmMo4Un4yW7mNDwC57x8pGn+TQ2XtZc774GLqxtUoAAbbF9KoNJyviBzG7VsvFNvfmVgJ27z5exTtPZqWstFwZZ3VAwDLR6Il5GYBzpK418HzQRRY/BN/DSJmMaMNY+CcDXX9nieKgBe9rnD9bw3lyhmVXPTDORCPKzWNLVQORPmWFzGXJ7Vk+/i5T1wxqxZETJ0wqtrmnvBmJFamUpKSqgnJi/yZldP89GpuLA2U2IUFgN3YQ7IDn2La93FBekqX54vd9jbzFX3lsxOu/hzdeaUx60gx8w2rehIPc0ciICQtTS4w1pWcHtJrEp4dAhwI730etMdbU+snR X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(82310400014)(36860700004)(376005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2024 09:54:20.0984 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4c43acc0-43ab-44bf-68d5-08dc3cfa3a99 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000042AB.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5940 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/31/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=04d9dfd6655c1604a1496601a8dac81580b6ec8f Thanks. Xueming Li --- >From 04d9dfd6655c1604a1496601a8dac81580b6ec8f Mon Sep 17 00:00:00 2001 From: Suanming Mou Date: Fri, 5 Jan 2024 08:03:22 +0800 Subject: [PATCH] app/crypto-perf: fix data comparison Cc: Xueming Li [ upstream commit ddec2a39bae12da2817392239ddce19f3953fd53 ] The function memcmp() returns an integer less than, equal to, or greater than zero. In current code, if the first memcmp() returns less than zero and the second memcmp() returns greater than zero, the sum of results may still be 0 and indicates verify successed. This commit converts the return value to be zero or greater than zero. That will make sure the sum of results be correct. Fixes: df52cb3b6e13 ("app/crypto-perf: move verify as single test type") Signed-off-by: Suanming Mou Acked-by: Anoob Joseph Acked-by: Ciara Power --- app/test-crypto-perf/cperf_test_verify.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/test-crypto-perf/cperf_test_verify.c b/app/test-crypto-perf/cperf_test_verify.c index a6c0ffe813..8aa714b969 100644 --- a/app/test-crypto-perf/cperf_test_verify.c +++ b/app/test-crypto-perf/cperf_test_verify.c @@ -186,18 +186,18 @@ cperf_verify_op(struct rte_crypto_op *op, if (cipher == 1) { if (options->cipher_op == RTE_CRYPTO_CIPHER_OP_ENCRYPT) - res += memcmp(data + cipher_offset, + res += !!memcmp(data + cipher_offset, vector->ciphertext.data, options->test_buffer_size); else - res += memcmp(data + cipher_offset, + res += !!memcmp(data + cipher_offset, vector->plaintext.data, options->test_buffer_size); } if (auth == 1) { if (options->auth_op == RTE_CRYPTO_AUTH_OP_GENERATE) - res += memcmp(data + auth_offset, + res += !!memcmp(data + auth_offset, vector->digest.data, options->digest_sz); } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-05 17:39:32.955412366 +0800 +++ 0067-app-crypto-perf-fix-data-comparison.patch 2024-03-05 17:39:30.783566493 +0800 @@ -1 +1 @@ -From ddec2a39bae12da2817392239ddce19f3953fd53 Mon Sep 17 00:00:00 2001 +From 04d9dfd6655c1604a1496601a8dac81580b6ec8f Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit ddec2a39bae12da2817392239ddce19f3953fd53 ] @@ -16 +18,0 @@ -Cc: stable@dpdk.org