From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D07343B7D for ; Tue, 5 Mar 2024 10:56:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 841944161A; Tue, 5 Mar 2024 10:56:59 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2065.outbound.protection.outlook.com [40.107.94.65]) by mails.dpdk.org (Postfix) with ESMTP id 5FE2C4014F for ; Tue, 5 Mar 2024 10:56:58 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=avJDg28v1tC1hH5RkCtlzsXHSsliXjq1B+4rj4cAx38kgkJcOSoxzLtEwua5M8v6JIKWa9QbiSfcSKpIzByMqFT8+CXPPx6QZdKpUj2IwLmu/LTjOZwRXSTYYvXlp18ENMs8nTcSTX6UoZ2ENgkfxHsfp6VOrNTsrbWXLzIH5Mgaig+63jriBzNrLpwN8hc5ECk7wABNQBLHTnI9n8Yy412GkbF/XM2EtRyZN69s3s59PXFELyesiMOcXBSRtLkI4OtU3YbWhVo/ZBh50E/3NDTRQY5fLHFsT0kdWcfzxiefCmEA+KKccc2A5FVEnoY6bjO1BLpghllmd+CC+YQnww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GynTPOQ1dmswuoI+vj98Mv2HbI6UY+xaXqXavm9NHos=; b=iXqsuqZ6YmHPSiVX0obcK2VMTvL8Hn5ai0ZX9ZFLhwgNllpSpfU4hhFE5BO21aSE9k3XZSF51E/JjiMYmC2aDpTDJQ77QFCfOTiBTlWUa65XIs5Vgww5ZguuGEN9yYlme2FKf5M3dgVgijFX+g6QFAMvhtrHurkFkLTcrdwh03SxF3E1EWn24w/7SfX+TIt4S8zNt9k/2GZdDIM4TaNDiAEJBAearlUGDm6MRmtC2NHNDDYwAGLYS3oK7CNopssbAwL4Z/RKSPzIwIILzIU5ZtioRYQGe1mSX58RvxMgNiCXhUrpmy6eP1rl/5LR9RmzP7IuOgmTLvpubyieVx2ZGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=corigine.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GynTPOQ1dmswuoI+vj98Mv2HbI6UY+xaXqXavm9NHos=; b=ZaFC4QNxVhrHH0XnA7qUVR4cZgwO42n5DNo+3M/uGHeKAk47eHrRElwwiDRefQCLb1kx/qY4432HVUxJ8ygbriu11BXgmd8ekm+YUjenR9AbVwJ+u3aqC38ZtjdNQz70IebFDrXzzEvMR/e8l5tDQMOhHfE5HON8Y4vZeMqfuSGEgIUTTDupORprAKGt3jMBVyupMwqEYK5w4c/FsuaktbScd7lhG59+kdkisryKUI05kFBNSAXdjliKwXWSCRv3DMm2AjHCh4t5CSfqgSwbPWvc+owCLroDGL0KUsaq2g6/E7G49rwvvPx1oyjVxjfRT0JSxi1o1B9SDENEFhku+g== Received: from MW4PR04CA0082.namprd04.prod.outlook.com (2603:10b6:303:6b::27) by MN2PR12MB4486.namprd12.prod.outlook.com (2603:10b6:208:263::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.39; Tue, 5 Mar 2024 09:56:55 +0000 Received: from CO1PEPF000042AC.namprd03.prod.outlook.com (2603:10b6:303:6b:cafe::e0) by MW4PR04CA0082.outlook.office365.com (2603:10b6:303:6b::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.39 via Frontend Transport; Tue, 5 Mar 2024 09:56:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1PEPF000042AC.mail.protection.outlook.com (10.167.243.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.11 via Frontend Transport; Tue, 5 Mar 2024 09:56:55 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 5 Mar 2024 01:56:40 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Tue, 5 Mar 2024 01:56:39 -0800 From: Xueming Li To: Long Wu CC: Chaoyong He , Peng Zhang , dpdk stable Subject: patch 'net/nfp: fix device close' has been queued to stable release 23.11.1 Date: Tue, 5 Mar 2024 17:47:16 +0800 Message-ID: <20240305094757.439387-96-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240305094757.439387-1-xuemingl@nvidia.com> References: <20240305094757.439387-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000042AC:EE_|MN2PR12MB4486:EE_ X-MS-Office365-Filtering-Correlation-Id: a5486756-f953-4fc2-c998-08dc3cfa9703 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3GQ2bxy2q4gnVdcAfw6mLIGjnI681s5bNKabCGtkHyZRt2CJ7GqZqXJMxlSV7z5I/32iOd+BZUpuYYWehk5Dr9Tn9+W7XOX10LpHa+tfIfCpVWBjKjALI7WAVmRQbyRVuOjk0cfCSFWDtJnx76dABXe/3vx62IlqRQqwUjw5Rjxb7pQW0ck+cXKcVAR+pxjxHbdNDu6SJ8YseFKo0SAsNsP6jOCoI9nVMfEsfThBeQz8nm+czKepErCn0ld7EyNBMCa3IK1/UbqtpsiU8MRoPlo3mWKq4zVLV13GRVC5cxW3jZcwojhW/trlE0Uj45005/c+4qMp98tiMMFbxtG+GgDO3dhLLPha14WHixQ8MQQVQHhr55POvfjbsNwGParO5Q1gmQ9t6JgvglR0fWPEFMIxOe1OvAFcpVVduw2xgFXJ2SiNRm8m3tX8soWa9LPA2QJuPBzVVWf03tbLc1Tpxi5dEEuWjwBNZTD9qYPzu59EvrhRkhoxW27I6JQnRgJoZlkIOnVgiEShWxI9oiWv9y+lbcPC0mgYmbf/QJ3ygyGzu4a/v+Fc1xn9pBks1tq8tGPns2OyZr5stsNdPH408Wum84chVb/Wyk9TtYtsVX/lXIz3opsAttauJ9Nr4njZ06p4RSMZjHf0TUNVPclqfdLpI5o4iSE/DjU0PifE3WZWCy/0zbWUNy0tTo7/fWJZa2xH3wLA1y1QYvXg2zXyXna7RboD+ZVQi4SYAnso4QLdNcdMSp06NHkQQwtcQcvU X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(82310400014)(36860700004)(376005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2024 09:56:55.1303 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a5486756-f953-4fc2-c998-08dc3cfa9703 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000042AC.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4486 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/31/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=52bd57a03befe691c2bf6c2d257efbb8f2b0768e Thanks. Xueming Li --- >From 52bd57a03befe691c2bf6c2d257efbb8f2b0768e Mon Sep 17 00:00:00 2001 From: Long Wu Date: Thu, 14 Dec 2023 18:24:29 +0800 Subject: [PATCH] net/nfp: fix device close Cc: Xueming Li [ upstream commit 243bbfa0f92f57851ae9369133256a622c79a2a0 ] Close interface use "rte_eth_dev_destroy()" to destroy representor. The "rte_eth_dev_destroy()" will call "rte_eth_dev_release_port()" but the "rte_eth_dev_close()" also calls "rte_eth_dev_release_port()". This will cause Segmentation fault. Remove the "rte_eth_dev_destroy()" in nfp representor close interface. Fixes: 7c596721ae5f ("net/nfp: fix resource leak for flower firmware") Signed-off-by: Long Wu Reviewed-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower_representor.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c b/drivers/net/nfp/flower/nfp_flower_representor.c index 02089d390e..a18b3951da 100644 --- a/drivers/net/nfp/flower/nfp_flower_representor.c +++ b/drivers/net/nfp/flower/nfp_flower_representor.c @@ -314,13 +314,13 @@ nfp_flower_repr_free(struct nfp_flower_representor *repr, { switch (repr_type) { case NFP_REPR_TYPE_PHYS_PORT: - rte_eth_dev_destroy(repr->eth_dev, nfp_flower_repr_uninit); + nfp_flower_repr_uninit(repr->eth_dev); break; case NFP_REPR_TYPE_PF: - rte_eth_dev_destroy(repr->eth_dev, nfp_flower_pf_repr_uninit); + nfp_flower_pf_repr_uninit(repr->eth_dev); break; case NFP_REPR_TYPE_VF: - rte_eth_dev_destroy(repr->eth_dev, nfp_flower_repr_uninit); + nfp_flower_repr_uninit(repr->eth_dev); break; default: PMD_DRV_LOG(ERR, "Unsupported repr port type."); -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-05 17:39:33.867063196 +0800 +++ 0095-net-nfp-fix-device-close.patch 2024-03-05 17:39:30.863566496 +0800 @@ -1 +1 @@ -From 243bbfa0f92f57851ae9369133256a622c79a2a0 Mon Sep 17 00:00:00 2001 +From 52bd57a03befe691c2bf6c2d257efbb8f2b0768e Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 243bbfa0f92f57851ae9369133256a622c79a2a0 ] @@ -14 +16,0 @@ -Cc: stable@dpdk.org @@ -24 +26 @@ -index 7d8c055b80..27ea3891bd 100644 +index 02089d390e..a18b3951da 100644