From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36FDC43C60 for ; Thu, 7 Mar 2024 02:34:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1F9A242ECF; Thu, 7 Mar 2024 02:34:26 +0100 (CET) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by mails.dpdk.org (Postfix) with ESMTP id A23F242E64 for ; Thu, 7 Mar 2024 02:34:24 +0100 (CET) Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-41307d27b5fso3332955e9.1 for ; Wed, 06 Mar 2024 17:34:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709775264; x=1710380064; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Lm4AftHHxWlESagj/im37z0LMsi0TFIkAS/1UD+3ajo=; b=Cy4YUPRVdNDJynXCqzCT7zpT8AcqQiIh7BVq/YlFREir192q7LchrLJt8Xgu3esdxC Svb3EePKz2eF11NlWBLzmBtKK0/BOMfFYd+duPNdoLRS9a1V++bvb0P5TCOPDc3Xxs+N +Ki2E1DmW+PnJiGU+KjSLf8vXBI5VjIEFC0iZUpfVuiu2XKNEzpoVCIj7uR2DYVGHNdz bNUMp2F4mZz5owrf7NZFCPLF03m/zMA7r7sUq6ZOnuHnGACkYZqK3Qut78vb0Temald9 EbskqyhgnCtBRZRwXB2ge9rra85Ovc2vGsLdb3kYgxcl8BBl/PXZOwxMkyiMBNFq9xKL LTsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709775264; x=1710380064; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Lm4AftHHxWlESagj/im37z0LMsi0TFIkAS/1UD+3ajo=; b=agH0Q59l0LoM8PnSGBM9RMyY/gWrBAr4f6+rxCpzcr2eP+jXznHGegLfbk8ByP2qFg o0I8iiApfT/G7FTJwRMliITAIr5c3VJD1snHnMX8xyKnBfbJ4XY0aNVUMGz1imIr+4Ui cLebTIZ/NOM2CIeip3W/J6BKO2iRLLUMGijCPAgWJSf7R5WKQQq61jUTs8BDPY7ICmle O3b3qi7YwK4YsuDBkT38LCb850OMX9BunvqSmrolnFFEDdHbPw66Oi08CeUrDkDNcT89 BJAr5GzG7dIC66wHSENxe5wRRejZYBy+fG7wLld8vj0Rp9Bb5x6TPru3Ja1OjJq/7Rf8 e8rA== X-Forwarded-Encrypted: i=1; AJvYcCUaQGvUjiOU/hgjyACiTB0Xrv3I6Fls49TMFKsOrk6HCpziXPYJ1+mdaY5AhBmwvTG9m/4oizsIzsvddRNQY80= X-Gm-Message-State: AOJu0Ywf/bnkYb3SgoD2booi3K5ElrpwFSwrzxXMja24ZxVsvOLByaUn YGPxcn6y+onRCGNKb/n8SkawMluIc9jzKjRNzGNNI8V5bjKKGeAZ X-Google-Smtp-Source: AGHT+IGvpazpT8HPI7giJfFScGtcdg5hzV50V0fGpqVIKd7U9ogikWcg4GTCOXuBIiUYIm4fsy+Wsw== X-Received: by 2002:a05:600c:310c:b0:412:f047:4df1 with SMTP id g12-20020a05600c310c00b00412f0474df1mr3624399wmo.19.1709775264224; Wed, 06 Mar 2024 17:34:24 -0800 (PST) Received: from localhost ([137.220.120.171]) by smtp.gmail.com with ESMTPSA id j6-20020a05600c190600b00412ef3a68b5sm869744wmq.16.2024.03.06.17.34.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 17:34:23 -0800 (PST) From: luca.boccassi@gmail.com To: Ferruh Yigit Cc: =?UTF-8?q?Morten=20Br=C3=B8rup?= , Chengwen Feng , dpdk stable Subject: patch 'eventdev: fix calloc parameters' has been queued to stable release 22.11.5 Date: Thu, 7 Mar 2024 01:30:53 +0000 Message-Id: <20240307013159.1735343-36-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240307013159.1735343-1-luca.boccassi@gmail.com> References: <20240307013159.1735343-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/09/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/5b9e4068dc696ecff448acce7d6bdf766a69fe0f Thanks. Luca Boccassi --- >From 5b9e4068dc696ecff448acce7d6bdf766a69fe0f Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Wed, 24 Jan 2024 18:54:01 +0000 Subject: [PATCH] eventdev: fix calloc parameters MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 09fbda36e495bc6f24fbe26d0909801107bee5f7 ] gcc [1] generates warning [2] about calloc usage, because calloc parameter order is wrong, fixing it by replacing parameters. [1] gcc (GCC) 14.0.1 20240124 (experimental) [2] Compiling C object lib/librte_eventdev.a.p/eventdev_rte_eventdev.c.o ../lib/eventdev/rte_eventdev.c: In function ‘handle_dev_dump’: ../lib/eventdev/rte_eventdev.c:2005:29: warning: ‘calloc’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument [-Wcalloc-transposed-args] 2005 | buf = calloc(sizeof(char), RTE_TEL_MAX_SINGLE_STRING_LEN); | ^~~~ Fixes: a3b7b476d723 ("eventdev: support telemetry dump eventdev") Signed-off-by: Ferruh Yigit Acked-by: Morten Brørup Reviewed-by: Chengwen Feng --- lib/eventdev/rte_eventdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c index 941d53f6a7..4a2fe987fd 100644 --- a/lib/eventdev/rte_eventdev.c +++ b/lib/eventdev/rte_eventdev.c @@ -1834,7 +1834,7 @@ handle_dev_dump(const char *cmd __rte_unused, RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL); - buf = calloc(sizeof(char), RTE_TEL_MAX_SINGLE_STRING_LEN); + buf = calloc(RTE_TEL_MAX_SINGLE_STRING_LEN, sizeof(char)); if (buf == NULL) return -ENOMEM; -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-07 01:05:38.072947688 +0000 +++ 0036-eventdev-fix-calloc-parameters.patch 2024-03-07 01:05:34.750938997 +0000 @@ -1 +1 @@ -From 09fbda36e495bc6f24fbe26d0909801107bee5f7 Mon Sep 17 00:00:00 2001 +From 5b9e4068dc696ecff448acce7d6bdf766a69fe0f Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit 09fbda36e495bc6f24fbe26d0909801107bee5f7 ] + @@ -25 +26,0 @@ -Cc: stable@dpdk.org @@ -35 +36 @@ -index d494f8f205..ca295c87c4 100644 +index 941d53f6a7..4a2fe987fd 100644 @@ -38 +39 @@ -@@ -2005,7 +2005,7 @@ handle_dev_dump(const char *cmd __rte_unused, +@@ -1834,7 +1834,7 @@ handle_dev_dump(const char *cmd __rte_unused,