From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0E53043C60 for ; Thu, 7 Mar 2024 02:35:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 04E5042EE9; Thu, 7 Mar 2024 02:35:19 +0100 (CET) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by mails.dpdk.org (Postfix) with ESMTP id 1B45942EF8 for ; Thu, 7 Mar 2024 02:35:17 +0100 (CET) Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-413007fe6a3so3352475e9.3 for ; Wed, 06 Mar 2024 17:35:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709775317; x=1710380117; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tLJrZZt3UyzsUYIIsIQGuQDmPzM5ZvfdG2h22BCDEic=; b=LtvcCdJGFO2IRcOHSoW3IboRDZ0OnvGvf1rRVicVDCizwQZKtcFTovKy5mgUZZhFId 6ZIH9HyH8lKfqtpHpDBUgEAagqf5MaQVLE3PAa4oLrMVgNPmOCXOXM0K6T6Ibj+WZ/E2 4MeFzyFyN22DY40I3BrdmWE8V/SCZTHIABNaGY/xHXbX/4BpZhFk2Yd6ioAEr94eCGQP 1BbZDZwcjSFGRGDmTT4To8cVPsYeCU65n2pRyi0NttDMqCiYXcLQDVBlFpLbZn2vwnli afWjdefSXw2FpezkIeuaVexrC/vJ93XF12dq4Sj6BPznx/xcpnOeqVuNGjntYfXNmrax gCrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709775317; x=1710380117; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tLJrZZt3UyzsUYIIsIQGuQDmPzM5ZvfdG2h22BCDEic=; b=CoRyZ0uMofwOb67yrpuDrxNoFhn/2VXV5on25Gw/rhnuScJMM4pCe+JprSRzi5O4di aUTRTIqsGE885d215ogyQzXmXVivrsxDADAJtfKROyqL+M+g8anwJ7CS/YRLyxIi7QLZ 2tp6mKj+Cm15ReJtN7RXXFoGbGmh9blG/PxVRhpgDW/FyxGZy3d+WYbXPdxUBnofrTjF cQN/J/ordmSPJCdDk6mWK9vjKV38uvbBZtICZ65HnEJeC8FDxIaFvHj4Sw8EHwvb/FPB 34hypEn+GN+MHBjB+ti4EM12HEzs+T7W0WOL2pbPyZZhKG4JNkKYy9Q6kRESSqASdFzg Po2w== X-Forwarded-Encrypted: i=1; AJvYcCXJUKlpWk7Px+CkaC/m3eXYZYofVJlwKXPE2doPHhVpMQqp5D3onwEART51Hr3mg8lIFQIImfMnmkJL5DvTEjI= X-Gm-Message-State: AOJu0Yxq2mhsY9AjnbvkVYoBQxfUCNK+JNLIMrQVviUCENKOZP65ETK9 d4tLMA7i9NDzvrlpueeOG8FOMBs6uKHfYOqBtTfUpqrwTKnfFZNs X-Google-Smtp-Source: AGHT+IHBeSP5MZkIH/qyOXqn0cfcXTW09lTFu1vO7f5kAwEPOEI1uyKNgAgr4ZGPAscKxqjyUzUADA== X-Received: by 2002:a05:600c:a019:b0:412:e290:3dd1 with SMTP id jg25-20020a05600ca01900b00412e2903dd1mr7822700wmb.9.1709775316761; Wed, 06 Mar 2024 17:35:16 -0800 (PST) Received: from localhost ([137.220.120.171]) by smtp.gmail.com with ESMTPSA id l11-20020a05600c1d0b00b00412fc25691bsm863538wms.38.2024.03.06.17.35.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Mar 2024 17:35:15 -0800 (PST) From: luca.boccassi@gmail.com To: Suanming Mou Cc: Anoob Joseph , Ciara Power , dpdk stable Subject: patch 'app/crypto-perf: fix data comparison' has been queued to stable release 22.11.5 Date: Thu, 7 Mar 2024 01:31:10 +0000 Message-Id: <20240307013159.1735343-53-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240307013159.1735343-1-luca.boccassi@gmail.com> References: <20240307013159.1735343-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 03/09/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/642af46b1382e00388d74b109a783100f0f0d77a Thanks. Luca Boccassi --- >From 642af46b1382e00388d74b109a783100f0f0d77a Mon Sep 17 00:00:00 2001 From: Suanming Mou Date: Fri, 5 Jan 2024 08:03:22 +0800 Subject: [PATCH] app/crypto-perf: fix data comparison [ upstream commit ddec2a39bae12da2817392239ddce19f3953fd53 ] The function memcmp() returns an integer less than, equal to, or greater than zero. In current code, if the first memcmp() returns less than zero and the second memcmp() returns greater than zero, the sum of results may still be 0 and indicates verify successed. This commit converts the return value to be zero or greater than zero. That will make sure the sum of results be correct. Fixes: df52cb3b6e13 ("app/crypto-perf: move verify as single test type") Signed-off-by: Suanming Mou Acked-by: Anoob Joseph Acked-by: Ciara Power --- app/test-crypto-perf/cperf_test_verify.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/test-crypto-perf/cperf_test_verify.c b/app/test-crypto-perf/cperf_test_verify.c index 8042c94e04..02e90941ce 100644 --- a/app/test-crypto-perf/cperf_test_verify.c +++ b/app/test-crypto-perf/cperf_test_verify.c @@ -186,18 +186,18 @@ cperf_verify_op(struct rte_crypto_op *op, if (cipher == 1) { if (options->cipher_op == RTE_CRYPTO_CIPHER_OP_ENCRYPT) - res += memcmp(data + cipher_offset, + res += !!memcmp(data + cipher_offset, vector->ciphertext.data, options->test_buffer_size); else - res += memcmp(data + cipher_offset, + res += !!memcmp(data + cipher_offset, vector->plaintext.data, options->test_buffer_size); } if (auth == 1) { if (options->auth_op == RTE_CRYPTO_AUTH_OP_GENERATE) - res += memcmp(data + auth_offset, + res += !!memcmp(data + auth_offset, vector->digest.data, options->digest_sz); } -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-03-07 01:05:39.416916560 +0000 +++ 0053-app-crypto-perf-fix-data-comparison.patch 2024-03-07 01:05:34.806940186 +0000 @@ -1 +1 @@ -From ddec2a39bae12da2817392239ddce19f3953fd53 Mon Sep 17 00:00:00 2001 +From 642af46b1382e00388d74b109a783100f0f0d77a Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit ddec2a39bae12da2817392239ddce19f3953fd53 ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org @@ -26 +27 @@ -index a6c0ffe813..8aa714b969 100644 +index 8042c94e04..02e90941ce 100644